[INFO] updating cached repository aschampion/n5gest [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aschampion/n5gest [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aschampion/n5gest" "work/ex/clippy-test-run/sources/stable/gh/aschampion/n5gest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aschampion/n5gest'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aschampion/n5gest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aschampion/n5gest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aschampion/n5gest'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c2529f8e6d07190e26db83e71ff8405f8e54bbf9 [INFO] sha for GitHub repo aschampion/n5gest: c2529f8e6d07190e26db83e71ff8405f8e54bbf9 [INFO] validating manifest of aschampion/n5gest on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aschampion/n5gest on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aschampion/n5gest [INFO] finished frobbing aschampion/n5gest [INFO] frobbed toml for aschampion/n5gest written to work/ex/clippy-test-run/sources/stable/gh/aschampion/n5gest/Cargo.toml [INFO] started frobbing aschampion/n5gest [INFO] finished frobbing aschampion/n5gest [INFO] frobbed toml for aschampion/n5gest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aschampion/n5gest/Cargo.toml [INFO] crate aschampion/n5gest has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aschampion/n5gest against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aschampion/n5gest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b1f8ce1cab94dc596f4ee247f2c2b2dc567f8fa2a16482eb435ceb50fd120bd [INFO] running `"docker" "start" "-a" "7b1f8ce1cab94dc596f4ee247f2c2b2dc567f8fa2a16482eb435ceb50fd120bd"` [INFO] [stderr] Compiling getopts v0.2.17 [INFO] [stderr] Compiling filetime v0.1.15 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Compiling miniz_oxide_c_api v0.2.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Compiling lz4-sys v1.8.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking miniz_oxide v0.2.0 [INFO] [stderr] Checking inflate v0.4.3 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking meval v0.2.0 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Compiling lzma-sys v0.1.9 [INFO] [stderr] Compiling pulldown-cmark v0.0.8 [INFO] [stderr] Checking parking_lot_core v0.2.13 [INFO] [stderr] Checking num-complex v0.2.0 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Checking regex v1.0.3 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling structopt-derive v0.2.6 [INFO] [stderr] Checking parking_lot v0.5.4 [INFO] [stderr] Compiling skeptic v0.9.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking ndarray v0.12.0 [INFO] [stderr] Checking flate2 v1.0.4 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking bzip2 v0.3.2 [INFO] [stderr] Compiling lz4 v1.22.0 [INFO] [stderr] Checking structopt v0.2.6 [INFO] [stderr] Checking xz2 v0.1.4 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking n5 v0.2.4 [INFO] [stderr] Checking n5gest v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/import.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | for (slab_coord, slab_files) in files.chunks(slab_size).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `files.chunks(slab_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/import.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | for (slab_coord, slab_files) in files.chunks(slab_size).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `files.chunks(slab_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/import.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | slab_img_buff: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/import.rs:210:20 [INFO] [stderr] | [INFO] [stderr] 210 | slab_img_buff: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/import.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | slab_img_buff: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/import.rs:210:20 [INFO] [stderr] | [INFO] [stderr] 210 | slab_img_buff: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/map_fold.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | .unwrap_or(mf_opt.fold_expr.clone()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| mf_opt.fold_expr.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/map_fold.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | .unwrap_or(mf_opt.fold_expr.clone()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| mf_opt.fold_expr.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | #[derive(FromPrimitive, ToPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | #[derive(FromPrimitive, ToPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | #[derive(FromPrimitive, ToPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | #[derive(FromPrimitive, ToPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `n5gest`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `n5gest`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7b1f8ce1cab94dc596f4ee247f2c2b2dc567f8fa2a16482eb435ceb50fd120bd"` [INFO] running `"docker" "rm" "-f" "7b1f8ce1cab94dc596f4ee247f2c2b2dc567f8fa2a16482eb435ceb50fd120bd"` [INFO] [stdout] 7b1f8ce1cab94dc596f4ee247f2c2b2dc567f8fa2a16482eb435ceb50fd120bd