[INFO] updating cached repository asarode/piston-grok [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/asarode/piston-grok [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/asarode/piston-grok" "work/ex/clippy-test-run/sources/stable/gh/asarode/piston-grok"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/asarode/piston-grok'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/asarode/piston-grok" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asarode/piston-grok"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asarode/piston-grok'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 61592bceed93bc120e2ce695d466a94c2efb6c87 [INFO] sha for GitHub repo asarode/piston-grok: 61592bceed93bc120e2ce695d466a94c2efb6c87 [INFO] validating manifest of asarode/piston-grok on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asarode/piston-grok on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asarode/piston-grok [INFO] finished frobbing asarode/piston-grok [INFO] frobbed toml for asarode/piston-grok written to work/ex/clippy-test-run/sources/stable/gh/asarode/piston-grok/Cargo.toml [INFO] started frobbing asarode/piston-grok [INFO] finished frobbing asarode/piston-grok [INFO] frobbed toml for asarode/piston-grok written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asarode/piston-grok/Cargo.toml [INFO] crate asarode/piston-grok has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asarode/piston-grok against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/asarode/piston-grok:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 99fb52a3d7b2b37a6f5ec1d1e2d0185763be4152b369c73c82b0fe85154e0ab5 [INFO] running `"docker" "start" "-a" "99fb52a3d7b2b37a6f5ec1d1e2d0185763be4152b369c73c82b0fe85154e0ab5"` [INFO] [stderr] Compiling wayland-scanner v0.8.7 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking pistoncore-input v0.18.0 [INFO] [stderr] Compiling glutin v0.8.1 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking rayon v0.8.1 [INFO] [stderr] Compiling wayland-client v0.8.7 [INFO] [stderr] Checking pistoncore-window v0.27.0 [INFO] [stderr] Checking pistoncore-event_loop v0.32.0 [INFO] [stderr] Checking piston v0.32.0 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.43.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking piston-grok v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/circles.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/circles.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/circles.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `App` [INFO] [stderr] --> src/spinning_box.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct App { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `render` [INFO] [stderr] --> src/spinning_box.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | fn render(&mut self, args: &RenderArgs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/spinning_box.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | const GREEN: [f32; 4] = [0.0, 1.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RED` [INFO] [stderr] --> src/spinning_box.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | const RED: [f32; 4] = [1.0, 0.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/spinning_box.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `start` [INFO] [stderr] --> src/spinning_box.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn start() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spinning_box.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | let (x, y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spinning_box.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | let (x, y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/spinning_box.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/circles.rs:71:41 [INFO] [stderr] | [INFO] [stderr] 71 | let (viewport_x, viewport_y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/circles.rs:71:66 [INFO] [stderr] | [INFO] [stderr] 71 | let (viewport_x, viewport_y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/circles.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let ref holes = self.holes; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let holes = &self.holes;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/circles.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let ref simon = self.simon; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let simon = &self.simon;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/circles.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/circles.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `App` [INFO] [stderr] --> src/spinning_box.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct App { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `render` [INFO] [stderr] --> src/spinning_box.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | fn render(&mut self, args: &RenderArgs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/spinning_box.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | const GREEN: [f32; 4] = [0.0, 1.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RED` [INFO] [stderr] --> src/spinning_box.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | const RED: [f32; 4] = [1.0, 0.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/spinning_box.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `start` [INFO] [stderr] --> src/spinning_box.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn start() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spinning_box.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | let (x, y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spinning_box.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | let (x, y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/spinning_box.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/circles.rs:71:41 [INFO] [stderr] | [INFO] [stderr] 71 | let (viewport_x, viewport_y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/circles.rs:71:66 [INFO] [stderr] | [INFO] [stderr] 71 | let (viewport_x, viewport_y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/circles.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let ref holes = self.holes; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let holes = &self.holes;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/circles.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let ref simon = self.simon; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let simon = &self.simon;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/circles.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.13s [INFO] running `"docker" "inspect" "99fb52a3d7b2b37a6f5ec1d1e2d0185763be4152b369c73c82b0fe85154e0ab5"` [INFO] running `"docker" "rm" "-f" "99fb52a3d7b2b37a6f5ec1d1e2d0185763be4152b369c73c82b0fe85154e0ab5"` [INFO] [stdout] 99fb52a3d7b2b37a6f5ec1d1e2d0185763be4152b369c73c82b0fe85154e0ab5