[INFO] updating cached repository asampley/project-euler-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/asampley/project-euler-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/asampley/project-euler-rust" "work/ex/clippy-test-run/sources/stable/gh/asampley/project-euler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/asampley/project-euler-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/asampley/project-euler-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asampley/project-euler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asampley/project-euler-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec2b91e4aee0a28d21f0bcf89683ac6079b66ed2 [INFO] sha for GitHub repo asampley/project-euler-rust: ec2b91e4aee0a28d21f0bcf89683ac6079b66ed2 [INFO] validating manifest of asampley/project-euler-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asampley/project-euler-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asampley/project-euler-rust [INFO] finished frobbing asampley/project-euler-rust [INFO] frobbed toml for asampley/project-euler-rust written to work/ex/clippy-test-run/sources/stable/gh/asampley/project-euler-rust/Cargo.toml [INFO] started frobbing asampley/project-euler-rust [INFO] finished frobbing asampley/project-euler-rust [INFO] frobbed toml for asampley/project-euler-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asampley/project-euler-rust/Cargo.toml [INFO] crate asampley/project-euler-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asampley/project-euler-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/asampley/project-euler-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b282c48aab03cd6565bebd7a967e9894f47e709e5f7e751046ef37c5f882b45 [INFO] running `"docker" "start" "-a" "6b282c48aab03cd6565bebd7a967e9894f47e709e5f7e751046ef37c5f882b45"` [INFO] [stderr] Checking project-euler-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p4/mod.rs:24:2 [INFO] [stderr] | [INFO] [stderr] 24 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p4/mod.rs:24:2 [INFO] [stderr] | [INFO] [stderr] 24 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_prime` [INFO] [stderr] --> src/prime/mod.rs:23:2 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is_prime(&mut self, x: u64) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fibonacci/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | self.f1 = self.f0 + self.f1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.f1 += self.f0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/prime/mod.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is_prime(&mut self, x: u64) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prime/mod.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | Some(*self.cache.primes.get(self.i - 1).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.cache.primes[self.i - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p5/mod.rs:13:11 [INFO] [stderr] | [INFO] [stderr] 13 | for x in 0..max+1 { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p6/mod.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | (min..max+1).map(|x| x * x).sum() [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(min..=max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p6/mod.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | let x: u64 = (min..max+1).sum(); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(min..=max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/p8/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | .map(|c| c.to_digit(10).unwrap() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(c.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_prime` [INFO] [stderr] --> src/prime/mod.rs:23:2 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is_prime(&mut self, x: u64) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fibonacci/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | self.f1 = self.f0 + self.f1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.f1 += self.f0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/prime/mod.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is_prime(&mut self, x: u64) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prime/mod.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | Some(*self.cache.primes.get(self.i - 1).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.cache.primes[self.i - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p5/mod.rs:13:11 [INFO] [stderr] | [INFO] [stderr] 13 | for x in 0..max+1 { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p6/mod.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | (min..max+1).map(|x| x * x).sum() [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(min..=max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/p6/mod.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | let x: u64 = (min..max+1).sum(); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(min..=max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/p8/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | .map(|c| c.to_digit(10).unwrap() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(c.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "6b282c48aab03cd6565bebd7a967e9894f47e709e5f7e751046ef37c5f882b45"` [INFO] running `"docker" "rm" "-f" "6b282c48aab03cd6565bebd7a967e9894f47e709e5f7e751046ef37c5f882b45"` [INFO] [stdout] 6b282c48aab03cd6565bebd7a967e9894f47e709e5f7e751046ef37c5f882b45