[INFO] updating cached repository asaintgenis/rgrep
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/asaintgenis/rgrep
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/asaintgenis/rgrep" "work/ex/clippy-test-run/sources/stable/gh/asaintgenis/rgrep"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/asaintgenis/rgrep'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/asaintgenis/rgrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asaintgenis/rgrep"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asaintgenis/rgrep'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8803763fb2b660e7c51974b628de00acbac79c9b
[INFO] sha for GitHub repo asaintgenis/rgrep: 8803763fb2b660e7c51974b628de00acbac79c9b
[INFO] validating manifest of asaintgenis/rgrep on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of asaintgenis/rgrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing asaintgenis/rgrep
[INFO] finished frobbing asaintgenis/rgrep
[INFO] frobbed toml for asaintgenis/rgrep written to work/ex/clippy-test-run/sources/stable/gh/asaintgenis/rgrep/Cargo.toml
[INFO] started frobbing asaintgenis/rgrep
[INFO] finished frobbing asaintgenis/rgrep
[INFO] frobbed toml for asaintgenis/rgrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asaintgenis/rgrep/Cargo.toml
[INFO] crate asaintgenis/rgrep has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting asaintgenis/rgrep against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/asaintgenis/rgrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e56d48d16c5c7290eb0eab8dc423a892ddd61e71d7957002c247cca08915d90c
[INFO] running `"docker" "start" "-a" "e56d48d16c5c7290eb0eab8dc423a892ddd61e71d7957002c247cca08915d90c"`
[INFO] [stderr]     Checking rgrep v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return line.contains(to_find);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `line.contains(to_find)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return line.contains(to_find);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `line.contains(to_find)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         match is_found {
[INFO] [stderr] 27 | |             true => print_found_line(&x, &to_search, text),
[INFO] [stderr] 28 | |             false => ()
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_found { print_found_line(&x, &to_search, text) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         x = x + 1;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `x += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:34:25
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn search_in_line(line: &String, to_find: &str) -> bool {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:38:24
[INFO] [stderr]    |
[INFO] [stderr] 38 | fn print_found_line(x: &i32, line: &str, found: &str) {
[INFO] [stderr]    |                        ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         match is_found {
[INFO] [stderr] 27 | |             true => print_found_line(&x, &to_search, text),
[INFO] [stderr] 28 | |             false => ()
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_found { print_found_line(&x, &to_search, text) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         x = x + 1;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `x += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:34:25
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn search_in_line(line: &String, to_find: &str) -> bool {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:38:24
[INFO] [stderr]    |
[INFO] [stderr] 38 | fn print_found_line(x: &i32, line: &str, found: &str) {
[INFO] [stderr]    |                        ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.57s
[INFO] running `"docker" "inspect" "e56d48d16c5c7290eb0eab8dc423a892ddd61e71d7957002c247cca08915d90c"`
[INFO] running `"docker" "rm" "-f" "e56d48d16c5c7290eb0eab8dc423a892ddd61e71d7957002c247cca08915d90c"`
[INFO] [stdout] e56d48d16c5c7290eb0eab8dc423a892ddd61e71d7957002c247cca08915d90c