[INFO] updating cached repository aruizs/rusttracinginoneweekend [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aruizs/rusttracinginoneweekend [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aruizs/rusttracinginoneweekend" "work/ex/clippy-test-run/sources/stable/gh/aruizs/rusttracinginoneweekend"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aruizs/rusttracinginoneweekend'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aruizs/rusttracinginoneweekend" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aruizs/rusttracinginoneweekend"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aruizs/rusttracinginoneweekend'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2467906c0805747e304f1c63ff586a4f951115cc [INFO] sha for GitHub repo aruizs/rusttracinginoneweekend: 2467906c0805747e304f1c63ff586a4f951115cc [INFO] validating manifest of aruizs/rusttracinginoneweekend on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aruizs/rusttracinginoneweekend on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aruizs/rusttracinginoneweekend [INFO] finished frobbing aruizs/rusttracinginoneweekend [INFO] frobbed toml for aruizs/rusttracinginoneweekend written to work/ex/clippy-test-run/sources/stable/gh/aruizs/rusttracinginoneweekend/Cargo.toml [INFO] started frobbing aruizs/rusttracinginoneweekend [INFO] finished frobbing aruizs/rusttracinginoneweekend [INFO] frobbed toml for aruizs/rusttracinginoneweekend written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aruizs/rusttracinginoneweekend/Cargo.toml [INFO] crate aruizs/rusttracinginoneweekend has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting aruizs/rusttracinginoneweekend against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aruizs/rusttracinginoneweekend:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bb916fe51fd8d278887eb6e40399ce04f3fa6477fce0359bc714f41b4d5a9f2 [INFO] running `"docker" "start" "-a" "5bb916fe51fd8d278887eb6e40399ce04f3fa6477fce0359bc714f41b4d5a9f2"` [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking raytracinginoneweekend v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | let t = sqrt_num; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | let p = r.point_at_parameter(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | let t = sqrt_num; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | let p = r.point_at_parameter(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | return Some(HitRecord {t, p, normal}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(HitRecord {t, p, normal})` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | return Vec3::new(hit_record.normal.x() + 1.0, hit_record.normal.y() + 1.0, hit_record.normal.z() + 1.0) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(hit_record.normal.x() + 1.0, hit_record.normal.y() + 1.0, hit_record.normal.z() + 1.0) * 0.5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | return Vec3::new(1.0, 1.0, 1.0) * (1.0 - t) + Vec3::new(0.5, 0.7, 1.0) * t; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(1.0, 1.0, 1.0) * (1.0 - t) + Vec3::new(0.5, 0.7, 1.0) * t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/vec3.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | let vector = v.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ray.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | Ray { a: a_in.clone(), b: b_in.clone() } [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*a_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ray.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | Ray { a: a_in.clone(), b: b_in.clone() } [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*b_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/hitablelist.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | match hitting { [INFO] [stderr] | _____________^ [INFO] [stderr] 16 | | Some(hit_result) => { [INFO] [stderr] 17 | | closest_so_far = hit_result.t; [INFO] [stderr] 18 | | hit_record = Some(hit_result); [INFO] [stderr] ... | [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | if let Some(hit_result) = hitting { [INFO] [stderr] 16 | closest_so_far = hit_result.t; [INFO] [stderr] 17 | hit_record = Some(hit_result); [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | return Some(HitRecord {t, p, normal}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(HitRecord {t, p, normal})` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | return Vec3::new(hit_record.normal.x() + 1.0, hit_record.normal.y() + 1.0, hit_record.normal.z() + 1.0) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(hit_record.normal.x() + 1.0, hit_record.normal.y() + 1.0, hit_record.normal.z() + 1.0) * 0.5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | return Vec3::new(1.0, 1.0, 1.0) * (1.0 - t) + Vec3::new(0.5, 0.7, 1.0) * t; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(1.0, 1.0, 1.0) * (1.0 - t) + Vec3::new(0.5, 0.7, 1.0) * t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/vec3.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | let vector = v.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ray.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | Ray { a: a_in.clone(), b: b_in.clone() } [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*a_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ray.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | Ray { a: a_in.clone(), b: b_in.clone() } [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*b_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/hitablelist.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | match hitting { [INFO] [stderr] | _____________^ [INFO] [stderr] 16 | | Some(hit_result) => { [INFO] [stderr] 17 | | closest_so_far = hit_result.t; [INFO] [stderr] 18 | | hit_record = Some(hit_result); [INFO] [stderr] ... | [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | if let Some(hit_result) = hitting { [INFO] [stderr] 16 | closest_so_far = hit_result.t; [INFO] [stderr] 17 | hit_record = Some(hit_result); [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.94s [INFO] running `"docker" "inspect" "5bb916fe51fd8d278887eb6e40399ce04f3fa6477fce0359bc714f41b4d5a9f2"` [INFO] running `"docker" "rm" "-f" "5bb916fe51fd8d278887eb6e40399ce04f3fa6477fce0359bc714f41b4d5a9f2"` [INFO] [stdout] 5bb916fe51fd8d278887eb6e40399ce04f3fa6477fce0359bc714f41b4d5a9f2