[INFO] updating cached repository arthurmilliken/rustlab [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/arthurmilliken/rustlab [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/arthurmilliken/rustlab" "work/ex/clippy-test-run/sources/stable/gh/arthurmilliken/rustlab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/arthurmilliken/rustlab'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/arthurmilliken/rustlab" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arthurmilliken/rustlab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arthurmilliken/rustlab'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f57ce7f994186eef9f331f15d276c205842254da [INFO] sha for GitHub repo arthurmilliken/rustlab: f57ce7f994186eef9f331f15d276c205842254da [INFO] validating manifest of arthurmilliken/rustlab on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arthurmilliken/rustlab on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arthurmilliken/rustlab [INFO] finished frobbing arthurmilliken/rustlab [INFO] frobbed toml for arthurmilliken/rustlab written to work/ex/clippy-test-run/sources/stable/gh/arthurmilliken/rustlab/Cargo.toml [INFO] started frobbing arthurmilliken/rustlab [INFO] finished frobbing arthurmilliken/rustlab [INFO] frobbed toml for arthurmilliken/rustlab written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arthurmilliken/rustlab/Cargo.toml [INFO] crate arthurmilliken/rustlab has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arthurmilliken/rustlab against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/arthurmilliken/rustlab:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4ee8cf274029aa662236ed14ef0b095367cd7c7666b39685926a89a5e65bfeb3 [INFO] running `"docker" "start" "-a" "4ee8cf274029aa662236ed14ef0b095367cd7c7666b39685926a89a5e65bfeb3"` [INFO] [stderr] Compiling sqlite3-src v0.2.9 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking sqlite3-sys v0.12.0 [INFO] [stderr] Checking sqlite v0.23.9 [INFO] [stderr] Checking rustlab v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/sql/mod.rs:12:3 [INFO] [stderr] | [INFO] [stderr] 12 | CsvError(csv::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/sql/mod.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | SqlError(sqlite::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/sql/mod.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | IoError(io::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Error` [INFO] [stderr] --> src/sql/mod.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / enum Error { [INFO] [stderr] 12 | | CsvError(csv::Error), [INFO] [stderr] 13 | | SqlError(sqlite::Error), [INFO] [stderr] 14 | | IoError(io::Error), [INFO] [stderr] 15 | | // Message(String), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sql/writer.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | let mut values = format!("VALUES ("); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"VALUES (".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in rdr.headers()?.enumerate()` or similar iterators [INFO] [stderr] --> src/sql/writer.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for field in rdr.headers()? { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in self.rdr.records().enumerate()` or similar iterators [INFO] [stderr] --> src/sql/writer.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | for record in self.rdr.records() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/sql/mod.rs:12:3 [INFO] [stderr] | [INFO] [stderr] 12 | CsvError(csv::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/sql/mod.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | SqlError(sqlite::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/sql/mod.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | IoError(io::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Error` [INFO] [stderr] --> src/sql/mod.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / enum Error { [INFO] [stderr] 12 | | CsvError(csv::Error), [INFO] [stderr] 13 | | SqlError(sqlite::Error), [INFO] [stderr] 14 | | IoError(io::Error), [INFO] [stderr] 15 | | // Message(String), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sql/writer.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | let mut values = format!("VALUES ("); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"VALUES (".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in rdr.headers()?.enumerate()` or similar iterators [INFO] [stderr] --> src/sql/writer.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for field in rdr.headers()? { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in self.rdr.records().enumerate()` or similar iterators [INFO] [stderr] --> src/sql/writer.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | for record in self.rdr.records() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.40s [INFO] running `"docker" "inspect" "4ee8cf274029aa662236ed14ef0b095367cd7c7666b39685926a89a5e65bfeb3"` [INFO] running `"docker" "rm" "-f" "4ee8cf274029aa662236ed14ef0b095367cd7c7666b39685926a89a5e65bfeb3"` [INFO] [stdout] 4ee8cf274029aa662236ed14ef0b095367cd7c7666b39685926a89a5e65bfeb3