[INFO] updating cached repository artemshitov/stamp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/artemshitov/stamp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/artemshitov/stamp" "work/ex/clippy-test-run/sources/stable/gh/artemshitov/stamp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/artemshitov/stamp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/artemshitov/stamp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/artemshitov/stamp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/artemshitov/stamp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 503270ef572932ef9934bd9303fb494800ce449b [INFO] sha for GitHub repo artemshitov/stamp: 503270ef572932ef9934bd9303fb494800ce449b [INFO] validating manifest of artemshitov/stamp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of artemshitov/stamp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing artemshitov/stamp [INFO] finished frobbing artemshitov/stamp [INFO] frobbed toml for artemshitov/stamp written to work/ex/clippy-test-run/sources/stable/gh/artemshitov/stamp/Cargo.toml [INFO] started frobbing artemshitov/stamp [INFO] finished frobbing artemshitov/stamp [INFO] frobbed toml for artemshitov/stamp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/artemshitov/stamp/Cargo.toml [INFO] crate artemshitov/stamp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting artemshitov/stamp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/artemshitov/stamp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] acef9169ef945a0cfe38e49c83aa6da96fa92cac51d1181d719bebc688f5b9be [INFO] running `"docker" "start" "-a" "acef9169ef945a0cfe38e49c83aa6da96fa92cac51d1181d719bebc688f5b9be"` [INFO] [stderr] Checking stamp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template_file.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template_file.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template_file.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template_file.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template_file.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | const PATH_MUST_BE_UTF: &'static str = "Path must be a valid Unicode value"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | path = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template_file.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | const PATH_MUST_BE_UTF: &'static str = "Path must be a valid Unicode value"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | path = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | |v| Chunk::Var(Vec::from(v)) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `Vec::from()`: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | |v| Chunk::Var(Vec::from(v)) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `Vec::from()`: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.96s [INFO] running `"docker" "inspect" "acef9169ef945a0cfe38e49c83aa6da96fa92cac51d1181d719bebc688f5b9be"` [INFO] running `"docker" "rm" "-f" "acef9169ef945a0cfe38e49c83aa6da96fa92cac51d1181d719bebc688f5b9be"` [INFO] [stdout] acef9169ef945a0cfe38e49c83aa6da96fa92cac51d1181d719bebc688f5b9be