[INFO] updating cached repository arrrght/dnsdg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/arrrght/dnsdg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/arrrght/dnsdg" "work/ex/clippy-test-run/sources/stable/gh/arrrght/dnsdg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/arrrght/dnsdg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/arrrght/dnsdg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arrrght/dnsdg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arrrght/dnsdg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a6c1c2a2840b4f585ad5bf7dbb9c5455d0f1a9b1 [INFO] sha for GitHub repo arrrght/dnsdg: a6c1c2a2840b4f585ad5bf7dbb9c5455d0f1a9b1 [INFO] validating manifest of arrrght/dnsdg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arrrght/dnsdg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arrrght/dnsdg [INFO] finished frobbing arrrght/dnsdg [INFO] frobbed toml for arrrght/dnsdg written to work/ex/clippy-test-run/sources/stable/gh/arrrght/dnsdg/Cargo.toml [INFO] started frobbing arrrght/dnsdg [INFO] finished frobbing arrrght/dnsdg [INFO] frobbed toml for arrrght/dnsdg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arrrght/dnsdg/Cargo.toml [INFO] crate arrrght/dnsdg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arrrght/dnsdg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/arrrght/dnsdg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0778ae9fc19e87db083e215cfad9321f06515f7d96a289375a463a5ffb1de824 [INFO] running `"docker" "start" "-a" "0778ae9fc19e87db083e215cfad9321f06515f7d96a289375a463a5ffb1de824"` [INFO] [stderr] Checking dns-parser v0.8.0 [INFO] [stderr] Checking dnsdg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ping.rs:91:15 [INFO] [stderr] | [INFO] [stderr] 91 | let max = results.iter().max().unwrap().clone() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*results.iter().max().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ping.rs:92:15 [INFO] [stderr] | [INFO] [stderr] 92 | let min = results.iter().min().unwrap().clone() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*results.iter().min().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ping.rs:121:16 [INFO] [stderr] | [INFO] [stderr] 121 | let sock = (match server_sa.is_ipv6() { [INFO] [stderr] | ________________^ [INFO] [stderr] 122 | | true => UdpSocket::bind("[::]:0"), [INFO] [stderr] 123 | | _ => UdpSocket::bind("0.0.0.0:0"), [INFO] [stderr] 124 | | }) [INFO] [stderr] | |______^ help: consider using an if/else expression: `if server_sa.is_ipv6() { UdpSocket::bind("[::]:0") } else { UdpSocket::bind("0.0.0.0:0") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ping.rs:91:15 [INFO] [stderr] | [INFO] [stderr] 91 | let max = results.iter().max().unwrap().clone() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*results.iter().max().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ping.rs:92:15 [INFO] [stderr] | [INFO] [stderr] 92 | let min = results.iter().min().unwrap().clone() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*results.iter().min().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ping.rs:121:16 [INFO] [stderr] | [INFO] [stderr] 121 | let sock = (match server_sa.is_ipv6() { [INFO] [stderr] | ________________^ [INFO] [stderr] 122 | | true => UdpSocket::bind("[::]:0"), [INFO] [stderr] 123 | | _ => UdpSocket::bind("0.0.0.0:0"), [INFO] [stderr] 124 | | }) [INFO] [stderr] | |______^ help: consider using an if/else expression: `if server_sa.is_ipv6() { UdpSocket::bind("[::]:0") } else { UdpSocket::bind("0.0.0.0:0") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.31s [INFO] running `"docker" "inspect" "0778ae9fc19e87db083e215cfad9321f06515f7d96a289375a463a5ffb1de824"` [INFO] running `"docker" "rm" "-f" "0778ae9fc19e87db083e215cfad9321f06515f7d96a289375a463a5ffb1de824"` [INFO] [stdout] 0778ae9fc19e87db083e215cfad9321f06515f7d96a289375a463a5ffb1de824