[INFO] updating cached repository arionkrause/advent-of-code-2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/arionkrause/advent-of-code-2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/arionkrause/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable/gh/arionkrause/advent-of-code-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/arionkrause/advent-of-code-2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/arionkrause/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arionkrause/advent-of-code-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arionkrause/advent-of-code-2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 57c7aec8ee3b040aae37cb8d4362d018d6557244 [INFO] sha for GitHub repo arionkrause/advent-of-code-2017: 57c7aec8ee3b040aae37cb8d4362d018d6557244 [INFO] validating manifest of arionkrause/advent-of-code-2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arionkrause/advent-of-code-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arionkrause/advent-of-code-2017 [INFO] finished frobbing arionkrause/advent-of-code-2017 [INFO] frobbed toml for arionkrause/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable/gh/arionkrause/advent-of-code-2017/Cargo.toml [INFO] started frobbing arionkrause/advent-of-code-2017 [INFO] finished frobbing arionkrause/advent-of-code-2017 [INFO] frobbed toml for arionkrause/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arionkrause/advent-of-code-2017/Cargo.toml [INFO] crate arionkrause/advent-of-code-2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arionkrause/advent-of-code-2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/arionkrause/advent-of-code-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f365e07c9caa40e3953ed6d6d02bfec21c95ece7f32104dd2079d740b0431091 [INFO] running `"docker" "start" "-a" "f365e07c9caa40e3953ed6d6d02bfec21c95ece7f32104dd2079d740b0431091"` [INFO] [stderr] Checking advent-of-code-2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | let day3_number = 265149; [INFO] [stderr] | ^^^^^^ help: consider: `265_149` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | let day3_number = 265149; [INFO] [stderr] | ^^^^^^ help: consider: `265_149` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part1/mod.rs:1:27 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn solve(spreadsheet: &Vec, column_amount: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/day2/part1/mod.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | while let Some(chunk) = chunks.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for chunk in chunks { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part2/mod.rs:1:27 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn solve(spreadsheet: &Vec, column_amount: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/day2/part2/mod.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | while let Some(chunk) = chunks.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for chunk in chunks { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/day2/part2/mod.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | total += &chunk[index2] / &chunk[index1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 14 | total += chunk[index2] / chunk[index1]; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `arm_length` [INFO] [stderr] --> src/day3/part2/mod.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | if step < arm_length * 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day3/part2/mod.rs:63:40 [INFO] [stderr] | [INFO] [stderr] 63 | fn sum_of_surrounding_elements(matrix: &Vec>, side_size: usize, current_point_x: usize, current_point_y: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day3/part2/mod.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | fn print_spiral(matrix: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/day4/part2/mod.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | if input.split(' ').filter(|word2| { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 13 | | let mut ordered_characters2: Vec = word2.chars().collect(); [INFO] [stderr] 14 | | ordered_characters2.sort_by(|a, b| b.cmp(a)); [INFO] [stderr] 15 | | ordered_characters2 == ordered_characters [INFO] [stderr] 16 | | }).count() > 1 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5/part1/mod.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | jump_list[current_index] = jump_list[current_index] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `jump_list[current_index] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5/part2/mod.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | jump_list[current_index] = jump_list[current_index] - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `jump_list[current_index] -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5/part2/mod.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | jump_list[current_index] = jump_list[current_index] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `jump_list[current_index] += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day6/part1/mod.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | input.split("\t").map(|bank| bank.parse::().unwrap()).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day6/part2/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | input.split("\t").map(|bank| bank.parse::().unwrap()).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:58 [INFO] [stderr] | [INFO] [stderr] 24 | println!("Duration: {} ms", after.as_secs() * 1000 + (after.subsec_nanos() / 1_000_000) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(after.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:24:58 [INFO] [stderr] | [INFO] [stderr] 24 | println!("Duration: {} ms", after.as_secs() * 1000 + (after.subsec_nanos() / 1_000_000) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `after.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part1/mod.rs:1:27 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn solve(spreadsheet: &Vec, column_amount: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/day2/part1/mod.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | while let Some(chunk) = chunks.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for chunk in chunks { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/part2/mod.rs:1:27 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn solve(spreadsheet: &Vec, column_amount: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/day2/part2/mod.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | while let Some(chunk) = chunks.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for chunk in chunks { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/day2/part2/mod.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | total += &chunk[index2] / &chunk[index1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 14 | total += chunk[index2] / chunk[index1]; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `arm_length` [INFO] [stderr] --> src/day3/part2/mod.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | if step < arm_length * 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day3/part2/mod.rs:63:40 [INFO] [stderr] | [INFO] [stderr] 63 | fn sum_of_surrounding_elements(matrix: &Vec>, side_size: usize, current_point_x: usize, current_point_y: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day3/part2/mod.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | fn print_spiral(matrix: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/day4/part2/mod.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | if input.split(' ').filter(|word2| { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 13 | | let mut ordered_characters2: Vec = word2.chars().collect(); [INFO] [stderr] 14 | | ordered_characters2.sort_by(|a, b| b.cmp(a)); [INFO] [stderr] 15 | | ordered_characters2 == ordered_characters [INFO] [stderr] 16 | | }).count() > 1 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5/part1/mod.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | jump_list[current_index] = jump_list[current_index] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `jump_list[current_index] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5/part2/mod.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | jump_list[current_index] = jump_list[current_index] - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `jump_list[current_index] -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5/part2/mod.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | jump_list[current_index] = jump_list[current_index] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `jump_list[current_index] += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day6/part1/mod.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | input.split("\t").map(|bank| bank.parse::().unwrap()).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day6/part2/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | input.split("\t").map(|bank| bank.parse::().unwrap()).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:58 [INFO] [stderr] | [INFO] [stderr] 24 | println!("Duration: {} ms", after.as_secs() * 1000 + (after.subsec_nanos() / 1_000_000) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(after.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:24:58 [INFO] [stderr] | [INFO] [stderr] 24 | println!("Duration: {} ms", after.as_secs() * 1000 + (after.subsec_nanos() / 1_000_000) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `after.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "f365e07c9caa40e3953ed6d6d02bfec21c95ece7f32104dd2079d740b0431091"` [INFO] running `"docker" "rm" "-f" "f365e07c9caa40e3953ed6d6d02bfec21c95ece7f32104dd2079d740b0431091"` [INFO] [stdout] f365e07c9caa40e3953ed6d6d02bfec21c95ece7f32104dd2079d740b0431091