[INFO] updating cached repository arekfu/carlo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/arekfu/carlo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/arekfu/carlo" "work/ex/clippy-test-run/sources/stable/gh/arekfu/carlo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/arekfu/carlo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/arekfu/carlo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arekfu/carlo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arekfu/carlo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dccd5231ce43431911a6d444f986b8fa5322162b [INFO] sha for GitHub repo arekfu/carlo: dccd5231ce43431911a6d444f986b8fa5322162b [INFO] validating manifest of arekfu/carlo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arekfu/carlo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arekfu/carlo [INFO] finished frobbing arekfu/carlo [INFO] frobbed toml for arekfu/carlo written to work/ex/clippy-test-run/sources/stable/gh/arekfu/carlo/Cargo.toml [INFO] started frobbing arekfu/carlo [INFO] finished frobbing arekfu/carlo [INFO] frobbed toml for arekfu/carlo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arekfu/carlo/Cargo.toml [INFO] crate arekfu/carlo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arekfu/carlo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/arekfu/carlo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2f295814b242a0914c85025b8a8bede3a5758738d1edf8474bd510def3eb2c96 [INFO] running `"docker" "start" "-a" "2f295814b242a0914c85025b8a8bede3a5758738d1edf8474bd510def3eb2c96"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking wait-timeout v0.1.5 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking tokio-tls v0.2.0 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking tempfile v3.0.4 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking rusty-fork v0.2.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking proptest v0.8.7 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.12 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking irc v0.13.6 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.3 [INFO] [stderr] Checking carlo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/carlo/jenkins/cache.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | server: &ServerID, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/carlo/jenkins/cache.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | timestamp: &Timestamp, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/carlo/jenkins/cache.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .or_insert(HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/carlo/jenkins/cache.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn prune_except(&mut self, server: &ServerID, build_names: &Vec<&Name>) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/carlo/jenkins/cache.rs:48:68 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn prune_except(&mut self, server: &ServerID, build_names: &Vec<&Name>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/carlo/jenkins/cache.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | fn in_build_names(name: &Name, build_names: &Vec<&Name>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/carlo/jenkins/cache.rs:52:58 [INFO] [stderr] | [INFO] [stderr] 52 | let sub_cache = self.cache.entry(server.clone()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/carlo/jenkins/mod.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | fn prune_missing_builds(&mut self, job_vec: &Vec, j_config: &JenkinsConfig) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[JJob]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `carlo::Carlo` [INFO] [stderr] --> src/carlo/mod.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> Carlo { [INFO] [stderr] 44 | | debug!("New Carlo instance"); [INFO] [stderr] 45 | | Carlo { [INFO] [stderr] 46 | | start_time: Instant::now(), [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | impl Default for carlo::Carlo { [INFO] [stderr] 43 | fn default() -> Self { [INFO] [stderr] 44 | Self::new() [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/carlo/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / fn handle_updated_job( [INFO] [stderr] 110 | | &self, [INFO] [stderr] 111 | | server: String, [INFO] [stderr] 112 | | name: Name, [INFO] [stderr] ... | [INFO] [stderr] 139 | | }).collect() [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/carlo/jenkins/cache.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | server: &ServerID, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/carlo/jenkins/cache.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | timestamp: &Timestamp, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/carlo/jenkins/cache.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .or_insert(HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/carlo/jenkins/cache.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn prune_except(&mut self, server: &ServerID, build_names: &Vec<&Name>) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/carlo/jenkins/cache.rs:48:68 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn prune_except(&mut self, server: &ServerID, build_names: &Vec<&Name>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/carlo/jenkins/cache.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | fn in_build_names(name: &Name, build_names: &Vec<&Name>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/carlo/jenkins/cache.rs:52:58 [INFO] [stderr] | [INFO] [stderr] 52 | let sub_cache = self.cache.entry(server.clone()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carlo/jenkins/cache.rs:117:49 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(subcache.len(), *counts.get(server).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counts[server]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carlo/jenkins/cache.rs:142:49 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(subcache.len(), *counts.get(server).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counts[server]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/carlo/jenkins/mod.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | fn prune_missing_builds(&mut self, job_vec: &Vec, j_config: &JenkinsConfig) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[JJob]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `carlo::Carlo` [INFO] [stderr] --> src/carlo/mod.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> Carlo { [INFO] [stderr] 44 | | debug!("New Carlo instance"); [INFO] [stderr] 45 | | Carlo { [INFO] [stderr] 46 | | start_time: Instant::now(), [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | impl Default for carlo::Carlo { [INFO] [stderr] 43 | fn default() -> Self { [INFO] [stderr] 44 | Self::new() [INFO] [stderr] 45 | } [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/carlo/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / fn handle_updated_job( [INFO] [stderr] 110 | | &self, [INFO] [stderr] 111 | | server: String, [INFO] [stderr] 112 | | name: Name, [INFO] [stderr] ... | [INFO] [stderr] 139 | | }).collect() [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `"docker" "inspect" "2f295814b242a0914c85025b8a8bede3a5758738d1edf8474bd510def3eb2c96"` [INFO] running `"docker" "rm" "-f" "2f295814b242a0914c85025b8a8bede3a5758738d1edf8474bd510def3eb2c96"` [INFO] [stdout] 2f295814b242a0914c85025b8a8bede3a5758738d1edf8474bd510def3eb2c96