[INFO] updating cached repository arcnmx/mosh-server-upnp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/arcnmx/mosh-server-upnp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/arcnmx/mosh-server-upnp" "work/ex/clippy-test-run/sources/stable/gh/arcnmx/mosh-server-upnp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/arcnmx/mosh-server-upnp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/arcnmx/mosh-server-upnp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arcnmx/mosh-server-upnp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arcnmx/mosh-server-upnp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 154bf6261384c009c72f25190041d93ff655e5cd [INFO] sha for GitHub repo arcnmx/mosh-server-upnp: 154bf6261384c009c72f25190041d93ff655e5cd [INFO] validating manifest of arcnmx/mosh-server-upnp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arcnmx/mosh-server-upnp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arcnmx/mosh-server-upnp [INFO] finished frobbing arcnmx/mosh-server-upnp [INFO] frobbed toml for arcnmx/mosh-server-upnp written to work/ex/clippy-test-run/sources/stable/gh/arcnmx/mosh-server-upnp/Cargo.toml [INFO] started frobbing arcnmx/mosh-server-upnp [INFO] finished frobbing arcnmx/mosh-server-upnp [INFO] frobbed toml for arcnmx/mosh-server-upnp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arcnmx/mosh-server-upnp/Cargo.toml [INFO] crate arcnmx/mosh-server-upnp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arcnmx/mosh-server-upnp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/arcnmx/mosh-server-upnp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 548a5e3187cdbcd8fa205fca06ebada83f5af629466d2c1132ec0195b06388b4 [INFO] running `"docker" "start" "-a" "548a5e3187cdbcd8fa205fca06ebada83f5af629466d2c1132ec0195b06388b4"` [INFO] [stderr] Checking c_linked_list v1.1.1 [INFO] [stderr] Checking xml-rs v0.7.0 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking get_if_addrs v0.5.3 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking xmltree v0.7.0 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-retry v0.1.1 [INFO] [stderr] Checking igd v0.7.0 [INFO] [stderr] Checking mosh-server-upnp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:11:6 [INFO] [stderr] | [INFO] [stderr] 11 | ((octets[0] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:12:10 [INFO] [stderr] | [INFO] [stderr] 12 | ((octets[1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | ((octets[2] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | octets[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match addr.addr { [INFO] [stderr] 22 | | get_if_addrs::IfAddr::V4(addr) => { [INFO] [stderr] 23 | | let ip = addr_ip(addr.ip); [INFO] [stderr] 24 | | let netmask = addr_ip(addr.netmask); [INFO] [stderr] ... | [INFO] [stderr] 30 | | _ => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let get_if_addrs::IfAddr::V4(addr) = addr.addr { [INFO] [stderr] 22 | let ip = addr_ip(addr.ip); [INFO] [stderr] 23 | let netmask = addr_ip(addr.netmask); [INFO] [stderr] 24 | [INFO] [stderr] 25 | if (remote_addr & netmask) == (ip & netmask) { [INFO] [stderr] 26 | return Ok(addr) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:39:67 [INFO] [stderr] | [INFO] [stderr] 39 | let mosh_server = mosh_server.as_ref().map(|s| s.as_os_str()).unwrap_or("mosh-server".as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "mosh-server".as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:11:6 [INFO] [stderr] | [INFO] [stderr] 11 | ((octets[0] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:12:10 [INFO] [stderr] | [INFO] [stderr] 12 | ((octets[1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | ((octets[2] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | octets[3] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match addr.addr { [INFO] [stderr] 22 | | get_if_addrs::IfAddr::V4(addr) => { [INFO] [stderr] 23 | | let ip = addr_ip(addr.ip); [INFO] [stderr] 24 | | let netmask = addr_ip(addr.netmask); [INFO] [stderr] ... | [INFO] [stderr] 30 | | _ => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let get_if_addrs::IfAddr::V4(addr) = addr.addr { [INFO] [stderr] 22 | let ip = addr_ip(addr.ip); [INFO] [stderr] 23 | let netmask = addr_ip(addr.netmask); [INFO] [stderr] 24 | [INFO] [stderr] 25 | if (remote_addr & netmask) == (ip & netmask) { [INFO] [stderr] 26 | return Ok(addr) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:39:67 [INFO] [stderr] | [INFO] [stderr] 39 | let mosh_server = mosh_server.as_ref().map(|s| s.as_os_str()).unwrap_or("mosh-server".as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "mosh-server".as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.21s [INFO] running `"docker" "inspect" "548a5e3187cdbcd8fa205fca06ebada83f5af629466d2c1132ec0195b06388b4"` [INFO] running `"docker" "rm" "-f" "548a5e3187cdbcd8fa205fca06ebada83f5af629466d2c1132ec0195b06388b4"` [INFO] [stdout] 548a5e3187cdbcd8fa205fca06ebada83f5af629466d2c1132ec0195b06388b4