[INFO] updating cached repository archerfeel/azeroth-vm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/archerfeel/azeroth-vm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/archerfeel/azeroth-vm" "work/ex/clippy-test-run/sources/stable/gh/archerfeel/azeroth-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/archerfeel/azeroth-vm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/archerfeel/azeroth-vm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archerfeel/azeroth-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archerfeel/azeroth-vm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fcf57fee198fcece6805bc00d72d4d483d35834a [INFO] sha for GitHub repo archerfeel/azeroth-vm: fcf57fee198fcece6805bc00d72d4d483d35834a [INFO] validating manifest of archerfeel/azeroth-vm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of archerfeel/azeroth-vm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing archerfeel/azeroth-vm [INFO] finished frobbing archerfeel/azeroth-vm [INFO] frobbed toml for archerfeel/azeroth-vm written to work/ex/clippy-test-run/sources/stable/gh/archerfeel/azeroth-vm/Cargo.toml [INFO] started frobbing archerfeel/azeroth-vm [INFO] finished frobbing archerfeel/azeroth-vm [INFO] frobbed toml for archerfeel/azeroth-vm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archerfeel/azeroth-vm/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting archerfeel/azeroth-vm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/archerfeel/azeroth-vm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b9aed227e6fea7bbb47bc014127c69f5dc5238d939fcdfc34127a4a76d85464 [INFO] running `"docker" "start" "-a" "8b9aed227e6fea7bbb47bc014127c69f5dc5238d939fcdfc34127a4a76d85464"` [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Checking miniz_oxide v0.2.1 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Compiling miniz_oxide_c_api v0.2.1 [INFO] [stderr] Compiling bzip2-sys v0.1.7 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking parking_lot v0.3.8 [INFO] [stderr] Checking chashmap v2.2.0 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.3.3 [INFO] [stderr] Checking azeroth-vm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/attribute.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | start_pc: start_pc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `start_pc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/attribute.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | end_pc: end_pc, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `end_pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/attribute.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | handler_pc: handler_pc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `handler_pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/attribute.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | catch_type: catch_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `catch_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | access_flag: access_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | this_class_name: this_class_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `this_class_name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/attribute.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | start_pc: start_pc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `start_pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | super_class_name: super_class_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super_class_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | interfaces: interfaces, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interfaces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/field.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | access_flag: access_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/attribute.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | end_pc: end_pc, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `end_pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/attribute.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | handler_pc: handler_pc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `handler_pc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/attribute.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | catch_type: catch_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `catch_type` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/field.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | access_flag: access_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/method.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | access_flag: access_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | this_class_name: this_class_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `this_class_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem/heap.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | eden_size: eden_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `eden_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | super_class_name: super_class_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super_class_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | interfaces: interfaces, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interfaces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/class.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/field.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | access_flag: access_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/field.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bytecode/method.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | access_flag: access_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flag` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem/metaspace.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | bytecode: bytecode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bytecode` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem/metaspace.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | classloader: classloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `classloader` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem/heap.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | eden_size: eden_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `eden_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem/metaspace.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | cp: cp, [INFO] [stderr] | ^^^^^^ help: replace it with: `cp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem/metaspace.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | bytecode: bytecode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bytecode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem/metaspace.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | classloader: classloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `classloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem/metaspace.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | cp: cp, [INFO] [stderr] | ^^^^^^ help: replace it with: `cp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | pub const CONSTANT_VALUE: &'static str = "ConstantValue"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | pub const CODE: &'static str = "Code"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | pub const STACK_MAP_TABLE: &'static str = "StackMapTable"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub const EXCEPTIONS: &'static str = "Exceptions"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:40:31 [INFO] [stderr] | [INFO] [stderr] 40 | pub const BOOTSTRAP_METHODS: &'static str = "BootstrapMethods"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | pub const INNER_CLASSES: &'static str = "InnerClasses"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | pub const ENCLOSING_METHOD: &'static str = "EnclosingMethod"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | pub const SYNTHETIC: &'static str = "Synthetic"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | pub const SIGNATURE: &'static str = "Signature"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RUNTIME_VISIBLE_ANNOTATIONS: &'static str = "RuntimeVisibleAnnotations"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | pub const RUNTIME_INVISIBLE_ANNOTATIONS: &'static str = "RuntimeInvisibleAnnotations"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | pub const RUNTIME_VISIBLE_PARAMETER_ANNOTATIONS: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | pub const RUNTIME_INVISIBLE_PARAMETER_ANNOTATIONS: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | pub const RUNTIME_VISIBLE_TYPE_ANNOTATIONS: &'static str = "RuntimeVisibleTypeAnnotations"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | pub const RUNTIME_INVISIBLE_TYPE_ANNOTATIONS: &'static str = "RuntimeInvisibleTypeAnnotations"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | pub const ANNOTATION_DEFAULT: &'static str = "AnnotationDefault"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | pub const METHOD_PARAMETERS: &'static str = "MethodParameters"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bytecode/method.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::bytecode::class::*` [INFO] [stderr] --> src/interpreter/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::bytecode::class::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/interpreter/mod.rs:356:40 [INFO] [stderr] | [INFO] [stderr] 356 | } else { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 357 | | if let Some(v) = operands.pop() { [INFO] [stderr] 358 | | &field.value.set(Some(Value::Word(v))); [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 356 | } else if let Some(v) = operands.pop() { [INFO] [stderr] 357 | &field.value.set(Some(Value::Word(v))); [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | pub const CONSTANT_VALUE: &'static str = "ConstantValue"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | pub const CODE: &'static str = "Code"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | pub const STACK_MAP_TABLE: &'static str = "StackMapTable"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub const EXCEPTIONS: &'static str = "Exceptions"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:40:31 [INFO] [stderr] | [INFO] [stderr] 40 | pub const BOOTSTRAP_METHODS: &'static str = "BootstrapMethods"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | pub const INNER_CLASSES: &'static str = "InnerClasses"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | pub const ENCLOSING_METHOD: &'static str = "EnclosingMethod"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | pub const SYNTHETIC: &'static str = "Synthetic"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | pub const SIGNATURE: &'static str = "Signature"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RUNTIME_VISIBLE_ANNOTATIONS: &'static str = "RuntimeVisibleAnnotations"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | pub const RUNTIME_INVISIBLE_ANNOTATIONS: &'static str = "RuntimeInvisibleAnnotations"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | pub const RUNTIME_VISIBLE_PARAMETER_ANNOTATIONS: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | pub const RUNTIME_INVISIBLE_PARAMETER_ANNOTATIONS: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | pub const RUNTIME_VISIBLE_TYPE_ANNOTATIONS: &'static str = "RuntimeVisibleTypeAnnotations"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | pub const RUNTIME_INVISIBLE_TYPE_ANNOTATIONS: &'static str = "RuntimeInvisibleTypeAnnotations"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | pub const ANNOTATION_DEFAULT: &'static str = "AnnotationDefault"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bytecode/attribute.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | pub const METHOD_PARAMETERS: &'static str = "MethodParameters"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bytecode/method.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::bytecode::class::*` [INFO] [stderr] --> src/interpreter/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::bytecode::class::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/interpreter/mod.rs:356:40 [INFO] [stderr] | [INFO] [stderr] 356 | } else { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 357 | | if let Some(v) = operands.pop() { [INFO] [stderr] 358 | | &field.value.set(Some(Value::Word(v))); [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 356 | } else if let Some(v) = operands.pop() { [INFO] [stderr] 357 | &field.value.set(Some(Value::Word(v))); [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `exception_handler` [INFO] [stderr] --> src/interpreter/mod.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | ref exception_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_exception_handler` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `attributes` [INFO] [stderr] --> src/interpreter/mod.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | ref attributes, [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_attributes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bs` [INFO] [stderr] --> src/mem/mod.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let bs = std::mem::transmute::(*self); [INFO] [stderr] | ^^ help: consider using `_bs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bs` [INFO] [stderr] --> src/mem/mod.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let bs = std::mem::transmute::(*self); [INFO] [stderr] | ^^ help: consider using `_bs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `exception_handler` [INFO] [stderr] --> src/interpreter/mod.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | ref exception_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_exception_handler` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `attributes` [INFO] [stderr] --> src/interpreter/mod.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | ref attributes, [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_attributes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bs` [INFO] [stderr] --> src/mem/mod.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let bs = std::mem::transmute::(*self); [INFO] [stderr] | ^^ help: consider using `_bs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bs` [INFO] [stderr] --> src/mem/mod.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let bs = std::mem::transmute::(*self); [INFO] [stderr] | ^^ help: consider using `_bs` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `access_flag` [INFO] [stderr] --> src/bytecode/class.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | access_flag: U2, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `STATIC` [INFO] [stderr] --> src/bytecode/field.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const STATIC: u16 = 0x0008; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `init_value` [INFO] [stderr] --> src/bytecode/field.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn init_value(access_flag: u16, descriptor: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `class` [INFO] [stderr] --> src/interpreter/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | class: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `method` [INFO] [stderr] --> src/interpreter/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | method: String, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `line` [INFO] [stderr] --> src/interpreter/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | line: isize, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `head` [INFO] [stderr] --> src/mem/mod.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | head: Word, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `klass` [INFO] [stderr] --> src/mem/mod.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | klass: std::sync::Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `array_info` [INFO] [stderr] --> src/mem/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | array_info: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `handle` [INFO] [stderr] --> src/mem/mod.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | handle: Word, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `payload` [INFO] [stderr] --> src/mem/mod.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | payload: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `padding` [INFO] [stderr] --> src/mem/mod.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | fn padding(&mut self) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `access_flag` [INFO] [stderr] --> src/bytecode/class.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | access_flag: U2, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `STATIC` [INFO] [stderr] --> src/bytecode/field.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const STATIC: u16 = 0x0008; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `init_value` [INFO] [stderr] --> src/bytecode/field.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn init_value(access_flag: u16, descriptor: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `class` [INFO] [stderr] --> src/interpreter/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | class: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `method` [INFO] [stderr] --> src/interpreter/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | method: String, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `line` [INFO] [stderr] --> src/interpreter/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | line: isize, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `head` [INFO] [stderr] --> src/mem/mod.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | head: Word, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `klass` [INFO] [stderr] --> src/mem/mod.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | klass: std::sync::Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `array_info` [INFO] [stderr] --> src/mem/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | array_info: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `handle` [INFO] [stderr] --> src/mem/mod.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | handle: Word, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `payload` [INFO] [stderr] --> src/mem/mod.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | payload: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | / match item { [INFO] [stderr] 31 | | &ConstantItem::Integer(i) => { [INFO] [stderr] 32 | | return i; [INFO] [stderr] 33 | | } [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *item { [INFO] [stderr] 31 | ConstantItem::Integer(i) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `padding` [INFO] [stderr] --> src/mem/mod.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | fn padding(&mut self) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match item { [INFO] [stderr] 45 | | &ConstantItem::Float(f) => { [INFO] [stderr] 46 | | return f; [INFO] [stderr] 47 | | } [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *item { [INFO] [stderr] 45 | ConstantItem::Float(f) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / match item { [INFO] [stderr] 59 | | &ConstantItem::Long(l) => { [INFO] [stderr] 60 | | return l; [INFO] [stderr] 61 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | match *item { [INFO] [stderr] 59 | ConstantItem::Long(l) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | / match item { [INFO] [stderr] 73 | | &ConstantItem::Double(d) => { [INFO] [stderr] 74 | | return d; [INFO] [stderr] 75 | | } [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *item { [INFO] [stderr] 73 | ConstantItem::Double(d) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match item { [INFO] [stderr] 87 | | &ConstantItem::NameAndType(n_idx, t_idx) => { [INFO] [stderr] 88 | | return (&self.get_str(n_idx), &self.get_str(t_idx)); [INFO] [stderr] 89 | | } [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *item { [INFO] [stderr] 87 | ConstantItem::NameAndType(n_idx, t_idx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match item { [INFO] [stderr] 101 | | &ConstantItem::InterfaceMethodRef(c_idx, nt_idx) => { [INFO] [stderr] 102 | | return (&self.get_str(c_idx), self.get_name_and_type(nt_idx)); [INFO] [stderr] 103 | | } [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | match *item { [INFO] [stderr] 101 | ConstantItem::InterfaceMethodRef(c_idx, nt_idx) => { [INFO] [stderr] 102 | return (&self.get_str(c_idx), self.get_name_and_type(nt_idx)); [INFO] [stderr] 103 | } [INFO] [stderr] 104 | ConstantItem::FieldRef(c_idx, f_idx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match item { [INFO] [stderr] 118 | | &ConstantItem::String(offset) => { [INFO] [stderr] 119 | | return self.get_str(offset); [INFO] [stderr] 120 | | } [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | match *item { [INFO] [stderr] 118 | ConstantItem::String(offset) => { [INFO] [stderr] 119 | return self.get_str(offset); [INFO] [stderr] 120 | } [INFO] [stderr] 121 | ConstantItem::UTF8(ref s) => { [INFO] [stderr] 122 | return s; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bytecode/constant_pool.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | offset = offset + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/bytecode/constant_pool.rs:203:43 [INFO] [stderr] | [INFO] [stderr] 203 | let i: f32 = unsafe { mem::transmute::(v) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bytecode/constant_pool.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | offset = offset + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/bytecode/constant_pool.rs:215:43 [INFO] [stderr] | [INFO] [stderr] 215 | let i: f64 = unsafe { mem::transmute::(v) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bytecode/constant_pool.rs:216:21 [INFO] [stderr] | [INFO] [stderr] 216 | offset = offset + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/method.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / if let &Attribute::Code(_, _, _, _, _) = attr { [INFO] [stderr] 37 | | return Some(attr); [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | if let Attribute::Code(_, _, _, _, _) = *attr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | / match item { [INFO] [stderr] 31 | | &ConstantItem::Integer(i) => { [INFO] [stderr] 32 | | return i; [INFO] [stderr] 33 | | } [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &ClassEntry::Dir(ref dir) => { [INFO] [stderr] | [INFO] [stderr] 19 | | let mut abs_path = std::path::PathBuf::from(&dir); [INFO] [stderr] 20 | | abs_path.push(class_file); [INFO] [stderr] 30 | match *item { [INFO] [stderr] ... | [INFO] [stderr] 31 | ConstantItem::Integer(i) => { [INFO] [stderr] 45 | | } [INFO] [stderr] | [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | ClassEntry::Dir(ref dir) => { [INFO] [stderr] 19 | let mut abs_path = std::path::PathBuf::from(&dir); [INFO] [stderr] 20 | abs_path.push(class_file); [INFO] [stderr] 21 | if abs_path.exists() && abs_path.is_file() { [INFO] [stderr] 22 | let mut f = File::open(abs_path).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match item { [INFO] [stderr] 45 | | &ConstantItem::Float(f) => { [INFO] [stderr] 46 | | return f; [INFO] [stderr] 47 | | } [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *item { [INFO] [stderr] 45 | ConstantItem::Float(f) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / match item { [INFO] [stderr] 59 | | &ConstantItem::Long(l) => { [INFO] [stderr] 60 | | return l; [INFO] [stderr] 61 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | / match entry { [INFO] [stderr] 80 | | &ClassEntry::Dir(ref dir) => match std::fs::read_dir(dir) { [INFO] [stderr] 81 | | Err(_) => panic!("bootstrap classpath read error."), [INFO] [stderr] 82 | | Ok(paths) => { [INFO] [stderr] ... | [INFO] [stderr] 93 | | &ClassEntry::Jar(_) => {} [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | match *entry { [INFO] [stderr] 80 | ClassEntry::Dir(ref dir) => match std::fs::read_dir(dir) { [INFO] [stderr] 81 | Err(_) => panic!("bootstrap classpath read error."), [INFO] [stderr] 82 | Ok(paths) => { [INFO] [stderr] 83 | let f = paths [INFO] [stderr] 84 | .map(|f| f.unwrap().path()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/classpath/mod.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | Err(_) => panic!("bootstrap classpath read error."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/classpath/mod.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | fn find_class(entries: &Vec, class_name: &str) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[ClassEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 58 | match *item { [INFO] [stderr] 59 | ConstantItem::Long(l) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/classpath/mod.rs:100:41 [INFO] [stderr] | [INFO] [stderr] 100 | let mut class_file = Regex::new(r"\.") [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | / match item { [INFO] [stderr] 73 | | &ConstantItem::Double(d) => { [INFO] [stderr] 74 | | return d; [INFO] [stderr] 75 | | } [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *item { [INFO] [stderr] 73 | ConstantItem::Double(d) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match item { [INFO] [stderr] 87 | | &ConstantItem::NameAndType(n_idx, t_idx) => { [INFO] [stderr] 88 | | return (&self.get_str(n_idx), &self.get_str(t_idx)); [INFO] [stderr] 89 | | } [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *item { [INFO] [stderr] 87 | ConstantItem::NameAndType(n_idx, t_idx) => { [INFO] [stderr] | [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / match e { [INFO] [stderr] 120 | | &ClassEntry::Jar(ref s) => { [INFO] [stderr] 121 | | cp = cp + ":" + s; [INFO] [stderr] 122 | | } [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *e { [INFO] [stderr] 120 | ClassEntry::Jar(ref s) => { [INFO] [stderr] 121 | cp = cp + ":" + s; [INFO] [stderr] 122 | } [INFO] [stderr] 123 | ClassEntry::Dir(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / match e { [INFO] [stderr] 130 | | &ClassEntry::Jar(ref s) => { [INFO] [stderr] 131 | | cp = cp + ":" + s; [INFO] [stderr] 132 | | } [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 129 | match *e { [INFO] [stderr] 130 | ClassEntry::Jar(ref s) => { [INFO] [stderr] 131 | cp = cp + ":" + s; [INFO] [stderr] 132 | } [INFO] [stderr] 133 | ClassEntry::Dir(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | / match e { [INFO] [stderr] 140 | | &ClassEntry::Jar(ref s) => { [INFO] [stderr] 141 | | cp = cp + ":" + s; [INFO] [stderr] 142 | | } [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 139 | match *e { [INFO] [stderr] 140 | ClassEntry::Jar(ref s) => { [INFO] [stderr] 141 | cp = cp + ":" + s; [INFO] [stderr] 142 | } [INFO] [stderr] 143 | ClassEntry::Dir(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match item { [INFO] [stderr] 101 | | &ConstantItem::InterfaceMethodRef(c_idx, nt_idx) => { [INFO] [stderr] 102 | | return (&self.get_str(c_idx), self.get_name_and_type(nt_idx)); [INFO] [stderr] 103 | | } [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | match *item { [INFO] [stderr] 101 | ConstantItem::InterfaceMethodRef(c_idx, nt_idx) => { [INFO] [stderr] 102 | return (&self.get_str(c_idx), self.get_name_and_type(nt_idx)); [INFO] [stderr] 103 | } [INFO] [stderr] 104 | ConstantItem::FieldRef(c_idx, f_idx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/constant_pool.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match item { [INFO] [stderr] 118 | | &ConstantItem::String(offset) => { [INFO] [stderr] 119 | | return self.get_str(offset); [INFO] [stderr] 120 | | } [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/interpreter/mod.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | if let Ok(_) = k.mutex.try_lock() { [INFO] [stderr] | _____________________- ^^^^^ [INFO] [stderr] 73 | | k.initialized.store(true, Ordering::Relaxed); [INFO] [stderr] 74 | | if let Some(ref clinit) = k.bytecode.get_method("", "()V") { [INFO] [stderr] 75 | | if let Err(mut e) = self.call(&k, clinit, vec![]) { [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________________- help: try this: `if k.mutex.try_lock().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | match *item { [INFO] [stderr] 118 | ConstantItem::String(offset) => { [INFO] [stderr] 119 | return self.get_str(offset); [INFO] [stderr] 120 | } [INFO] [stderr] 121 | ConstantItem::UTF8(ref s) => { [INFO] [stderr] 122 | return s; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bytecode/constant_pool.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | offset = offset + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/bytecode/constant_pool.rs:203:43 [INFO] [stderr] | [INFO] [stderr] 203 | let i: f32 = unsafe { mem::transmute::(v) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bytecode/constant_pool.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | offset = offset + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/bytecode/constant_pool.rs:215:43 [INFO] [stderr] | [INFO] [stderr] 215 | let i: f64 = unsafe { mem::transmute::(v) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bytecode/constant_pool.rs:216:21 [INFO] [stderr] | [INFO] [stderr] 216 | offset = offset + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:143:29 [INFO] [stderr] | [INFO] [stderr] 143 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:147:29 [INFO] [stderr] | [INFO] [stderr] 147 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:151:29 [INFO] [stderr] | [INFO] [stderr] 151 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:155:29 [INFO] [stderr] | [INFO] [stderr] 155 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:171:29 [INFO] [stderr] | [INFO] [stderr] 171 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:177:29 [INFO] [stderr] | [INFO] [stderr] 177 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:182:29 [INFO] [stderr] | [INFO] [stderr] 182 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:190:29 [INFO] [stderr] | [INFO] [stderr] 190 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:207:43 [INFO] [stderr] | [INFO] [stderr] 207 | operands.push((code[(pc + 1) as usize] as i32).memorized()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:208:29 [INFO] [stderr] | [INFO] [stderr] 208 | pc = pc + 2; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:213:34 [INFO] [stderr] | [INFO] [stderr] 213 | ((code[(pc + 1) as usize] as i32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:214:39 [INFO] [stderr] | [INFO] [stderr] 214 | | (code[(pc + 2) as usize] as i32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:217:29 [INFO] [stderr] | [INFO] [stderr] 217 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:222:29 [INFO] [stderr] | [INFO] [stderr] 222 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:226:29 [INFO] [stderr] | [INFO] [stderr] 226 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:230:29 [INFO] [stderr] | [INFO] [stderr] 230 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:240:33 [INFO] [stderr] | [INFO] [stderr] 240 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:248:33 [INFO] [stderr] | [INFO] [stderr] 248 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:256:33 [INFO] [stderr] | [INFO] [stderr] 256 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:264:33 [INFO] [stderr] | [INFO] [stderr] 264 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:278:37 [INFO] [stderr] | [INFO] [stderr] 278 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:287:39 [INFO] [stderr] | [INFO] [stderr] 287 | let cst = code[(pc + 2) as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:290:29 [INFO] [stderr] | [INFO] [stderr] 290 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:298:38 [INFO] [stderr] | [INFO] [stderr] 298 | pc = (code[(pc + 1) as usize] as U4) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:299:39 [INFO] [stderr] | [INFO] [stderr] 299 | | code[(pc + 2) as usize] as U4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:301:33 [INFO] [stderr] | [INFO] [stderr] 301 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:306:34 [INFO] [stderr] | [INFO] [stderr] 306 | pc = (code[(pc + 1) as usize] as U4) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:307:35 [INFO] [stderr] | [INFO] [stderr] 307 | | code[(pc + 2) as usize] as U4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:314:45 [INFO] [stderr] | [INFO] [stderr] 314 | let field_idx = (code[(pc + 1) as usize] as U2) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:315:35 [INFO] [stderr] | [INFO] [stderr] 315 | | code[(pc + 2) as usize] as U2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:339:29 [INFO] [stderr] | [INFO] [stderr] 339 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:343:45 [INFO] [stderr] | [INFO] [stderr] 343 | let field_idx = (code[(pc + 1) as usize] as U2) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:344:35 [INFO] [stderr] | [INFO] [stderr] 344 | | code[(pc + 2) as usize] as U2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/interpreter/mod.rs:353:45 [INFO] [stderr] | [INFO] [stderr] 353 | &field.value.set(Some(Value::DWord(lower, higher))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field.value.set(Some(Value::DWord(lower, higher)));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/interpreter/mod.rs:358:41 [INFO] [stderr] | [INFO] [stderr] 358 | &field.value.set(Some(Value::Word(v))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field.value.set(Some(Value::Word(v)));` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:365:29 [INFO] [stderr] | [INFO] [stderr] 365 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/mem/metaspace.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | let class_name = Regex::new(r"\.") [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bytecode/method.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / if let &Attribute::Code(_, _, _, _, _) = attr { [INFO] [stderr] 37 | | return Some(attr); [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | if let Attribute::Code(_, _, _, _, _) = *attr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &ClassEntry::Dir(ref dir) => { [INFO] [stderr] 19 | | let mut abs_path = std::path::PathBuf::from(&dir); [INFO] [stderr] 20 | | abs_path.push(class_file); [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | ClassEntry::Dir(ref dir) => { [INFO] [stderr] 19 | let mut abs_path = std::path::PathBuf::from(&dir); [INFO] [stderr] 20 | abs_path.push(class_file); [INFO] [stderr] 21 | if abs_path.exists() && abs_path.is_file() { [INFO] [stderr] 22 | let mut f = File::open(abs_path).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | / match entry { [INFO] [stderr] 80 | | &ClassEntry::Dir(ref dir) => match std::fs::read_dir(dir) { [INFO] [stderr] 81 | | Err(_) => panic!("bootstrap classpath read error."), [INFO] [stderr] 82 | | Ok(paths) => { [INFO] [stderr] ... | [INFO] [stderr] 93 | | &ClassEntry::Jar(_) => {} [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | match *entry { [INFO] [stderr] 80 | ClassEntry::Dir(ref dir) => match std::fs::read_dir(dir) { [INFO] [stderr] 81 | Err(_) => panic!("bootstrap classpath read error."), [INFO] [stderr] 82 | Ok(paths) => { [INFO] [stderr] 83 | let f = paths [INFO] [stderr] 84 | .map(|f| f.unwrap().path()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/classpath/mod.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | Err(_) => panic!("bootstrap classpath read error."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/classpath/mod.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | fn find_class(entries: &Vec, class_name: &str) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[ClassEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/classpath/mod.rs:100:41 [INFO] [stderr] | [INFO] [stderr] 100 | let mut class_file = Regex::new(r"\.") [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / match e { [INFO] [stderr] 120 | | &ClassEntry::Jar(ref s) => { [INFO] [stderr] 121 | | cp = cp + ":" + s; [INFO] [stderr] 122 | | } [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *e { [INFO] [stderr] 120 | ClassEntry::Jar(ref s) => { [INFO] [stderr] 121 | cp = cp + ":" + s; [INFO] [stderr] 122 | } [INFO] [stderr] 123 | ClassEntry::Dir(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / match e { [INFO] [stderr] 130 | | &ClassEntry::Jar(ref s) => { [INFO] [stderr] 131 | | cp = cp + ":" + s; [INFO] [stderr] 132 | | } [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 129 | match *e { [INFO] [stderr] 130 | ClassEntry::Jar(ref s) => { [INFO] [stderr] 131 | cp = cp + ":" + s; [INFO] [stderr] 132 | } [INFO] [stderr] 133 | ClassEntry::Dir(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/classpath/mod.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | / match e { [INFO] [stderr] 140 | | &ClassEntry::Jar(ref s) => { [INFO] [stderr] 141 | | cp = cp + ":" + s; [INFO] [stderr] 142 | | } [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 139 | match *e { [INFO] [stderr] 140 | ClassEntry::Jar(ref s) => { [INFO] [stderr] 141 | cp = cp + ":" + s; [INFO] [stderr] 142 | } [INFO] [stderr] 143 | ClassEntry::Dir(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/interpreter/mod.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | if let Ok(_) = k.mutex.try_lock() { [INFO] [stderr] | _____________________- ^^^^^ [INFO] [stderr] 73 | | k.initialized.store(true, Ordering::Relaxed); [INFO] [stderr] 74 | | if let Some(ref clinit) = k.bytecode.get_method("", "()V") { [INFO] [stderr] 75 | | if let Err(mut e) = self.call(&k, clinit, vec![]) { [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________________- help: try this: `if k.mutex.try_lock().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:143:29 [INFO] [stderr] | [INFO] [stderr] 143 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:147:29 [INFO] [stderr] | [INFO] [stderr] 147 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:151:29 [INFO] [stderr] | [INFO] [stderr] 151 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:155:29 [INFO] [stderr] | [INFO] [stderr] 155 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:171:29 [INFO] [stderr] | [INFO] [stderr] 171 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:177:29 [INFO] [stderr] | [INFO] [stderr] 177 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:182:29 [INFO] [stderr] | [INFO] [stderr] 182 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:190:29 [INFO] [stderr] | [INFO] [stderr] 190 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:207:43 [INFO] [stderr] | [INFO] [stderr] 207 | operands.push((code[(pc + 1) as usize] as i32).memorized()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:208:29 [INFO] [stderr] | [INFO] [stderr] 208 | pc = pc + 2; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:213:34 [INFO] [stderr] | [INFO] [stderr] 213 | ((code[(pc + 1) as usize] as i32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:214:39 [INFO] [stderr] | [INFO] [stderr] 214 | | (code[(pc + 2) as usize] as i32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:217:29 [INFO] [stderr] | [INFO] [stderr] 217 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:222:29 [INFO] [stderr] | [INFO] [stderr] 222 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:226:29 [INFO] [stderr] | [INFO] [stderr] 226 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:230:29 [INFO] [stderr] | [INFO] [stderr] 230 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:240:33 [INFO] [stderr] | [INFO] [stderr] 240 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:248:33 [INFO] [stderr] | [INFO] [stderr] 248 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:256:33 [INFO] [stderr] | [INFO] [stderr] 256 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:264:33 [INFO] [stderr] | [INFO] [stderr] 264 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:278:37 [INFO] [stderr] | [INFO] [stderr] 278 | pc = pc + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:287:39 [INFO] [stderr] | [INFO] [stderr] 287 | let cst = code[(pc + 2) as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:290:29 [INFO] [stderr] | [INFO] [stderr] 290 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:298:38 [INFO] [stderr] | [INFO] [stderr] 298 | pc = (code[(pc + 1) as usize] as U4) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:299:39 [INFO] [stderr] | [INFO] [stderr] 299 | | code[(pc + 2) as usize] as U4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:301:33 [INFO] [stderr] | [INFO] [stderr] 301 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:306:34 [INFO] [stderr] | [INFO] [stderr] 306 | pc = (code[(pc + 1) as usize] as U4) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:307:35 [INFO] [stderr] | [INFO] [stderr] 307 | | code[(pc + 2) as usize] as U4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:314:45 [INFO] [stderr] | [INFO] [stderr] 314 | let field_idx = (code[(pc + 1) as usize] as U2) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:315:35 [INFO] [stderr] | [INFO] [stderr] 315 | | code[(pc + 2) as usize] as U2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:339:29 [INFO] [stderr] | [INFO] [stderr] 339 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:343:45 [INFO] [stderr] | [INFO] [stderr] 343 | let field_idx = (code[(pc + 1) as usize] as U2) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(code[(pc + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/mod.rs:344:35 [INFO] [stderr] | [INFO] [stderr] 344 | | code[(pc + 2) as usize] as U2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(code[(pc + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/interpreter/mod.rs:353:45 [INFO] [stderr] | [INFO] [stderr] 353 | &field.value.set(Some(Value::DWord(lower, higher))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field.value.set(Some(Value::DWord(lower, higher)));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/interpreter/mod.rs:358:41 [INFO] [stderr] | [INFO] [stderr] 358 | &field.value.set(Some(Value::Word(v))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field.value.set(Some(Value::Word(v)));` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:365:29 [INFO] [stderr] | [INFO] [stderr] 365 | pc = pc + 3; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pc += 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/mem/metaspace.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | let class_name = Regex::new(r"\.") [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / return user_classpath [INFO] [stderr] 63 | | .split(":") [INFO] [stderr] 64 | | .map(|p| p.to_string()) [INFO] [stderr] 65 | | .collect::>(); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | user_classpath [INFO] [stderr] 63 | .split(":") [INFO] [stderr] 64 | .map(|p| p.to_string()) [INFO] [stderr] 65 | .collect::>() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | .split(":") [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / interpreter.execute( [INFO] [stderr] 79 | | class_name, [INFO] [stderr] 80 | | "main", [INFO] [stderr] 81 | | "([Ljava/lang/String;)V", [INFO] [stderr] 82 | | vec![mem::NULL], [INFO] [stderr] 83 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / return user_classpath [INFO] [stderr] 63 | | .split(":") [INFO] [stderr] 64 | | .map(|p| p.to_string()) [INFO] [stderr] 65 | | .collect::>(); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | user_classpath [INFO] [stderr] 63 | .split(":") [INFO] [stderr] 64 | .map(|p| p.to_string()) [INFO] [stderr] 65 | .collect::>() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | .split(":") [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / interpreter.execute( [INFO] [stderr] 79 | | class_name, [INFO] [stderr] 80 | | "main", [INFO] [stderr] 81 | | "([Ljava/lang/String;)V", [INFO] [stderr] 82 | | vec![mem::NULL], [INFO] [stderr] 83 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.49s [INFO] running `"docker" "inspect" "8b9aed227e6fea7bbb47bc014127c69f5dc5238d939fcdfc34127a4a76d85464"` [INFO] running `"docker" "rm" "-f" "8b9aed227e6fea7bbb47bc014127c69f5dc5238d939fcdfc34127a4a76d85464"` [INFO] [stdout] 8b9aed227e6fea7bbb47bc014127c69f5dc5238d939fcdfc34127a4a76d85464