[INFO] updating cached repository ar1a/woboo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ar1a/woboo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ar1a/woboo" "work/ex/clippy-test-run/sources/stable/gh/ar1a/woboo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ar1a/woboo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ar1a/woboo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ar1a/woboo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ar1a/woboo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a72d52265ae7742fa628d2fc8c6448b110cb441f [INFO] sha for GitHub repo ar1a/woboo: a72d52265ae7742fa628d2fc8c6448b110cb441f [INFO] validating manifest of ar1a/woboo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ar1a/woboo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ar1a/woboo [INFO] finished frobbing ar1a/woboo [INFO] frobbed toml for ar1a/woboo written to work/ex/clippy-test-run/sources/stable/gh/ar1a/woboo/Cargo.toml [INFO] started frobbing ar1a/woboo [INFO] finished frobbing ar1a/woboo [INFO] frobbed toml for ar1a/woboo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ar1a/woboo/Cargo.toml [INFO] crate ar1a/woboo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ar1a/woboo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ar1a/woboo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5fdf5cb4551ddda4bcc8194275dfc175a6a07d7b061d39f49b27f67d034c084 [INFO] running `"docker" "start" "-a" "a5fdf5cb4551ddda4bcc8194275dfc175a6a07d7b061d39f49b27f67d034c084"` [INFO] [stderr] Checking regex v1.0.1 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking clap-verbosity-flag v0.1.0 [INFO] [stderr] Checking quicli v0.3.0 [INFO] [stderr] Checking woboo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same prefix: `Op` [INFO] [stderr] --> src/main.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | / enum Instruction { [INFO] [stderr] 60 | | OpVinc { quantity: usize }, // + [INFO] [stderr] 61 | | OpVdec { quantity: usize }, // - [INFO] [stderr] 62 | | OpPinc { quantity: usize }, // > [INFO] [stderr] ... | [INFO] [stderr] 67 | | OpLend { destination: usize }, // ] [INFO] [stderr] 68 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | return execute(instructions, cells, next_cindex, next_iindex); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `execute(instructions, cells, next_cindex, next_iindex)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Op` [INFO] [stderr] --> src/main.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | / enum Instruction { [INFO] [stderr] 60 | | OpVinc { quantity: usize }, // + [INFO] [stderr] 61 | | OpVdec { quantity: usize }, // - [INFO] [stderr] 62 | | OpPinc { quantity: usize }, // > [INFO] [stderr] ... | [INFO] [stderr] 67 | | OpLend { destination: usize }, // ] [INFO] [stderr] 68 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | return execute(instructions, cells, next_cindex, next_iindex); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `execute(instructions, cells, next_cindex, next_iindex)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `OpIn` [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | OpIn { quantity: usize }, // , FIXME: not implemented [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: calling `mem::discriminant` on non-enum type `T` [INFO] [stderr] --> src/main.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | std::mem::discriminant(a) == std::mem::discriminant(b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mem_discriminant_non_enum)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_discriminant_non_enum [INFO] [stderr] [INFO] [stderr] error: calling `mem::discriminant` on non-enum type `T` [INFO] [stderr] --> src/main.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | std::mem::discriminant(a) == std::mem::discriminant(b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_discriminant_non_enum [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:91:60 [INFO] [stderr] | [INFO] [stderr] 91 | fn preprocess(instructions: &mut Vec, buffer: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | instructions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `execute` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | execute(&mut instructions, &mut cells, 0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `woboo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variant is never constructed: `OpIn` [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | OpIn { quantity: usize }, // , FIXME: not implemented [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: calling `mem::discriminant` on non-enum type `T` [INFO] [stderr] --> src/main.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | std::mem::discriminant(a) == std::mem::discriminant(b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mem_discriminant_non_enum)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_discriminant_non_enum [INFO] [stderr] [INFO] [stderr] error: calling `mem::discriminant` on non-enum type `T` [INFO] [stderr] --> src/main.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | std::mem::discriminant(a) == std::mem::discriminant(b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_discriminant_non_enum [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:91:60 [INFO] [stderr] | [INFO] [stderr] 91 | fn preprocess(instructions: &mut Vec, buffer: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | if stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | instructions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `execute` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | execute(&mut instructions, &mut cells, 0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `woboo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a5fdf5cb4551ddda4bcc8194275dfc175a6a07d7b061d39f49b27f67d034c084"` [INFO] running `"docker" "rm" "-f" "a5fdf5cb4551ddda4bcc8194275dfc175a6a07d7b061d39f49b27f67d034c084"` [INFO] [stdout] a5fdf5cb4551ddda4bcc8194275dfc175a6a07d7b061d39f49b27f67d034c084