[INFO] updating cached repository aphreet/rpm_srv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aphreet/rpm_srv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aphreet/rpm_srv" "work/ex/clippy-test-run/sources/stable/gh/aphreet/rpm_srv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aphreet/rpm_srv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aphreet/rpm_srv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aphreet/rpm_srv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aphreet/rpm_srv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 88f051c5e2db21285d54568340302c560983dae1 [INFO] sha for GitHub repo aphreet/rpm_srv: 88f051c5e2db21285d54568340302c560983dae1 [INFO] validating manifest of aphreet/rpm_srv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aphreet/rpm_srv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aphreet/rpm_srv [INFO] finished frobbing aphreet/rpm_srv [INFO] frobbed toml for aphreet/rpm_srv written to work/ex/clippy-test-run/sources/stable/gh/aphreet/rpm_srv/Cargo.toml [INFO] started frobbing aphreet/rpm_srv [INFO] finished frobbing aphreet/rpm_srv [INFO] frobbed toml for aphreet/rpm_srv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aphreet/rpm_srv/Cargo.toml [INFO] crate aphreet/rpm_srv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aphreet/rpm_srv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aphreet/rpm_srv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01fa9f224c770b6aca340c66f72cce5839742e46f927275f7ac867bbcfd02991 [INFO] running `"docker" "start" "-a" "01fa9f224c770b6aca340c66f72cce5839742e46f927275f7ac867bbcfd02991"` [INFO] [stderr] Checking rpm_srv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `cache_arg` [INFO] [stderr] --> src/main.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let cache_arg = cache_arg(&self.file_root); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_cache_arg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | fn ensure_repo_exists(&self, root: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | fn repo_path(&self, root: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:56:31 [INFO] [stderr] | [INFO] [stderr] 56 | fn file_path(&self, root: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | fn cache_arg(root: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cache_arg` [INFO] [stderr] --> src/main.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let cache_arg = cache_arg(&self.file_root); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_cache_arg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | fn ensure_repo_exists(&self, root: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | fn repo_path(&self, root: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:56:31 [INFO] [stderr] | [INFO] [stderr] 56 | fn file_path(&self, root: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | fn cache_arg(root: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.37s [INFO] running `"docker" "inspect" "01fa9f224c770b6aca340c66f72cce5839742e46f927275f7ac867bbcfd02991"` [INFO] running `"docker" "rm" "-f" "01fa9f224c770b6aca340c66f72cce5839742e46f927275f7ac867bbcfd02991"` [INFO] [stdout] 01fa9f224c770b6aca340c66f72cce5839742e46f927275f7ac867bbcfd02991