[INFO] updating cached repository aoikonomopoulos/subdiff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aoikonomopoulos/subdiff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aoikonomopoulos/subdiff" "work/ex/clippy-test-run/sources/stable/gh/aoikonomopoulos/subdiff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aoikonomopoulos/subdiff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aoikonomopoulos/subdiff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aoikonomopoulos/subdiff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aoikonomopoulos/subdiff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9793cb6ac6dd0afb94b3fdc14a7eab73f7dcd2d4 [INFO] sha for GitHub repo aoikonomopoulos/subdiff: 9793cb6ac6dd0afb94b3fdc14a7eab73f7dcd2d4 [INFO] validating manifest of aoikonomopoulos/subdiff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aoikonomopoulos/subdiff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aoikonomopoulos/subdiff [INFO] finished frobbing aoikonomopoulos/subdiff [INFO] frobbed toml for aoikonomopoulos/subdiff written to work/ex/clippy-test-run/sources/stable/gh/aoikonomopoulos/subdiff/Cargo.toml [INFO] started frobbing aoikonomopoulos/subdiff [INFO] finished frobbing aoikonomopoulos/subdiff [INFO] frobbed toml for aoikonomopoulos/subdiff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aoikonomopoulos/subdiff/Cargo.toml [INFO] crate aoikonomopoulos/subdiff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aoikonomopoulos/subdiff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aoikonomopoulos/subdiff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 646e209e799085c956b214b26364c85ee7a2815234987c9df6c411ff178de7b9 [INFO] running `"docker" "start" "-a" "646e209e799085c956b214b26364c85ee7a2815234987c9df6c411ff178de7b9"` [INFO] [stderr] Checking random v0.12.2 [INFO] [stderr] Checking lcs-diff v0.1.1 [INFO] [stderr] Checking temporary v0.6.3 [INFO] [stderr] Checking subdiff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/wdiff.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | #[cfg_attr(feature = "cargo-clippy", allow(enum_variant_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/wdiff.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | #[cfg_attr(feature = "cargo-clippy", allow(enum_variant_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/wdiff.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | #[cfg_attr(feature = "cargo-clippy", allow(enum_variant_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/wdiff.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | #[cfg_attr(feature = "cargo-clippy", allow(enum_variant_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] [INFO] [stderr] warning: trait `HasCharacterClass` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/wdiff.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / pub trait HasCharacterClass { [INFO] [stderr] 92 | | type Item : Clone + PartialEq; [INFO] [stderr] 93 | | fn cc(&self) -> CharacterClass; [INFO] [stderr] 94 | | fn len(&self) -> usize; [INFO] [stderr] 95 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/wdiff.rs:457:12 [INFO] [stderr] | [INFO] [stderr] 457 | if words.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: trait `HasCharacterClass` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/wdiff.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / pub trait HasCharacterClass { [INFO] [stderr] 92 | | type Item : Clone + PartialEq; [INFO] [stderr] 93 | | fn cc(&self) -> CharacterClass; [INFO] [stderr] 94 | | fn len(&self) -> usize; [INFO] [stderr] 95 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/wdiff.rs:457:12 [INFO] [stderr] | [INFO] [stderr] 457 | if words.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tests.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | io::stderr().write(&our_output).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tests.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | io::stderr().write(&expected).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tests.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | out.write(s1.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tests.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | io::stderr().write(b"Got: `").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tests.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | io::stderr().write(&out).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `subdiff`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "646e209e799085c956b214b26364c85ee7a2815234987c9df6c411ff178de7b9"` [INFO] running `"docker" "rm" "-f" "646e209e799085c956b214b26364c85ee7a2815234987c9df6c411ff178de7b9"` [INFO] [stdout] 646e209e799085c956b214b26364c85ee7a2815234987c9df6c411ff178de7b9