[INFO] updating cached repository anykao/ytdl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/anykao/ytdl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/anykao/ytdl" "work/ex/clippy-test-run/sources/stable/gh/anykao/ytdl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anykao/ytdl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/anykao/ytdl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anykao/ytdl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anykao/ytdl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a05404b80042c7e59f76670a321237ca39efb39 [INFO] sha for GitHub repo anykao/ytdl: 7a05404b80042c7e59f76670a321237ca39efb39 [INFO] validating manifest of anykao/ytdl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anykao/ytdl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anykao/ytdl [INFO] finished frobbing anykao/ytdl [INFO] frobbed toml for anykao/ytdl written to work/ex/clippy-test-run/sources/stable/gh/anykao/ytdl/Cargo.toml [INFO] started frobbing anykao/ytdl [INFO] finished frobbing anykao/ytdl [INFO] frobbed toml for anykao/ytdl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anykao/ytdl/Cargo.toml [INFO] crate anykao/ytdl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anykao/ytdl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anykao/ytdl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9aabfeb7db5e10ae6ddaed44d263d6322536b0a34b3dc1beefb2fa08b378e3fe [INFO] running `"docker" "start" "-a" "9aabfeb7db5e10ae6ddaed44d263d6322536b0a34b3dc1beefb2fa08b378e3fe"` [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking ytdl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/downloader.rs:74:34 [INFO] [stderr] | [INFO] [stderr] 74 | println!("{}: {:?}", "failed to execute process", e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/downloader.rs:74:34 [INFO] [stderr] | [INFO] [stderr] 74 | println!("{}: {:?}", "failed to execute process", e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/youtube.rs:64:20 [INFO] [stderr] | [INFO] [stderr] 64 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 65 | | if !audio_url.is_empty() && !video_url.is_empty() { [INFO] [stderr] 66 | | return VideoUrl::Dash { [INFO] [stderr] 67 | | video_url, [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | } else if !audio_url.is_empty() && !video_url.is_empty() { [INFO] [stderr] 65 | return VideoUrl::Dash { [INFO] [stderr] 66 | video_url, [INFO] [stderr] 67 | audio_url, [INFO] [stderr] 68 | filename: format!("{}_{}", good_title, vid), [INFO] [stderr] 69 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return youtube::parse(id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `youtube::parse(id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | return douyin::parse(url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `douyin::parse(url)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return Ok(mapping); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(mapping)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/youtube.rs:64:20 [INFO] [stderr] | [INFO] [stderr] 64 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 65 | | if !audio_url.is_empty() && !video_url.is_empty() { [INFO] [stderr] 66 | | return VideoUrl::Dash { [INFO] [stderr] 67 | | video_url, [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | } else if !audio_url.is_empty() && !video_url.is_empty() { [INFO] [stderr] 65 | return VideoUrl::Dash { [INFO] [stderr] 66 | video_url, [INFO] [stderr] 67 | audio_url, [INFO] [stderr] 68 | filename: format!("{}_{}", good_title, vid), [INFO] [stderr] 69 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return youtube::parse(id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `youtube::parse(id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | return douyin::parse(url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `douyin::parse(url)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return Ok(mapping); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(mapping)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `regex!(_)` found. Please use `Regex::new(_)`, which is faster for now. [INFO] [stderr] --> src/decipher.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / named!( [INFO] [stderr] 34 | | var<&str, Vec<&str>>, [INFO] [stderr] 35 | | re_capture_static!(r"(\w+)\.\w+\(\w+,\d+\)") [INFO] [stderr] 36 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::regex_macro)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_macro [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `regex!(_)` found. Please use `Regex::new(_)`, which is faster for now. [INFO] [stderr] --> src/douyin.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / named!( [INFO] [stderr] 8 | | parse_data<&str, Vec<&str>>, [INFO] [stderr] 9 | | re_capture_static!(r"var data = \[(.+)\]") [INFO] [stderr] 10 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_macro [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/youtube.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | let afmts = adaptive_fmts.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `regex!(_)` found. Please use `Regex::new(_)`, which is faster for now. [INFO] [stderr] --> src/decipher.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / named!( [INFO] [stderr] 34 | | var<&str, Vec<&str>>, [INFO] [stderr] 35 | | re_capture_static!(r"(\w+)\.\w+\(\w+,\d+\)") [INFO] [stderr] 36 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::regex_macro)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_macro [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `regex!(_)` found. Please use `Regex::new(_)`, which is faster for now. [INFO] [stderr] --> src/douyin.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / named!( [INFO] [stderr] 8 | | parse_data<&str, Vec<&str>>, [INFO] [stderr] 9 | | re_capture_static!(r"var data = \[(.+)\]") [INFO] [stderr] 10 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_macro [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/youtube.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | let afmts = adaptive_fmts.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.22s [INFO] running `"docker" "inspect" "9aabfeb7db5e10ae6ddaed44d263d6322536b0a34b3dc1beefb2fa08b378e3fe"` [INFO] running `"docker" "rm" "-f" "9aabfeb7db5e10ae6ddaed44d263d6322536b0a34b3dc1beefb2fa08b378e3fe"` [INFO] [stdout] 9aabfeb7db5e10ae6ddaed44d263d6322536b0a34b3dc1beefb2fa08b378e3fe