[INFO] updating cached repository anxiousmodernman/candypaint [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/anxiousmodernman/candypaint [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/anxiousmodernman/candypaint" "work/ex/clippy-test-run/sources/stable/gh/anxiousmodernman/candypaint"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anxiousmodernman/candypaint'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/anxiousmodernman/candypaint" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anxiousmodernman/candypaint"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anxiousmodernman/candypaint'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 470b1077cf55cda7510a3dd16ce375b11bfcb692 [INFO] sha for GitHub repo anxiousmodernman/candypaint: 470b1077cf55cda7510a3dd16ce375b11bfcb692 [INFO] validating manifest of anxiousmodernman/candypaint on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anxiousmodernman/candypaint on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anxiousmodernman/candypaint [INFO] finished frobbing anxiousmodernman/candypaint [INFO] frobbed toml for anxiousmodernman/candypaint written to work/ex/clippy-test-run/sources/stable/gh/anxiousmodernman/candypaint/Cargo.toml [INFO] started frobbing anxiousmodernman/candypaint [INFO] finished frobbing anxiousmodernman/candypaint [INFO] frobbed toml for anxiousmodernman/candypaint written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anxiousmodernman/candypaint/Cargo.toml [INFO] crate anxiousmodernman/candypaint has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anxiousmodernman/candypaint against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anxiousmodernman/candypaint:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8987b1b23e3481b7a0cc48c59c3738076ef0e4db6888817569469192b5d11b5 [INFO] running `"docker" "start" "-a" "e8987b1b23e3481b7a0cc48c59c3738076ef0e4db6888817569469192b5d11b5"` [INFO] [stderr] Checking candypaint v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | Some(GitInfo{ branch: branch }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `branch` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | Some(GitInfo{ branch: branch }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `branch` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:26:46 [INFO] [stderr] | [INFO] [stderr] 26 | println!("export CANDY = \"{}\"", prompt.unwrap_or(String::from("export CANDY = \"# ${c::reset}\""))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("export CANDY = \"# ${c::reset}\""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | let s = format!("{}", pwd.to_str().unwrap_or("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `pwd.to_str().unwrap_or("").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / let mut inc: bool; [INFO] [stderr] 86 | | if length > range.len() { [INFO] [stderr] 87 | | if i < (length - range.len()) { [INFO] [stderr] 88 | | continue [INFO] [stderr] ... | [INFO] [stderr] 92 | | inc = true; [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let inc = if length > range.len() { ..; true } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:26:46 [INFO] [stderr] | [INFO] [stderr] 26 | println!("export CANDY = \"{}\"", prompt.unwrap_or(String::from("export CANDY = \"# ${c::reset}\""))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("export CANDY = \"# ${c::reset}\""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | let s = format!("{}", pwd.to_str().unwrap_or("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `pwd.to_str().unwrap_or("").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / let mut inc: bool; [INFO] [stderr] 86 | | if length > range.len() { [INFO] [stderr] 87 | | if i < (length - range.len()) { [INFO] [stderr] 88 | | continue [INFO] [stderr] ... | [INFO] [stderr] 92 | | inc = true; [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let inc = if length > range.len() { ..; true } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.58s [INFO] running `"docker" "inspect" "e8987b1b23e3481b7a0cc48c59c3738076ef0e4db6888817569469192b5d11b5"` [INFO] running `"docker" "rm" "-f" "e8987b1b23e3481b7a0cc48c59c3738076ef0e4db6888817569469192b5d11b5"` [INFO] [stdout] e8987b1b23e3481b7a0cc48c59c3738076ef0e4db6888817569469192b5d11b5