[INFO] updating cached repository anurse/warthog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/anurse/warthog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/anurse/warthog" "work/ex/clippy-test-run/sources/stable/gh/anurse/warthog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anurse/warthog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/anurse/warthog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anurse/warthog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anurse/warthog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c7b6c2ad83616605e07a148aa7cb797d13232ed [INFO] sha for GitHub repo anurse/warthog: 9c7b6c2ad83616605e07a148aa7cb797d13232ed [INFO] validating manifest of anurse/warthog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anurse/warthog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anurse/warthog [INFO] finished frobbing anurse/warthog [INFO] frobbed toml for anurse/warthog written to work/ex/clippy-test-run/sources/stable/gh/anurse/warthog/Cargo.toml [INFO] started frobbing anurse/warthog [INFO] finished frobbing anurse/warthog [INFO] frobbed toml for anurse/warthog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anurse/warthog/Cargo.toml [INFO] crate anurse/warthog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anurse/warthog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anurse/warthog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dcffccf24496a1df0265205086b71f8cf3030bbb1e88c17006d4891fc1e83dcc [INFO] running `"docker" "start" "-a" "dcffccf24496a1df0265205086b71f8cf3030bbb1e88c17006d4891fc1e83dcc"` [INFO] [stderr] Checking leb128 v0.2.3 [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Compiling csv-core v0.1.4 [INFO] [stderr] Compiling csv v1.0.2 [INFO] [stderr] Compiling warthog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interp/exec/numops.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | x => return Err(format!("Instruction not implemented: {}", x).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Instruction not implemented: {}", x).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/module/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | mod module; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/mod.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | const EXPECTED_MAGIC: u32 = 0x6D736100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6D73_6100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interp/exec/numops.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | x => return Err(format!("Instruction not implemented: {}", x).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Instruction not implemented: {}", x).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/module/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | mod module; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/mod.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | const EXPECTED_MAGIC: u32 = 0x6D736100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6D73_6100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `memory::Memory` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/memory.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / impl Memory { [INFO] [stderr] 16 | | pub fn new(min_size: usize, max_size: Option) -> Result { [INFO] [stderr] 17 | | let layout = Layout::from_size_align(min_size, mem::align_of::())?; [INFO] [stderr] 18 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/memory.rs:36:34 [INFO] [stderr] | [INFO] [stderr] 36 | pub unsafe fn data(&self) -> &mut [u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/memory.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | pub unsafe fn data(&self) -> &mut [u8] { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sparse_vec::SparseVec` [INFO] [stderr] --> src/sparse_vec.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn new() -> SparseVec { [INFO] [stderr] 6 | | SparseVec(Vec::new()) [INFO] [stderr] 7 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/trap.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn message<'a>(&'a self) -> Cow<'a, str> { [INFO] [stderr] 18 | | use self::TrapCause::*; [INFO] [stderr] 19 | | [INFO] [stderr] 20 | | match self { [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | self.leading_zeros() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.leading_zeros())` [INFO] [stderr] ... [INFO] [stderr] 137 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | self.trailing_zeros() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.trailing_zeros())` [INFO] [stderr] ... [INFO] [stderr] 137 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | self.count_ones() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.count_ones())` [INFO] [stderr] ... [INFO] [stderr] 137 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | self.leading_zeros() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.leading_zeros())` [INFO] [stderr] ... [INFO] [stderr] 139 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | self.trailing_zeros() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.trailing_zeros())` [INFO] [stderr] ... [INFO] [stderr] 139 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | self.count_ones() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.count_ones())` [INFO] [stderr] ... [INFO] [stderr] 139 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.fract().abs() - 0.5).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:221:31 [INFO] [stderr] | [INFO] [stderr] 221 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - -1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:221:31 [INFO] [stderr] | [INFO] [stderr] 221 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.fract().abs() - 0.5).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:221:31 [INFO] [stderr] | [INFO] [stderr] 221 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - -1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:221:31 [INFO] [stderr] | [INFO] [stderr] 221 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 272 | impl_convert_by_cast!(u32, u64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 273 | impl_convert_by_cast!(i32, i64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 276 | impl_convert_by_cast!(u32, f64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 277 | impl_convert_by_cast!(i32, f64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 283 | impl_convert_by_cast!(f32, f64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 306 | impl_float_truncate!(f32, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 306 | impl_float_truncate!(f32, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 307 | impl_float_truncate!(f32, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 307 | impl_float_truncate!(f32, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 308 | impl_float_truncate!(f32, i64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 308 | impl_float_truncate!(f32, i64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 309 | impl_float_truncate!(f32, u64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 309 | impl_float_truncate!(f32, u64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 310 | impl_float_truncate!(f64, i64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 310 | impl_float_truncate!(f64, i64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 311 | impl_float_truncate!(f64, u64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 311 | impl_float_truncate!(f64, u64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 312 | impl_float_truncate!(f64, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 312 | impl_float_truncate!(f64, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(result)` [INFO] [stderr] ... [INFO] [stderr] 312 | impl_float_truncate!(f64, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_float_truncate!(f64, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 313 | impl_float_truncate!(f64, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(result)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_float_truncate!(f64, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::func_builder::FuncBuilder` [INFO] [stderr] --> src/builder/func_builder.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> FuncBuilder { [INFO] [stderr] 13 | | FuncBuilder { [INFO] [stderr] 14 | | export: None, [INFO] [stderr] 15 | | import: None, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for builder::func_builder::FuncBuilder { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::module_builder::ModuleBuilder` [INFO] [stderr] --> src/builder/module_builder.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> ModuleBuilder { [INFO] [stderr] 18 | | ModuleBuilder { [INFO] [stderr] 19 | | types: Vec::new(), [INFO] [stderr] 20 | | imports: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::type_use::TypeUse` [INFO] [stderr] --> src/builder/type_use.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> TypeUse { [INFO] [stderr] 11 | | TypeUse { [INFO] [stderr] 12 | | id: None, [INFO] [stderr] 13 | | params: Vec::new(), [INFO] [stderr] 14 | | results: Vec::new(), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hosting::host::Host` [INFO] [stderr] --> src/hosting/host.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Host { [INFO] [stderr] 22 | | Host { [INFO] [stderr] 23 | | modules: Vec::new(), [INFO] [stderr] 24 | | funcs: Vec::new(), [INFO] [stderr] 25 | | mems: Vec::new(), [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hosting/host.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | module_exports: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Export]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hosting/host.rs:263:59 [INFO] [stderr] | [INFO] [stderr] 263 | fn instantiate_data(&mut self, module: &Module, mems: &Vec) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[MemAddr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interp::stack::ExecutionStack` [INFO] [stderr] --> src/interp/stack.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> ExecutionStack { [INFO] [stderr] 116 | | ExecutionStack(Vec::new()) [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 112 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interp/stack.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | if self.0.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `interp::thread::Thread` [INFO] [stderr] --> src/interp/thread.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Thread { [INFO] [stderr] 14 | | Thread { [INFO] [stderr] 15 | | stack: ExecutionStack::new(), [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for interp::thread::Thread { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interp/thread.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | .enter(func_inst.module().clone(), Some(func), locals); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `func_inst.module()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: item `module::expr::Expr` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/module/expr.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl Expr { [INFO] [stderr] 9 | | pub fn new(instructions: Vec) -> Expr { [INFO] [stderr] 10 | | Expr(instructions) [INFO] [stderr] 11 | | } [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/func_type.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if self.params().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.params().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/func_type.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if self.results.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.results.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/module/module.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | / match section.name.as_str() { [INFO] [stderr] 69 | | "name" => names = Some(ModuleNames::load(section.read_content()?)), [INFO] [stderr] 70 | | _ => { [INFO] [stderr] 71 | | // Unknown custom section, just ignore it [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let "name" = section.name.as_str() { names = Some(ModuleNames::load(section.read_content()?)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | types: types.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:85:45 [INFO] [stderr] | [INFO] [stderr] 85 | imports: imports.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:86:41 [INFO] [stderr] | [INFO] [stderr] 86 | funcs: funcs.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:87:45 [INFO] [stderr] | [INFO] [stderr] 87 | exports: exports.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | code: code.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | data: data.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/module.rs:175:16 [INFO] [stderr] | [INFO] [stderr] 175 | if typ.params().len() > 0 || typ.results().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!typ.params().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/module.rs:175:42 [INFO] [stderr] | [INFO] [stderr] 175 | if typ.params().len() > 0 || typ.results().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!typ.results().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/module.rs:182:16 [INFO] [stderr] | [INFO] [stderr] 182 | if code.locals().len() > 0 || code.body().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!code.locals().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/module.rs:182:43 [INFO] [stderr] | [INFO] [stderr] 182 | if code.locals().len() > 0 || code.body().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!code.body().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `module::module_names::FuncNames` [INFO] [stderr] --> src/module/module_names.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> FuncNames { [INFO] [stderr] 11 | | FuncNames { [INFO] [stderr] 12 | | func_name: None, [INFO] [stderr] 13 | | locals: SparseVec::new(), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for module::module_names::FuncNames { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `module::module_names::ModuleNames` [INFO] [stderr] --> src/module/module_names.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> ModuleNames { [INFO] [stderr] 38 | | ModuleNames { [INFO] [stderr] 39 | | module_name: None, [INFO] [stderr] 40 | | funcs: SparseVec::new(), [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | impl Default for module::module_names::ModuleNames { [INFO] [stderr] 37 | fn default() -> Self { [INFO] [stderr] 38 | Self::new() [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reader/name_section.rs:34:51 [INFO] [stderr] | [INFO] [stderr] 34 | func_names: func_names.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reader/name_section.rs:35:53 [INFO] [stderr] | [INFO] [stderr] 35 | local_names: local_names.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:95:30 [INFO] [stderr] | [INFO] [stderr] 95 | S::read(&mut reader.take(header.size as u64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(header.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `runtime::env::Env` [INFO] [stderr] --> src/runtime/env.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Env { [INFO] [stderr] 17 | | Env { [INFO] [stderr] 18 | | funcs: vec![Arc::new(ExternalFunc::new( [INFO] [stderr] 19 | | "print", [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `runtime::spectest::SpecTest` [INFO] [stderr] --> src/runtime/spectest.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> SpecTest { [INFO] [stderr] 16 | | SpecTest { [INFO] [stderr] 17 | | funcs: vec![Arc::new(ExternalFunc::new( [INFO] [stderr] 18 | | "print_i32", [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `warthog`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `memory::Memory` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/memory.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / impl Memory { [INFO] [stderr] 16 | | pub fn new(min_size: usize, max_size: Option) -> Result { [INFO] [stderr] 17 | | let layout = Layout::from_size_align(min_size, mem::align_of::())?; [INFO] [stderr] 18 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/memory.rs:36:34 [INFO] [stderr] | [INFO] [stderr] 36 | pub unsafe fn data(&self) -> &mut [u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/memory.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | pub unsafe fn data(&self) -> &mut [u8] { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sparse_vec::SparseVec` [INFO] [stderr] --> src/sparse_vec.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn new() -> SparseVec { [INFO] [stderr] 6 | | SparseVec(Vec::new()) [INFO] [stderr] 7 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/trap.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn message<'a>(&'a self) -> Cow<'a, str> { [INFO] [stderr] 18 | | use self::TrapCause::*; [INFO] [stderr] 19 | | [INFO] [stderr] 20 | | match self { [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | self.leading_zeros() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.leading_zeros())` [INFO] [stderr] ... [INFO] [stderr] 137 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | self.trailing_zeros() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.trailing_zeros())` [INFO] [stderr] ... [INFO] [stderr] 137 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | self.count_ones() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.count_ones())` [INFO] [stderr] ... [INFO] [stderr] 137 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | self.leading_zeros() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.leading_zeros())` [INFO] [stderr] ... [INFO] [stderr] 139 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | self.trailing_zeros() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.trailing_zeros())` [INFO] [stderr] ... [INFO] [stderr] 139 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | self.count_ones() as $t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.count_ones())` [INFO] [stderr] ... [INFO] [stderr] 139 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.fract().abs() - 0.5).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:221:31 [INFO] [stderr] | [INFO] [stderr] 221 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - -1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:221:31 [INFO] [stderr] | [INFO] [stderr] 221 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 254 | impl_float!(f32, u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.fract().abs() - 0.5).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:221:31 [INFO] [stderr] | [INFO] [stderr] 221 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - -1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:221:31 [INFO] [stderr] | [INFO] [stderr] 221 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 255 | impl_float!(f64, u64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 272 | impl_convert_by_cast!(u32, u64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 273 | impl_convert_by_cast!(i32, i64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 276 | impl_convert_by_cast!(u32, f64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 277 | impl_convert_by_cast!(i32, f64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | Ok(self as $to) [INFO] [stderr] | ^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 283 | impl_convert_by_cast!(f32, f64); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 306 | impl_float_truncate!(f32, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 306 | impl_float_truncate!(f32, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 307 | impl_float_truncate!(f32, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 307 | impl_float_truncate!(f32, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 308 | impl_float_truncate!(f32, i64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 308 | impl_float_truncate!(f32, i64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 309 | impl_float_truncate!(f32, u64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 309 | impl_float_truncate!(f32, u64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 310 | impl_float_truncate!(f64, i64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 310 | impl_float_truncate!(f64, i64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 311 | impl_float_truncate!(f64, u64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 311 | impl_float_truncate!(f64, u64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 312 | impl_float_truncate!(f64, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 312 | impl_float_truncate!(f64, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(result)` [INFO] [stderr] ... [INFO] [stderr] 312 | impl_float_truncate!(f64, i32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $float - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_float_truncate!(f64, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 313 | impl_float_truncate!(f64, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/ops.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | if result as $float != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(result)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_float_truncate!(f64, u32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::func_builder::FuncBuilder` [INFO] [stderr] --> src/builder/func_builder.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> FuncBuilder { [INFO] [stderr] 13 | | FuncBuilder { [INFO] [stderr] 14 | | export: None, [INFO] [stderr] 15 | | import: None, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for builder::func_builder::FuncBuilder { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::module_builder::ModuleBuilder` [INFO] [stderr] --> src/builder/module_builder.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> ModuleBuilder { [INFO] [stderr] 18 | | ModuleBuilder { [INFO] [stderr] 19 | | types: Vec::new(), [INFO] [stderr] 20 | | imports: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::type_use::TypeUse` [INFO] [stderr] --> src/builder/type_use.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> TypeUse { [INFO] [stderr] 11 | | TypeUse { [INFO] [stderr] 12 | | id: None, [INFO] [stderr] 13 | | params: Vec::new(), [INFO] [stderr] 14 | | results: Vec::new(), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hosting::host::Host` [INFO] [stderr] --> src/hosting/host.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Host { [INFO] [stderr] 22 | | Host { [INFO] [stderr] 23 | | modules: Vec::new(), [INFO] [stderr] 24 | | funcs: Vec::new(), [INFO] [stderr] 25 | | mems: Vec::new(), [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hosting/host.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | module_exports: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Export]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hosting/host.rs:263:59 [INFO] [stderr] | [INFO] [stderr] 263 | fn instantiate_data(&mut self, module: &Module, mems: &Vec) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[MemAddr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interp::stack::ExecutionStack` [INFO] [stderr] --> src/interp/stack.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> ExecutionStack { [INFO] [stderr] 116 | | ExecutionStack(Vec::new()) [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 112 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interp/stack.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | if self.0.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `interp::thread::Thread` [INFO] [stderr] --> src/interp/thread.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Thread { [INFO] [stderr] 14 | | Thread { [INFO] [stderr] 15 | | stack: ExecutionStack::new(), [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for interp::thread::Thread { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interp/thread.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | .enter(func_inst.module().clone(), Some(func), locals); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `func_inst.module()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: item `module::expr::Expr` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/module/expr.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl Expr { [INFO] [stderr] 9 | | pub fn new(instructions: Vec) -> Expr { [INFO] [stderr] 10 | | Expr(instructions) [INFO] [stderr] 11 | | } [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/func_type.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if self.params().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.params().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/func_type.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if self.results.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.results.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/module/module.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | / match section.name.as_str() { [INFO] [stderr] 69 | | "name" => names = Some(ModuleNames::load(section.read_content()?)), [INFO] [stderr] 70 | | _ => { [INFO] [stderr] 71 | | // Unknown custom section, just ignore it [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let "name" = section.name.as_str() { names = Some(ModuleNames::load(section.read_content()?)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | types: types.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:85:45 [INFO] [stderr] | [INFO] [stderr] 85 | imports: imports.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:86:41 [INFO] [stderr] | [INFO] [stderr] 86 | funcs: funcs.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:87:45 [INFO] [stderr] | [INFO] [stderr] 87 | exports: exports.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:88:39 [INFO] [stderr] | [INFO] [stderr] 88 | code: code.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/module/module.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | data: data.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/module.rs:175:16 [INFO] [stderr] | [INFO] [stderr] 175 | if typ.params().len() > 0 || typ.results().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!typ.params().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/module.rs:175:42 [INFO] [stderr] | [INFO] [stderr] 175 | if typ.params().len() > 0 || typ.results().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!typ.results().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/module.rs:182:16 [INFO] [stderr] | [INFO] [stderr] 182 | if code.locals().len() > 0 || code.body().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!code.locals().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/module/module.rs:182:43 [INFO] [stderr] | [INFO] [stderr] 182 | if code.locals().len() > 0 || code.body().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!code.body().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `module::module_names::FuncNames` [INFO] [stderr] --> src/module/module_names.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> FuncNames { [INFO] [stderr] 11 | | FuncNames { [INFO] [stderr] 12 | | func_name: None, [INFO] [stderr] 13 | | locals: SparseVec::new(), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for module::module_names::FuncNames { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `module::module_names::ModuleNames` [INFO] [stderr] --> src/module/module_names.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> ModuleNames { [INFO] [stderr] 38 | | ModuleNames { [INFO] [stderr] 39 | | module_name: None, [INFO] [stderr] 40 | | funcs: SparseVec::new(), [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | impl Default for module::module_names::ModuleNames { [INFO] [stderr] 37 | fn default() -> Self { [INFO] [stderr] 38 | Self::new() [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reader/name_section.rs:34:51 [INFO] [stderr] | [INFO] [stderr] 34 | func_names: func_names.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reader/name_section.rs:35:53 [INFO] [stderr] | [INFO] [stderr] 35 | local_names: local_names.unwrap_or_else(|| Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader/mod.rs:95:30 [INFO] [stderr] | [INFO] [stderr] 95 | S::read(&mut reader.take(header.size as u64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(header.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `runtime::env::Env` [INFO] [stderr] --> src/runtime/env.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Env { [INFO] [stderr] 17 | | Env { [INFO] [stderr] 18 | | funcs: vec![Arc::new(ExternalFunc::new( [INFO] [stderr] 19 | | "print", [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `runtime::spectest::SpecTest` [INFO] [stderr] --> src/runtime/spectest.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> SpecTest { [INFO] [stderr] 16 | | SpecTest { [INFO] [stderr] 17 | | funcs: vec![Arc::new(ExternalFunc::new( [INFO] [stderr] 18 | | "print_i32", [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `warthog`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dcffccf24496a1df0265205086b71f8cf3030bbb1e88c17006d4891fc1e83dcc"` [INFO] running `"docker" "rm" "-f" "dcffccf24496a1df0265205086b71f8cf3030bbb1e88c17006d4891fc1e83dcc"` [INFO] [stdout] dcffccf24496a1df0265205086b71f8cf3030bbb1e88c17006d4891fc1e83dcc