[INFO] updating cached repository anthonynguyen/primitive [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/anthonynguyen/primitive [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/anthonynguyen/primitive" "work/ex/clippy-test-run/sources/stable/gh/anthonynguyen/primitive"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anthonynguyen/primitive'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/anthonynguyen/primitive" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anthonynguyen/primitive"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anthonynguyen/primitive'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 12110da00942d58a2cd10fee8d9d28de79af46d0 [INFO] sha for GitHub repo anthonynguyen/primitive: 12110da00942d58a2cd10fee8d9d28de79af46d0 [INFO] validating manifest of anthonynguyen/primitive on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anthonynguyen/primitive on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anthonynguyen/primitive [INFO] finished frobbing anthonynguyen/primitive [INFO] frobbed toml for anthonynguyen/primitive written to work/ex/clippy-test-run/sources/stable/gh/anthonynguyen/primitive/Cargo.toml [INFO] started frobbing anthonynguyen/primitive [INFO] finished frobbing anthonynguyen/primitive [INFO] frobbed toml for anthonynguyen/primitive written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anthonynguyen/primitive/Cargo.toml [INFO] crate anthonynguyen/primitive has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anthonynguyen/primitive against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anthonynguyen/primitive:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afeef3384cc52cac58b3f8635df509792e246ef13423e91577ccdded5474d80d [INFO] running `"docker" "start" "-a" "afeef3384cc52cac58b3f8635df509792e246ef13423e91577ccdded5474d80d"` [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking isatty v0.1.5 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking png v0.10.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking loglog v0.3.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.16.0 [INFO] [stderr] Checking primitive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: function is never used: `euclidean` [INFO] [stderr] --> src/distance.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn euclidean>(p1: &P, p2: &P) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rect` [INFO] [stderr] --> src/generator.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn rect(&mut self, len: u32) -> Vec<(u32, u32)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / (((c2[0] as i32 - c1[0] as i32).pow(2) + [INFO] [stderr] 9 | | (c2[1] as i32 - c1[1] as i32).pow(2) + [INFO] [stderr] 10 | | (c2[2] as i32 - c1[2] as i32).pow(2)) as f64).sqrt() as u32 [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 8 | f64::from((c2[0] as i32 - c1[0] as i32).pow(2) + [INFO] [stderr] 9 | (c2[1] as i32 - c1[1] as i32).pow(2) + [INFO] [stderr] 10 | (c2[2] as i32 - c1[2] as i32).pow(2)).sqrt() as u32 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:8:8 [INFO] [stderr] | [INFO] [stderr] 8 | (((c2[0] as i32 - c1[0] as i32).pow(2) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | (((c2[0] as i32 - c1[0] as i32).pow(2) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:9:8 [INFO] [stderr] | [INFO] [stderr] 9 | (c2[1] as i32 - c1[1] as i32).pow(2) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:9:23 [INFO] [stderr] | [INFO] [stderr] 9 | (c2[1] as i32 - c1[1] as i32).pow(2) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:10:8 [INFO] [stderr] | [INFO] [stderr] 10 | (c2[2] as i32 - c1[2] as i32).pow(2)) as f64).sqrt() as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | (c2[2] as i32 - c1[2] as i32).pow(2)) as f64).sqrt() as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | ((c2[0] as i32 - c1[0] as i32).abs() + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | ((c2[0] as i32 - c1[0] as i32).abs() + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | (c2[1] as i32 - c1[1] as i32).abs() + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | (c2[1] as i32 - c1[1] as i32).abs() + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | (c2[2] as i32 - c1[2] as i32).abs()) as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | (c2[2] as i32 - c1[2] as i32).abs()) as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generator.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | let angle = (self.angle() as f64).to_radians(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.angle())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generator.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | let lenf64 = len as f64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | for i in 0..ctx.settings.iterations + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=ctx.settings.iterations` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | let sample_pixel = ctx.image.get_pixel(sample_x, sample_y).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*ctx.image.get_pixel(sample_x, sample_y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:40 [INFO] [stderr] | [INFO] [stderr] 80 | info!("{} ns/iter", nanos as f64 / total_iters as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(total_iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: function is never used: `euclidean` [INFO] [stderr] --> src/distance.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn euclidean>(p1: &P, p2: &P) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rect` [INFO] [stderr] --> src/generator.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn rect(&mut self, len: u32) -> Vec<(u32, u32)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / (((c2[0] as i32 - c1[0] as i32).pow(2) + [INFO] [stderr] 9 | | (c2[1] as i32 - c1[1] as i32).pow(2) + [INFO] [stderr] 10 | | (c2[2] as i32 - c1[2] as i32).pow(2)) as f64).sqrt() as u32 [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 8 | f64::from((c2[0] as i32 - c1[0] as i32).pow(2) + [INFO] [stderr] 9 | (c2[1] as i32 - c1[1] as i32).pow(2) + [INFO] [stderr] 10 | (c2[2] as i32 - c1[2] as i32).pow(2)).sqrt() as u32 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:8:8 [INFO] [stderr] | [INFO] [stderr] 8 | (((c2[0] as i32 - c1[0] as i32).pow(2) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | (((c2[0] as i32 - c1[0] as i32).pow(2) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:9:8 [INFO] [stderr] | [INFO] [stderr] 9 | (c2[1] as i32 - c1[1] as i32).pow(2) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:9:23 [INFO] [stderr] | [INFO] [stderr] 9 | (c2[1] as i32 - c1[1] as i32).pow(2) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:10:8 [INFO] [stderr] | [INFO] [stderr] 10 | (c2[2] as i32 - c1[2] as i32).pow(2)) as f64).sqrt() as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | (c2[2] as i32 - c1[2] as i32).pow(2)) as f64).sqrt() as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | ((c2[0] as i32 - c1[0] as i32).abs() + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | ((c2[0] as i32 - c1[0] as i32).abs() + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | (c2[1] as i32 - c1[1] as i32).abs() + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | (c2[1] as i32 - c1[1] as i32).abs() + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | (c2[2] as i32 - c1[2] as i32).abs()) as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c2[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/distance.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | (c2[2] as i32 - c1[2] as i32).abs()) as u32 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generator.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | let angle = (self.angle() as f64).to_radians(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.angle())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/generator.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | let lenf64 = len as f64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | for i in 0..ctx.settings.iterations + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=ctx.settings.iterations` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | let sample_pixel = ctx.image.get_pixel(sample_x, sample_y).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*ctx.image.get_pixel(sample_x, sample_y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:40 [INFO] [stderr] | [INFO] [stderr] 80 | info!("{} ns/iter", nanos as f64 / total_iters as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(total_iters)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.92s [INFO] running `"docker" "inspect" "afeef3384cc52cac58b3f8635df509792e246ef13423e91577ccdded5474d80d"` [INFO] running `"docker" "rm" "-f" "afeef3384cc52cac58b3f8635df509792e246ef13423e91577ccdded5474d80d"` [INFO] [stdout] afeef3384cc52cac58b3f8635df509792e246ef13423e91577ccdded5474d80d