[INFO] updating cached repository anontyro/Guessing_Game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/anontyro/Guessing_Game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/anontyro/Guessing_Game" "work/ex/clippy-test-run/sources/stable/gh/anontyro/Guessing_Game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anontyro/Guessing_Game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/anontyro/Guessing_Game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anontyro/Guessing_Game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anontyro/Guessing_Game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9ced9a60be091f033dfdcca90cf5a2de2eac660c [INFO] sha for GitHub repo anontyro/Guessing_Game: 9ced9a60be091f033dfdcca90cf5a2de2eac660c [INFO] validating manifest of anontyro/Guessing_Game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anontyro/Guessing_Game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anontyro/Guessing_Game [INFO] finished frobbing anontyro/Guessing_Game [INFO] frobbed toml for anontyro/Guessing_Game written to work/ex/clippy-test-run/sources/stable/gh/anontyro/Guessing_Game/Cargo.toml [INFO] started frobbing anontyro/Guessing_Game [INFO] finished frobbing anontyro/Guessing_Game [INFO] frobbed toml for anontyro/Guessing_Game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anontyro/Guessing_Game/Cargo.toml [INFO] crate anontyro/Guessing_Game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anontyro/Guessing_Game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anontyro/Guessing_Game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 140595cf26682991ca0da9f7c8823f6a46f8736fcb0f47028bf4d15054d66376 [INFO] running `"docker" "start" "-a" "140595cf26682991ca0da9f7c8823f6a46f8736fcb0f47028bf4d15054d66376"` [INFO] [stderr] Checking guessing_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match check_guess(number, guess) { [INFO] [stderr] 23 | | true => break, [INFO] [stderr] 24 | | false => continue [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if check_guess(number, guess) { break } else { continue }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match check_guess(number, guess) { [INFO] [stderr] 23 | | true => break, [INFO] [stderr] 24 | | false => continue [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if check_guess(number, guess) { break } else { continue }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.96s [INFO] running `"docker" "inspect" "140595cf26682991ca0da9f7c8823f6a46f8736fcb0f47028bf4d15054d66376"` [INFO] running `"docker" "rm" "-f" "140595cf26682991ca0da9f7c8823f6a46f8736fcb0f47028bf4d15054d66376"` [INFO] [stdout] 140595cf26682991ca0da9f7c8823f6a46f8736fcb0f47028bf4d15054d66376