[INFO] updating cached repository anoadragon453/rust-aes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/anoadragon453/rust-aes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/anoadragon453/rust-aes" "work/ex/clippy-test-run/sources/stable/gh/anoadragon453/rust-aes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anoadragon453/rust-aes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/anoadragon453/rust-aes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anoadragon453/rust-aes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anoadragon453/rust-aes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 15d8daf80b2c732e972a588d7dbe505b2500a04a [INFO] sha for GitHub repo anoadragon453/rust-aes: 15d8daf80b2c732e972a588d7dbe505b2500a04a [INFO] validating manifest of anoadragon453/rust-aes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anoadragon453/rust-aes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anoadragon453/rust-aes [INFO] finished frobbing anoadragon453/rust-aes [INFO] frobbed toml for anoadragon453/rust-aes written to work/ex/clippy-test-run/sources/stable/gh/anoadragon453/rust-aes/Cargo.toml [INFO] started frobbing anoadragon453/rust-aes [INFO] finished frobbing anoadragon453/rust-aes [INFO] frobbed toml for anoadragon453/rust-aes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anoadragon453/rust-aes/Cargo.toml [INFO] crate anoadragon453/rust-aes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anoadragon453/rust-aes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anoadragon453/rust-aes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91342985000f97167dfefc869c238c8679504c5b6c05736897a103dfd495b312 [INFO] running `"docker" "start" "-a" "91342985000f97167dfefc869c238c8679504c5b6c05736897a103dfd495b312"` [INFO] [stderr] Checking numrs v0.2.0 [INFO] [stderr] Checking aes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | sbox [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | let sbox = matrix::from_elems(16, 16, &sbox); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | rcon [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | let rcon = matrix::from_elems(4, 1, &[rcon[col], 0, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:145:67 [INFO] [stderr] | [INFO] [stderr] 145 | let mut col = matrix::from_elems(1, 4, &[round_key.get(0, (i-1)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:146:67 [INFO] [stderr] | [INFO] [stderr] 146 | round_key.get(1, (i-1)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:147:67 [INFO] [stderr] | [INFO] [stderr] 147 | round_key.get(2, (i-1)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:148:67 [INFO] [stderr] | [INFO] [stderr] 148 | round_key.get(3, (i-1))]); [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | xor_matricies(&mut col, &get_rcon_col((i / 4))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | xor_matricies(&mut col, &get_rcon_col((i / 4))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:163:68 [INFO] [stderr] | [INFO] [stderr] 163 | let init_col = matrix::from_elems(1, 4, &[round_key.get(0, (i-4)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:164:68 [INFO] [stderr] | [INFO] [stderr] 164 | round_key.get(1, (i-4)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:165:68 [INFO] [stderr] | [INFO] [stderr] 165 | round_key.get(2, (i-4)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:166:68 [INFO] [stderr] | [INFO] [stderr] 166 | round_key.get(3, (i-4))]); [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:224:38 [INFO] [stderr] | [INFO] [stderr] 224 | state.set(i, j, sbox.get((hex_row as usize), (hex_col as usize))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:224:58 [INFO] [stderr] | [INFO] [stderr] 224 | state.set(i, j, sbox.get((hex_row as usize), (hex_col as usize))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:234:36 [INFO] [stderr] | [INFO] [stderr] 234 | round_key_chunk.set(i, (j % 4), round_key.get(i, j)); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | sbox [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | let sbox = matrix::from_elems(16, 16, &sbox); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | rcon [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | let rcon = matrix::from_elems(4, 1, &[rcon[col], 0, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:145:67 [INFO] [stderr] | [INFO] [stderr] 145 | let mut col = matrix::from_elems(1, 4, &[round_key.get(0, (i-1)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:146:67 [INFO] [stderr] | [INFO] [stderr] 146 | round_key.get(1, (i-1)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:147:67 [INFO] [stderr] | [INFO] [stderr] 147 | round_key.get(2, (i-1)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:148:67 [INFO] [stderr] | [INFO] [stderr] 148 | round_key.get(3, (i-1))]); [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | xor_matricies(&mut col, &get_rcon_col((i / 4))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | xor_matricies(&mut col, &get_rcon_col((i / 4))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:163:68 [INFO] [stderr] | [INFO] [stderr] 163 | let init_col = matrix::from_elems(1, 4, &[round_key.get(0, (i-4)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:164:68 [INFO] [stderr] | [INFO] [stderr] 164 | round_key.get(1, (i-4)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:165:68 [INFO] [stderr] | [INFO] [stderr] 165 | round_key.get(2, (i-4)), [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:166:68 [INFO] [stderr] | [INFO] [stderr] 166 | round_key.get(3, (i-4))]); [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:224:38 [INFO] [stderr] | [INFO] [stderr] 224 | state.set(i, j, sbox.get((hex_row as usize), (hex_col as usize))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:224:58 [INFO] [stderr] | [INFO] [stderr] 224 | state.set(i, j, sbox.get((hex_row as usize), (hex_col as usize))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:234:36 [INFO] [stderr] | [INFO] [stderr] 234 | round_key_chunk.set(i, (j % 4), round_key.get(i, j)); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iters` [INFO] [stderr] --> src/main.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | let row_nums = [m.get(row,(0 + iters) % 4), m.get(row,(1 + iters) % 4), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `col` is used to index `row_nums` [INFO] [stderr] --> src/main.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | for col in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for (col, ) in row_nums.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `m_col` [INFO] [stderr] --> src/main.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | for row in 0..state.num_rows() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 109 | for (row, ) in m_col.iter().enumerate().take(state.num_rows()) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `iters` [INFO] [stderr] --> src/main.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | let row_nums = [m.get(row,(0 + iters) % 4), m.get(row,(1 + iters) % 4), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `col` is used to index `row_nums` [INFO] [stderr] --> src/main.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | for col in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for (col, ) in row_nums.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `m_col` [INFO] [stderr] --> src/main.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | for row in 0..state.num_rows() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 109 | for (row, ) in m_col.iter().enumerate().take(state.num_rows()) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.39s [INFO] running `"docker" "inspect" "91342985000f97167dfefc869c238c8679504c5b6c05736897a103dfd495b312"` [INFO] running `"docker" "rm" "-f" "91342985000f97167dfefc869c238c8679504c5b6c05736897a103dfd495b312"` [INFO] [stdout] 91342985000f97167dfefc869c238c8679504c5b6c05736897a103dfd495b312