[INFO] updating cached repository annikoff/hmbc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/annikoff/hmbc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/annikoff/hmbc" "work/ex/clippy-test-run/sources/stable/gh/annikoff/hmbc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/annikoff/hmbc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/annikoff/hmbc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/annikoff/hmbc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/annikoff/hmbc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 72f75e1920bc90f0f3aa1f01c3b3bd3b34664090
[INFO] sha for GitHub repo annikoff/hmbc: 72f75e1920bc90f0f3aa1f01c3b3bd3b34664090
[INFO] validating manifest of annikoff/hmbc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of annikoff/hmbc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing annikoff/hmbc
[INFO] finished frobbing annikoff/hmbc
[INFO] frobbed toml for annikoff/hmbc written to work/ex/clippy-test-run/sources/stable/gh/annikoff/hmbc/Cargo.toml
[INFO] started frobbing annikoff/hmbc
[INFO] finished frobbing annikoff/hmbc
[INFO] frobbed toml for annikoff/hmbc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/annikoff/hmbc/Cargo.toml
[INFO] crate annikoff/hmbc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting annikoff/hmbc against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/annikoff/hmbc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5cd1f0bc1cf4bab298437b9d6ce691090643856e7cbcce49a020c62999daf18a
[INFO] running `"docker" "start" "-a" "5cd1f0bc1cf4bab298437b9d6ce691090643856e7cbcce49a020c62999daf18a"`
[INFO] [stderr]     Checking sha1 v0.6.0
[INFO] [stderr]     Checking bincode v1.0.1
[INFO] [stderr]     Checking hmbc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/blockchain.rs:45:54
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn create_block(&mut self, content: &String) -> () {
[INFO] [stderr]    |                                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `timestamp`
[INFO] [stderr]   --> src/block.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn timestamp(&self) -> i64 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `previous_hash`
[INFO] [stderr]   --> src/block.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn previous_hash(&self) -> &str {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `content`
[INFO] [stderr]   --> src/block.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 |     pub fn content(&self) -> &str {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `content`
[INFO] [stderr]   --> src/block_content.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     pub fn content(&self) -> &String {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `block`
[INFO] [stderr]   --> src/blockchain.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     pub fn block(&self, index: usize) -> Option<&Block> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `len`
[INFO] [stderr]   --> src/blockchain.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn len(&self) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/block.rs:17:43
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn new(index: i64, previous_hash: &String, content: &String) -> Block {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/block.rs:17:61
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn new(index: i64, previous_hash: &String, content: &String) -> Block {
[INFO] [stderr]    |                                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/block_content.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 |     pub fn new(content: &String) -> BlockContent {
[INFO] [stderr]   |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/blockchain.rs:27:12
[INFO] [stderr]    |
[INFO] [stderr] 27 |         if self.blocks.len() > 0 && index < self.blocks.len() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.blocks.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/blockchain.rs:45:45
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn create_block(&mut self, content: &String) -> () {
[INFO] [stderr]    |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/blockchain.rs:45:54
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn create_block(&mut self, content: &String) -> () {
[INFO] [stderr]    |                                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `timestamp`
[INFO] [stderr]   --> src/block.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn timestamp(&self) -> i64 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/block.rs:17:43
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn new(index: i64, previous_hash: &String, content: &String) -> Block {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/block.rs:17:61
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn new(index: i64, previous_hash: &String, content: &String) -> Block {
[INFO] [stderr]    |                                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/block_content.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 |     pub fn new(content: &String) -> BlockContent {
[INFO] [stderr]   |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/blockchain.rs:27:12
[INFO] [stderr]    |
[INFO] [stderr] 27 |         if self.blocks.len() > 0 && index < self.blocks.len() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.blocks.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/blockchain.rs:45:45
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn create_block(&mut self, content: &String) -> () {
[INFO] [stderr]    |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.14s
[INFO] running `"docker" "inspect" "5cd1f0bc1cf4bab298437b9d6ce691090643856e7cbcce49a020c62999daf18a"`
[INFO] running `"docker" "rm" "-f" "5cd1f0bc1cf4bab298437b9d6ce691090643856e7cbcce49a020c62999daf18a"`
[INFO] [stdout] 5cd1f0bc1cf4bab298437b9d6ce691090643856e7cbcce49a020c62999daf18a