[INFO] updating cached repository anmej/piston-falling-sand-prototype [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/anmej/piston-falling-sand-prototype [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/anmej/piston-falling-sand-prototype" "work/ex/clippy-test-run/sources/stable/gh/anmej/piston-falling-sand-prototype"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anmej/piston-falling-sand-prototype'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/anmej/piston-falling-sand-prototype" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anmej/piston-falling-sand-prototype"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anmej/piston-falling-sand-prototype'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebc31d2bae842874c9a2c558ddffbb65063e8d6a [INFO] sha for GitHub repo anmej/piston-falling-sand-prototype: ebc31d2bae842874c9a2c558ddffbb65063e8d6a [INFO] validating manifest of anmej/piston-falling-sand-prototype on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anmej/piston-falling-sand-prototype on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anmej/piston-falling-sand-prototype [INFO] finished frobbing anmej/piston-falling-sand-prototype [INFO] frobbed toml for anmej/piston-falling-sand-prototype written to work/ex/clippy-test-run/sources/stable/gh/anmej/piston-falling-sand-prototype/Cargo.toml [INFO] started frobbing anmej/piston-falling-sand-prototype [INFO] finished frobbing anmej/piston-falling-sand-prototype [INFO] frobbed toml for anmej/piston-falling-sand-prototype written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anmej/piston-falling-sand-prototype/Cargo.toml [INFO] crate anmej/piston-falling-sand-prototype has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anmej/piston-falling-sand-prototype against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anmej/piston-falling-sand-prototype:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a39ac4eca92704a05901a46cd5b1606447979061478e2f30cb3446238a791559 [INFO] running `"docker" "start" "-a" "a39ac4eca92704a05901a46cd5b1606447979061478e2f30cb3446238a791559"` [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking piston-gfx_texture v0.24.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.40.0 [INFO] [stderr] Checking piston_window v0.66.0 [INFO] [stderr] Checking falling_sand v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:148:43 [INFO] [stderr] | [INFO] [stderr] 148 | self.particles.push(Loc { x: x, y: 0 }); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | let loc = Loc { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:175:31 [INFO] [stderr] | [INFO] [stderr] 175 | let loc = Loc { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | let loc = Loc { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:181:31 [INFO] [stderr] | [INFO] [stderr] 181 | let loc = Loc { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:148:43 [INFO] [stderr] | [INFO] [stderr] 148 | self.particles.push(Loc { x: x, y: 0 }); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | let loc = Loc { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:175:31 [INFO] [stderr] | [INFO] [stderr] 175 | let loc = Loc { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | let loc = Loc { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gamestate.rs:181:31 [INFO] [stderr] | [INFO] [stderr] 181 | let loc = Loc { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(_) = e.update_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 57 | | // Update game and image on every loop [INFO] [stderr] 58 | | if !paused { [INFO] [stderr] 59 | | if raining { [INFO] [stderr] ... | [INFO] [stderr] 64 | | } //if !paused { [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________- help: try this: `if e.update_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(_) = e.render_args() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 102 | | canvas = im::ImageBuffer::from_vec(width, height, blank.clone()).unwrap(); [INFO] [stderr] 103 | | for particle in &game.particles { [INFO] [stderr] 104 | | canvas.put_pixel( [INFO] [stderr] ... | [INFO] [stderr] 119 | | redraw_needed = false; [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(_) = e.update_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 57 | | // Update game and image on every loop [INFO] [stderr] 58 | | if !paused { [INFO] [stderr] 59 | | if raining { [INFO] [stderr] ... | [INFO] [stderr] 64 | | } //if !paused { [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________- help: try this: `if e.update_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(_) = e.render_args() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 102 | | canvas = im::ImageBuffer::from_vec(width, height, blank.clone()).unwrap(); [INFO] [stderr] 103 | | for particle in &game.particles { [INFO] [stderr] 104 | | canvas.put_pixel( [INFO] [stderr] ... | [INFO] [stderr] 119 | | redraw_needed = false; [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.43s [INFO] running `"docker" "inspect" "a39ac4eca92704a05901a46cd5b1606447979061478e2f30cb3446238a791559"` [INFO] running `"docker" "rm" "-f" "a39ac4eca92704a05901a46cd5b1606447979061478e2f30cb3446238a791559"` [INFO] [stdout] a39ac4eca92704a05901a46cd5b1606447979061478e2f30cb3446238a791559