[INFO] updating cached repository andyjones11/sniff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andyjones11/sniff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andyjones11/sniff" "work/ex/clippy-test-run/sources/stable/gh/andyjones11/sniff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andyjones11/sniff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andyjones11/sniff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andyjones11/sniff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andyjones11/sniff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] af7e1beb014a9d3674972b6f8897eb84588eb50a [INFO] sha for GitHub repo andyjones11/sniff: af7e1beb014a9d3674972b6f8897eb84588eb50a [INFO] validating manifest of andyjones11/sniff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andyjones11/sniff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andyjones11/sniff [INFO] finished frobbing andyjones11/sniff [INFO] frobbed toml for andyjones11/sniff written to work/ex/clippy-test-run/sources/stable/gh/andyjones11/sniff/Cargo.toml [INFO] started frobbing andyjones11/sniff [INFO] finished frobbing andyjones11/sniff [INFO] frobbed toml for andyjones11/sniff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andyjones11/sniff/Cargo.toml [INFO] crate andyjones11/sniff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andyjones11/sniff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andyjones11/sniff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4b24f8a2548b79cf7e081fc3c05217c731875c7befd75c0c556640ba3b99a68 [INFO] running `"docker" "start" "-a" "c4b24f8a2548b79cf7e081fc3c05217c731875c7befd75c0c556640ba3b99a68"` [INFO] [stderr] Checking sniff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | if let Ok(_) = TcpStream::connect((ip_addr, i)) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 12 | | open_ports.push(i); [INFO] [stderr] 13 | | } else {} [INFO] [stderr] | |_________________- help: try this: `if TcpStream::connect((ip_addr, i)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | if let Ok(_) = TcpStream::connect((ip_addr, i)) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 12 | | open_ports.push(i); [INFO] [stderr] 13 | | } else {} [INFO] [stderr] | |_________________- help: try this: `if TcpStream::connect((ip_addr, i)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "c4b24f8a2548b79cf7e081fc3c05217c731875c7befd75c0c556640ba3b99a68"` [INFO] running `"docker" "rm" "-f" "c4b24f8a2548b79cf7e081fc3c05217c731875c7befd75c0c556640ba3b99a68"` [INFO] [stdout] c4b24f8a2548b79cf7e081fc3c05217c731875c7befd75c0c556640ba3b99a68