[INFO] updating cached repository andygrove/octasonic-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/andygrove/octasonic-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/andygrove/octasonic-rs" "work/ex/clippy-test-run/sources/stable/gh/andygrove/octasonic-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andygrove/octasonic-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/andygrove/octasonic-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andygrove/octasonic-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andygrove/octasonic-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0f231ab3159bbcedc99aa5729447d3c1b502aa13
[INFO] sha for GitHub repo andygrove/octasonic-rs: 0f231ab3159bbcedc99aa5729447d3c1b502aa13
[INFO] validating manifest of andygrove/octasonic-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of andygrove/octasonic-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing andygrove/octasonic-rs
[INFO] finished frobbing andygrove/octasonic-rs
[INFO] frobbed toml for andygrove/octasonic-rs written to work/ex/clippy-test-run/sources/stable/gh/andygrove/octasonic-rs/Cargo.toml
[INFO] started frobbing andygrove/octasonic-rs
[INFO] finished frobbing andygrove/octasonic-rs
[INFO] frobbed toml for andygrove/octasonic-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andygrove/octasonic-rs/Cargo.toml
[INFO] crate andygrove/octasonic-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting andygrove/octasonic-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andygrove/octasonic-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9d670f08dcc47983241ec20900e9aadf18b39ec2e68206b5521284b99bdc3119
[INFO] running `"docker" "start" "-a" "9d670f08dcc47983241ec20900e9aadf18b39ec2e68206b5521284b99bdc3119"`
[INFO] [stderr]     Checking memchr v0.1.11
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]    Compiling nix v0.6.0
[INFO] [stderr]     Checking thread-id v2.0.0
[INFO] [stderr]     Checking thread_local v0.2.7
[INFO] [stderr]     Checking aho-corasick v0.5.3
[INFO] [stderr]     Checking regex v0.1.80
[INFO] [stderr]     Checking spidev v0.2.1
[INFO] [stderr]     Checking sysfs_gpio v0.4.4
[INFO] [stderr]     Checking octasonic v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:32:29
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let o = Octasonic { spi: spi };
[INFO] [stderr]    |                             ^^^^^^^^ help: replace it with: `spi`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:32:29
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let o = Octasonic { spi: spi };
[INFO] [stderr]    |                             ^^^^^^^^ help: replace it with: `spi`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> examples/demo.rs:23:3
[INFO] [stderr]    |
[INFO] [stderr] 23 |   println!("");
[INFO] [stderr]    |   ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::thread::sleep`
[INFO] [stderr]  --> examples/piano.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::thread::sleep;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::time::Duration`
[INFO] [stderr]  --> examples/piano.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::time::Duration;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> examples/piano.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         key[i].counter = key[i].counter+1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key[i].counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::thread::sleep`
[INFO] [stderr]  --> examples/theramin.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::thread::sleep;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::time::Duration`
[INFO] [stderr]  --> examples/theramin.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::time::Duration;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `playing`
[INFO] [stderr]  --> examples/theramin.rs:8:3
[INFO] [stderr]   |
[INFO] [stderr] 8 |   playing: bool,
[INFO] [stderr]   |   ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `counter`
[INFO] [stderr]  --> examples/theramin.rs:9:3
[INFO] [stderr]   |
[INFO] [stderr] 9 |   counter: u8
[INFO] [stderr]   |   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `note`
[INFO] [stderr]   --> examples/theramin.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0 .. 8 {
[INFO] [stderr]    |              ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for (i, <item>) in note.iter_mut().enumerate().take(8) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.03s
[INFO] running `"docker" "inspect" "9d670f08dcc47983241ec20900e9aadf18b39ec2e68206b5521284b99bdc3119"`
[INFO] running `"docker" "rm" "-f" "9d670f08dcc47983241ec20900e9aadf18b39ec2e68206b5521284b99bdc3119"`
[INFO] [stdout] 9d670f08dcc47983241ec20900e9aadf18b39ec2e68206b5521284b99bdc3119