[INFO] updating cached repository andy-5/wslgit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andy-5/wslgit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andy-5/wslgit" "work/ex/clippy-test-run/sources/stable/gh/andy-5/wslgit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andy-5/wslgit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andy-5/wslgit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andy-5/wslgit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andy-5/wslgit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e0d58c2cc05981e21d567d385900ec5025f86d5c [INFO] sha for GitHub repo andy-5/wslgit: e0d58c2cc05981e21d567d385900ec5025f86d5c [INFO] validating manifest of andy-5/wslgit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andy-5/wslgit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andy-5/wslgit [INFO] finished frobbing andy-5/wslgit [INFO] frobbed toml for andy-5/wslgit written to work/ex/clippy-test-run/sources/stable/gh/andy-5/wslgit/Cargo.toml [INFO] started frobbing andy-5/wslgit [INFO] finished frobbing andy-5/wslgit [INFO] frobbed toml for andy-5/wslgit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andy-5/wslgit/Cargo.toml [INFO] crate andy-5/wslgit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andy-5/wslgit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andy-5/wslgit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ce53c284ddda340911f483866c364340d0e00eb88f729835b8bebcf433cce13 [INFO] running `"docker" "start" "-a" "7ce53c284ddda340911f483866c364340d0e00eb88f729835b8bebcf433cce13"` [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking wslgit v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(&format!("Invalid drive letter: {}", drive_letter)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid drive letter: {}", drive_letter))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:47:68 [INFO] [stderr] | [INFO] [stderr] 47 | let d = get_drive_letter(&prefix_comp).expect( [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 48 | | &format!("Cannot handle path {:?}", [INFO] [stderr] 49 | | win_path)); [INFO] [stderr] | |___________________________________________________^ help: try this: `unwrap_or_else(|| panic!("Cannot handle path {:?}", win_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | .expect( [INFO] [stderr] | __________________________________^ [INFO] [stderr] 56 | | &format!("Cannot represent path {:?}", [INFO] [stderr] 57 | | win_path)) [INFO] [stderr] | |_______________________________________________________^ help: try this: `unwrap_or_else(|| panic!("Cannot represent path {:?}", win_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | if arg.contains(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:104:16 [INFO] [stderr] | [INFO] [stderr] 104 | if wslenv.split(':').position(|r| r.eq_ignore_ascii_case("BASH_ENV")).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `position(|r| r.eq_ignore_ascii_case("BASH_ENV")).is_some()` with `any(|r| r.eq_ignore_ascii_case("BASH_ENV"))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:159:8 [INFO] [stderr] | [INFO] [stderr] 159 | env::args().skip(1).position(|arg| TRANSLATED_CMDS.iter().position(|&tcmd| tcmd == arg).is_some()).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `position(|arg| TRANSLATED_CMDS.iter().position(|&tcmd| tcmd == arg).is_some()).is_some()` with `any(|arg| TRANSLATED_CMDS.iter().position(|&tcmd| tcmd == arg).is_some())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:159:43 [INFO] [stderr] | [INFO] [stderr] 159 | env::args().skip(1).position(|arg| TRANSLATED_CMDS.iter().position(|&tcmd| tcmd == arg).is_some()).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `position(|&tcmd| tcmd == arg).is_some()` with `any(|&tcmd| tcmd == arg)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:165:14 [INFO] [stderr] | [INFO] [stderr] 165 | .expect(&format!("Failed to execute command '{}'", &git_cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to execute command '{}'", &git_cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | .expect(&format!("Failed to wait for git call '{}'", &git_cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to wait for git call '{}'", &git_cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | .expect(&format!("Failed to execute command '{}'", &git_cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to execute command '{}'", &git_cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | .expect(&format!("Invalid drive letter: {}", drive_letter)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid drive letter: {}", drive_letter))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:47:68 [INFO] [stderr] | [INFO] [stderr] 47 | let d = get_drive_letter(&prefix_comp).expect( [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 48 | | &format!("Cannot handle path {:?}", [INFO] [stderr] 49 | | win_path)); [INFO] [stderr] | |___________________________________________________^ help: try this: `unwrap_or_else(|| panic!("Cannot handle path {:?}", win_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | .expect( [INFO] [stderr] | __________________________________^ [INFO] [stderr] 56 | | &format!("Cannot represent path {:?}", [INFO] [stderr] 57 | | win_path)) [INFO] [stderr] | |_______________________________________________________^ help: try this: `unwrap_or_else(|| panic!("Cannot represent path {:?}", win_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | if arg.contains(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:104:16 [INFO] [stderr] | [INFO] [stderr] 104 | if wslenv.split(':').position(|r| r.eq_ignore_ascii_case("BASH_ENV")).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `position(|r| r.eq_ignore_ascii_case("BASH_ENV")).is_some()` with `any(|r| r.eq_ignore_ascii_case("BASH_ENV"))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:159:8 [INFO] [stderr] | [INFO] [stderr] 159 | env::args().skip(1).position(|arg| TRANSLATED_CMDS.iter().position(|&tcmd| tcmd == arg).is_some()).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `position(|arg| TRANSLATED_CMDS.iter().position(|&tcmd| tcmd == arg).is_some()).is_some()` with `any(|arg| TRANSLATED_CMDS.iter().position(|&tcmd| tcmd == arg).is_some())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:159:43 [INFO] [stderr] | [INFO] [stderr] 159 | env::args().skip(1).position(|arg| TRANSLATED_CMDS.iter().position(|&tcmd| tcmd == arg).is_some()).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `position(|&tcmd| tcmd == arg).is_some()` with `any(|&tcmd| tcmd == arg)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:165:14 [INFO] [stderr] | [INFO] [stderr] 165 | .expect(&format!("Failed to execute command '{}'", &git_cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to execute command '{}'", &git_cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | .expect(&format!("Failed to wait for git call '{}'", &git_cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to wait for git call '{}'", &git_cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | .expect(&format!("Failed to execute command '{}'", &git_cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to execute command '{}'", &git_cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.36s [INFO] running `"docker" "inspect" "7ce53c284ddda340911f483866c364340d0e00eb88f729835b8bebcf433cce13"` [INFO] running `"docker" "rm" "-f" "7ce53c284ddda340911f483866c364340d0e00eb88f729835b8bebcf433cce13"` [INFO] [stdout] 7ce53c284ddda340911f483866c364340d0e00eb88f729835b8bebcf433cce13