[INFO] updating cached repository andrewvy/ray-tracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andrewvy/ray-tracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andrewvy/ray-tracer" "work/ex/clippy-test-run/sources/stable/gh/andrewvy/ray-tracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrewvy/ray-tracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andrewvy/ray-tracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewvy/ray-tracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewvy/ray-tracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fbd1f7f533097fe8885fd31be78bb60315a198ce [INFO] sha for GitHub repo andrewvy/ray-tracer: fbd1f7f533097fe8885fd31be78bb60315a198ce [INFO] validating manifest of andrewvy/ray-tracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andrewvy/ray-tracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andrewvy/ray-tracer [INFO] finished frobbing andrewvy/ray-tracer [INFO] frobbed toml for andrewvy/ray-tracer written to work/ex/clippy-test-run/sources/stable/gh/andrewvy/ray-tracer/Cargo.toml [INFO] started frobbing andrewvy/ray-tracer [INFO] finished frobbing andrewvy/ray-tracer [INFO] frobbed toml for andrewvy/ray-tracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewvy/ray-tracer/Cargo.toml [INFO] crate andrewvy/ray-tracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andrewvy/ray-tracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrewvy/ray-tracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0cdbc9c39289676ad5b4f06d13a182b4a5b1d789fe8122a1b70af34c86e211fe [INFO] running `"docker" "start" "-a" "0cdbc9c39289676ad5b4f06d13a182b4a5b1d789fe8122a1b70af34c86e211fe"` [INFO] [stderr] Compiling proc-macro2 v0.4.5 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking ray_tracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | direction: direction [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | p1: p1, [INFO] [stderr] | ^^^^^^ help: replace it with: `p1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | p2: p2, [INFO] [stderr] | ^^^^^^ help: replace it with: `p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | p3: p3, [INFO] [stderr] | ^^^^^^ help: replace it with: `p3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | direction: direction [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | p1: p1, [INFO] [stderr] | ^^^^^^ help: replace it with: `p1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | p2: p2, [INFO] [stderr] | ^^^^^^ help: replace it with: `p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | p3: p3, [INFO] [stderr] | ^^^^^^ help: replace it with: `p3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return point; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return Vec3::new(5.0, 5.0, 3.0).mul_vec3(&attenuation); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(5.0, 5.0, 3.0).mul_vec3(&attenuation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return attenuation.mul_vec3(&sky); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `attenuation.mul_vec3(&sky)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return point; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return Vec3::new(5.0, 5.0, 3.0).mul_vec3(&attenuation); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(5.0, 5.0, 3.0).mul_vec3(&attenuation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return attenuation.mul_vec3(&sky); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `attenuation.mul_vec3(&sky)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `x` [INFO] [stderr] --> src/vec.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn x(&self) -> f64 { self.p1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `z` [INFO] [stderr] --> src/vec.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn z(&self) -> f64 { self.p3 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `r` [INFO] [stderr] --> src/vec.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn r(&self) -> f64 { self.p1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `g` [INFO] [stderr] --> src/vec.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn g(&self) -> f64 { self.p2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `b` [INFO] [stderr] --> src/vec.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn b(&self) -> f64 { self.p3 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cross` [INFO] [stderr] --> src/vec.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn cross(&self, v2: &Vec3) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/model.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn new(center: Vec3, radius: f64) -> Sphere { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:52:32 [INFO] [stderr] | [INFO] [stderr] 52 | point: point.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | fn color_from_ray(mut ray: Ray, scene: &Box) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&Model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | let u: f64 = (x as f64 + rand::random::()) / width as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:71 [INFO] [stderr] | [INFO] [stderr] 102 | let u: f64 = (x as f64 + rand::random::()) / width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:103:35 [INFO] [stderr] | [INFO] [stderr] 103 | let v: f64 = (j as f64 + rand::random::()) / height as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:103:71 [INFO] [stderr] | [INFO] [stderr] 103 | let v: f64 = (j as f64 + rand::random::()) / height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | .div_t(number_of_samples as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(number_of_samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method is never used: `x` [INFO] [stderr] --> src/vec.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn x(&self) -> f64 { self.p1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `z` [INFO] [stderr] --> src/vec.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn z(&self) -> f64 { self.p3 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `r` [INFO] [stderr] --> src/vec.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn r(&self) -> f64 { self.p1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `g` [INFO] [stderr] --> src/vec.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn g(&self) -> f64 { self.p2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `b` [INFO] [stderr] --> src/vec.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn b(&self) -> f64 { self.p3 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cross` [INFO] [stderr] --> src/vec.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn cross(&self, v2: &Vec3) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/model.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn new(center: Vec3, radius: f64) -> Sphere { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:52:32 [INFO] [stderr] | [INFO] [stderr] 52 | point: point.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | fn color_from_ray(mut ray: Ray, scene: &Box) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&Model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | let u: f64 = (x as f64 + rand::random::()) / width as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:71 [INFO] [stderr] | [INFO] [stderr] 102 | let u: f64 = (x as f64 + rand::random::()) / width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:103:35 [INFO] [stderr] | [INFO] [stderr] 103 | let v: f64 = (j as f64 + rand::random::()) / height as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:103:71 [INFO] [stderr] | [INFO] [stderr] 103 | let v: f64 = (j as f64 + rand::random::()) / height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | .div_t(number_of_samples as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(number_of_samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.03s [INFO] running `"docker" "inspect" "0cdbc9c39289676ad5b4f06d13a182b4a5b1d789fe8122a1b70af34c86e211fe"` [INFO] running `"docker" "rm" "-f" "0cdbc9c39289676ad5b4f06d13a182b4a5b1d789fe8122a1b70af34c86e211fe"` [INFO] [stdout] 0cdbc9c39289676ad5b4f06d13a182b4a5b1d789fe8122a1b70af34c86e211fe