[INFO] updating cached repository andrewnester/rust-jsonm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andrewnester/rust-jsonm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andrewnester/rust-jsonm" "work/ex/clippy-test-run/sources/stable/gh/andrewnester/rust-jsonm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrewnester/rust-jsonm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andrewnester/rust-jsonm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewnester/rust-jsonm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewnester/rust-jsonm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1da554fb05b298bc629474e1165d89d0c024021c [INFO] sha for GitHub repo andrewnester/rust-jsonm: 1da554fb05b298bc629474e1165d89d0c024021c [INFO] validating manifest of andrewnester/rust-jsonm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andrewnester/rust-jsonm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andrewnester/rust-jsonm [INFO] finished frobbing andrewnester/rust-jsonm [INFO] frobbed toml for andrewnester/rust-jsonm written to work/ex/clippy-test-run/sources/stable/gh/andrewnester/rust-jsonm/Cargo.toml [INFO] started frobbing andrewnester/rust-jsonm [INFO] finished frobbing andrewnester/rust-jsonm [INFO] frobbed toml for andrewnester/rust-jsonm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewnester/rust-jsonm/Cargo.toml [INFO] crate andrewnester/rust-jsonm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andrewnester/rust-jsonm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrewnester/rust-jsonm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9d948bc7d0aea9a053f52aada53925f0492ab31d59eaea2b0e8dbfad5899deb7 [INFO] running `"docker" "start" "-a" "9d948bc7d0aea9a053f52aada53925f0492ab31d59eaea2b0e8dbfad5899deb7"` [INFO] [stderr] Checking serde_json v1.0.24 [INFO] [stderr] Checking jsonm v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packer.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(json!(vec)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(json!(vec))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packer.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(json!(vec)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(json!(vec))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `packer::PackOptions` [INFO] [stderr] --> src/packer.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> PackOptions { [INFO] [stderr] 25 | | PackOptions { [INFO] [stderr] 26 | | pack_string_depth: -1, [INFO] [stderr] 27 | | no_sequence_id: false, [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/packer.rs:248:38 [INFO] [stderr] | [INFO] [stderr] 248 | fn pack_array(&mut self, object: &Vec, pack_string_depth: i32) -> Value { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/unpacker.rs:189:28 [INFO] [stderr] | [INFO] [stderr] 189 | if acc.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/unpacker.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | / let mut value = string; [INFO] [stderr] 300 | | if string.len() > 0 && &string[0..1] == "~" { [INFO] [stderr] 301 | | value = &string[1..]; [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let value = if string.len() > 0 && &string[0..1] == "~" { &string[1..] } else { string };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/unpacker.rs:300:16 [INFO] [stderr] | [INFO] [stderr] 300 | if string.len() > 0 && &string[0..1] == "~" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `packer::PackOptions` [INFO] [stderr] --> src/packer.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> PackOptions { [INFO] [stderr] 25 | | PackOptions { [INFO] [stderr] 26 | | pack_string_depth: -1, [INFO] [stderr] 27 | | no_sequence_id: false, [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/packer.rs:248:38 [INFO] [stderr] | [INFO] [stderr] 248 | fn pack_array(&mut self, object: &Vec, pack_string_depth: i32) -> Value { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/unpacker.rs:189:28 [INFO] [stderr] | [INFO] [stderr] 189 | if acc.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/unpacker.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | / let mut value = string; [INFO] [stderr] 300 | | if string.len() > 0 && &string[0..1] == "~" { [INFO] [stderr] 301 | | value = &string[1..]; [INFO] [stderr] 302 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let value = if string.len() > 0 && &string[0..1] == "~" { &string[1..] } else { string };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/unpacker.rs:300:16 [INFO] [stderr] | [INFO] [stderr] 300 | if string.len() > 0 && &string[0..1] == "~" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.52s [INFO] running `"docker" "inspect" "9d948bc7d0aea9a053f52aada53925f0492ab31d59eaea2b0e8dbfad5899deb7"` [INFO] running `"docker" "rm" "-f" "9d948bc7d0aea9a053f52aada53925f0492ab31d59eaea2b0e8dbfad5899deb7"` [INFO] [stdout] 9d948bc7d0aea9a053f52aada53925f0492ab31d59eaea2b0e8dbfad5899deb7