[INFO] updating cached repository andrewjlm/rustrenderer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andrewjlm/rustrenderer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andrewjlm/rustrenderer" "work/ex/clippy-test-run/sources/stable/gh/andrewjlm/rustrenderer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrewjlm/rustrenderer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andrewjlm/rustrenderer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewjlm/rustrenderer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewjlm/rustrenderer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b38420b59a2be80cdb61ba20dd5317b6f2c65528 [INFO] sha for GitHub repo andrewjlm/rustrenderer: b38420b59a2be80cdb61ba20dd5317b6f2c65528 [INFO] validating manifest of andrewjlm/rustrenderer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andrewjlm/rustrenderer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andrewjlm/rustrenderer [INFO] finished frobbing andrewjlm/rustrenderer [INFO] frobbed toml for andrewjlm/rustrenderer written to work/ex/clippy-test-run/sources/stable/gh/andrewjlm/rustrenderer/Cargo.toml [INFO] started frobbing andrewjlm/rustrenderer [INFO] finished frobbing andrewjlm/rustrenderer [INFO] frobbed toml for andrewjlm/rustrenderer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewjlm/rustrenderer/Cargo.toml [INFO] crate andrewjlm/rustrenderer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andrewjlm/rustrenderer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrewjlm/rustrenderer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da33e940639770b39e6972eeb235ae0fce6a810bb64864e1bc8a2d7e1d075f1d [INFO] running `"docker" "start" "-a" "da33e940639770b39e6972eeb235ae0fce6a810bb64864e1bc8a2d7e1d075f1d"` [INFO] [stderr] Checking rustrender v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | z: z, [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | coords: coords, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | coords: coords, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | vertices: vertices [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:276:34 [INFO] [stderr] | [INFO] [stderr] 276 | let p = Vec2{x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:276:40 [INFO] [stderr] | [INFO] [stderr] 276 | let p = Vec2{x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | z: z, [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | coords: coords, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | coords: coords, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | vertices: vertices [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:276:34 [INFO] [stderr] | [INFO] [stderr] 276 | let p = Vec2{x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:276:40 [INFO] [stderr] | [INFO] [stderr] 276 | let p = Vec2{x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/tga.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | let num_bytes = (height * width * bytes_per_pixel); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/tga.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | let num_bytes = (height * width * bytes_per_pixel); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/geo.rs:269:47 [INFO] [stderr] | [INFO] [stderr] 269 | pub fn draw(&self, mut image: &mut Image, color: Color, texture: &Image) { [INFO] [stderr] | ^^^^^ help: consider using `_color` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/geo.rs:269:47 [INFO] [stderr] | [INFO] [stderr] 269 | pub fn draw(&self, mut image: &mut Image, color: Color, texture: &Image) { [INFO] [stderr] | ^^^^^ help: consider using `_color` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/geo.rs:269:24 [INFO] [stderr] | [INFO] [stderr] 269 | pub fn draw(&self, mut image: &mut Image, color: Color, texture: &Image) { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/geo.rs:269:24 [INFO] [stderr] | [INFO] [stderr] 269 | pub fn draw(&self, mut image: &mut Image, color: Color, texture: &Image) { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `WHITE` [INFO] [stderr] --> src/image.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub const WHITE: Color = Color(255, 255, 255); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RED` [INFO] [stderr] --> src/image.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub const RED: Color = Color(0, 0, 255); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/image.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub const GREEN: Color = Color(0, 255, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLUE` [INFO] [stderr] --> src/image.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub const BLUE: Color = Color(255, 0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `line` [INFO] [stderr] --> src/image.rs:121:1 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn line(point1: Vec2, point2: Vec2, image: &mut Image, color: Color) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(x: T, y: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_f64` [INFO] [stderr] --> src/geo.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn to_f64(self) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn new(x: T, y: T, z: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_i32` [INFO] [stderr] --> src/geo.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn to_i32(self) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn new(coords: Vec3) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `barycentric` [INFO] [stderr] --> src/geo.rs:347:1 [INFO] [stderr] | [INFO] [stderr] 347 | pub fn barycentric(t0: &Vec3, t1: &Vec3, p: &Vec3) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_color` [INFO] [stderr] --> src/tga.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn is_color(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_color_mapped` [INFO] [stderr] --> src/tga.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | fn is_color_mapped(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_encoded` [INFO] [stderr] --> src/tga.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | fn is_encoded(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/image.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | let data_ptr: *const u8 = mem::transmute(s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `s as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/image.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | let data_ptr: *const u8 = mem::transmute(&s[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&s[0] as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:132:28 [INFO] [stderr] | [INFO] [stderr] 132 | let (x0, y0, x1, y1) = match steep { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 133 | | true => { (y0, x0, y1, x1) }, [INFO] [stderr] 134 | | false => { (x0, y0, x1, y1) } [INFO] [stderr] 135 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if steep { (y0, x0, y1, x1) } else { (x0, y0, x1, y1) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:138:28 [INFO] [stderr] | [INFO] [stderr] 138 | let (x0, y0, x1, y1) = match x0 > x1 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 139 | | true => { (x1, y1, x0, y0) }, [INFO] [stderr] 140 | | false => { (x0, y0, x1, y1) } [INFO] [stderr] 141 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if x0 > x1 { (x1, y1, x0, y0) } else { (x0, y0, x1, y1) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / match steep { [INFO] [stderr] 155 | | true => { [INFO] [stderr] 156 | | image.set_pixel(y as i32, x as i32, color); [INFO] [stderr] 157 | | }, [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 154 | if steep { [INFO] [stderr] 155 | image.set_pixel(y as i32, x as i32, color); [INFO] [stderr] 156 | } else { [INFO] [stderr] 157 | image.set_pixel(x as i32, y as i32, color); [INFO] [stderr] 158 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | y = match error > dx { [INFO] [stderr] | _____________^ [INFO] [stderr] 167 | | true => { [INFO] [stderr] 168 | | error -= dx * 2.0; [INFO] [stderr] 169 | | match y1 > y0 { [INFO] [stderr] ... | [INFO] [stderr] 174 | | false => { y } [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 166 | y = if error > dx { [INFO] [stderr] 167 | error -= dx * 2.0; [INFO] [stderr] 168 | match y1 > y0 { [INFO] [stderr] 169 | true => { y + 1.0 }, [INFO] [stderr] 170 | false => { y - 1.0 } [INFO] [stderr] 171 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | / match y1 > y0 { [INFO] [stderr] 170 | | true => { y + 1.0 }, [INFO] [stderr] 171 | | false => { y - 1.0 } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if y1 > y0 { y + 1.0 } else { y - 1.0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/image.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | x = x + 1.0; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x += 1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `WHITE` [INFO] [stderr] --> src/image.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub const WHITE: Color = Color(255, 255, 255); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RED` [INFO] [stderr] --> src/image.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub const RED: Color = Color(0, 0, 255); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/image.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub const GREEN: Color = Color(0, 255, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLUE` [INFO] [stderr] --> src/image.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub const BLUE: Color = Color(255, 0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `line` [INFO] [stderr] --> src/image.rs:121:1 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn line(point1: Vec2, point2: Vec2, image: &mut Image, color: Color) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(x: T, y: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_f64` [INFO] [stderr] --> src/geo.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn to_f64(self) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn new(x: T, y: T, z: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_i32` [INFO] [stderr] --> src/geo.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn to_i32(self) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/geo.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn new(coords: Vec3) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `barycentric` [INFO] [stderr] --> src/geo.rs:347:1 [INFO] [stderr] | [INFO] [stderr] 347 | pub fn barycentric(t0: &Vec3, t1: &Vec3, p: &Vec3) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_color` [INFO] [stderr] --> src/tga.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn is_color(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_color_mapped` [INFO] [stderr] --> src/tga.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | fn is_color_mapped(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_encoded` [INFO] [stderr] --> src/tga.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | fn is_encoded(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/image.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | let data_ptr: *const u8 = mem::transmute(s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `s as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/image.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | let data_ptr: *const u8 = mem::transmute(&s[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&s[0] as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:132:28 [INFO] [stderr] | [INFO] [stderr] 132 | let (x0, y0, x1, y1) = match steep { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 133 | | true => { (y0, x0, y1, x1) }, [INFO] [stderr] 134 | | false => { (x0, y0, x1, y1) } [INFO] [stderr] 135 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if steep { (y0, x0, y1, x1) } else { (x0, y0, x1, y1) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:138:28 [INFO] [stderr] | [INFO] [stderr] 138 | let (x0, y0, x1, y1) = match x0 > x1 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 139 | | true => { (x1, y1, x0, y0) }, [INFO] [stderr] 140 | | false => { (x0, y0, x1, y1) } [INFO] [stderr] 141 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if x0 > x1 { (x1, y1, x0, y0) } else { (x0, y0, x1, y1) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / match steep { [INFO] [stderr] 155 | | true => { [INFO] [stderr] 156 | | image.set_pixel(y as i32, x as i32, color); [INFO] [stderr] 157 | | }, [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 154 | if steep { [INFO] [stderr] 155 | image.set_pixel(y as i32, x as i32, color); [INFO] [stderr] 156 | } else { [INFO] [stderr] 157 | image.set_pixel(x as i32, y as i32, color); [INFO] [stderr] 158 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | y = match error > dx { [INFO] [stderr] | _____________^ [INFO] [stderr] 167 | | true => { [INFO] [stderr] 168 | | error -= dx * 2.0; [INFO] [stderr] 169 | | match y1 > y0 { [INFO] [stderr] ... | [INFO] [stderr] 174 | | false => { y } [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 166 | y = if error > dx { [INFO] [stderr] 167 | error -= dx * 2.0; [INFO] [stderr] 168 | match y1 > y0 { [INFO] [stderr] 169 | true => { y + 1.0 }, [INFO] [stderr] 170 | false => { y - 1.0 } [INFO] [stderr] 171 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/image.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | / match y1 > y0 { [INFO] [stderr] 170 | | true => { y + 1.0 }, [INFO] [stderr] 171 | | false => { y - 1.0 } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if y1 > y0 { y + 1.0 } else { y - 1.0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/image.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | x = x + 1.0; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `x += 1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:220:58 [INFO] [stderr] | [INFO] [stderr] 220 | let new_coords = Vec3{x: (self.coords.x + 1.0) * (width as f64) / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:221:58 [INFO] [stderr] | [INFO] [stderr] 221 | y: (self.coords.y + 1.0) * (height as f64) / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:232:63 [INFO] [stderr] | [INFO] [stderr] 232 | let new_coords = Vec2{x: ((self.texture.unwrap().x) * (width as f64)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:233:62 [INFO] [stderr] | [INFO] [stderr] 233 | y: (self.texture.unwrap().y) * (height as f64)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geo.rs:355:28 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn new_barycentric(t0: &Vec2, t1: &Vec2, t2: &Vec2, p: &Vec2) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Vec2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geo.rs:355:44 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn new_barycentric(t0: &Vec2, t1: &Vec2, t2: &Vec2, p: &Vec2) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Vec2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geo.rs:355:60 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn new_barycentric(t0: &Vec2, t1: &Vec2, t2: &Vec2, p: &Vec2) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Vec2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geo.rs:355:75 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn new_barycentric(t0: &Vec2, t1: &Vec2, t2: &Vec2, p: &Vec2) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Vec2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:358:16 [INFO] [stderr] | [INFO] [stderr] 358 | x: (t2.x - t0.x) as f64, y: (t1.x - t0.x) as f64, z: (t0.x - p.x) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t2.x - t0.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:358:41 [INFO] [stderr] | [INFO] [stderr] 358 | x: (t2.x - t0.x) as f64, y: (t1.x - t0.x) as f64, z: (t0.x - p.x) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t1.x - t0.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:358:66 [INFO] [stderr] | [INFO] [stderr] 358 | x: (t2.x - t0.x) as f64, y: (t1.x - t0.x) as f64, z: (t0.x - p.x) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t0.x - p.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:361:16 [INFO] [stderr] | [INFO] [stderr] 361 | x: (t2.y - t0.y) as f64, y: (t1.y - t0.y) as f64, z: (t0.y - p.y) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t2.y - t0.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:361:41 [INFO] [stderr] | [INFO] [stderr] 361 | x: (t2.y - t0.y) as f64, y: (t1.y - t0.y) as f64, z: (t0.y - p.y) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t1.y - t0.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:361:66 [INFO] [stderr] | [INFO] [stderr] 361 | x: (t2.y - t0.y) as f64, y: (t1.y - t0.y) as f64, z: (t0.y - p.y) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t0.y - p.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:220:58 [INFO] [stderr] | [INFO] [stderr] 220 | let new_coords = Vec3{x: (self.coords.x + 1.0) * (width as f64) / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:221:58 [INFO] [stderr] | [INFO] [stderr] 221 | y: (self.coords.y + 1.0) * (height as f64) / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:232:63 [INFO] [stderr] | [INFO] [stderr] 232 | let new_coords = Vec2{x: ((self.texture.unwrap().x) * (width as f64)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:233:62 [INFO] [stderr] | [INFO] [stderr] 233 | y: (self.texture.unwrap().y) * (height as f64)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geo.rs:355:28 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn new_barycentric(t0: &Vec2, t1: &Vec2, t2: &Vec2, p: &Vec2) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Vec2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geo.rs:355:44 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn new_barycentric(t0: &Vec2, t1: &Vec2, t2: &Vec2, p: &Vec2) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Vec2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geo.rs:355:60 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn new_barycentric(t0: &Vec2, t1: &Vec2, t2: &Vec2, p: &Vec2) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Vec2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geo.rs:355:75 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn new_barycentric(t0: &Vec2, t1: &Vec2, t2: &Vec2, p: &Vec2) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Vec2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:358:16 [INFO] [stderr] | [INFO] [stderr] 358 | x: (t2.x - t0.x) as f64, y: (t1.x - t0.x) as f64, z: (t0.x - p.x) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t2.x - t0.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:358:41 [INFO] [stderr] | [INFO] [stderr] 358 | x: (t2.x - t0.x) as f64, y: (t1.x - t0.x) as f64, z: (t0.x - p.x) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t1.x - t0.x)` [INFO] [stderr] | [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/tga.rs:121:42 [INFO] [stderr] | [INFO] [stderr] 121 | image_buf.extend(data.iter().map(|&c| c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `data.iter().cloned()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:358:66 [INFO] [stderr] | [INFO] [stderr] 358 | x: (t2.x - t0.x) as f64, y: (t1.x - t0.x) as f64, z: (t0.x - p.x) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t0.x - p.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:361:16 [INFO] [stderr] | [INFO] [stderr] 361 | x: (t2.y - t0.y) as f64, y: (t1.y - t0.y) as f64, z: (t0.y - p.y) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t2.y - t0.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:361:41 [INFO] [stderr] | [INFO] [stderr] 361 | x: (t2.y - t0.y) as f64, y: (t1.y - t0.y) as f64, z: (t0.y - p.y) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t1.y - t0.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:361:66 [INFO] [stderr] | [INFO] [stderr] 361 | x: (t2.y - t0.y) as f64, y: (t1.y - t0.y) as f64, z: (t0.y - p.y) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t0.y - p.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | image.write_tga_file("output.tga"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/tga.rs:121:42 [INFO] [stderr] | [INFO] [stderr] 121 | image_buf.extend(data.iter().map(|&c| c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `data.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | image.write_tga_file("output.tga"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.60s [INFO] running `"docker" "inspect" "da33e940639770b39e6972eeb235ae0fce6a810bb64864e1bc8a2d7e1d075f1d"` [INFO] running `"docker" "rm" "-f" "da33e940639770b39e6972eeb235ae0fce6a810bb64864e1bc8a2d7e1d075f1d"` [INFO] [stdout] da33e940639770b39e6972eeb235ae0fce6a810bb64864e1bc8a2d7e1d075f1d