[INFO] updating cached repository andrewhu-uw/RustSystemsTest [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andrewhu-uw/RustSystemsTest [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andrewhu-uw/RustSystemsTest" "work/ex/clippy-test-run/sources/stable/gh/andrewhu-uw/RustSystemsTest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrewhu-uw/RustSystemsTest'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andrewhu-uw/RustSystemsTest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewhu-uw/RustSystemsTest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewhu-uw/RustSystemsTest'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2081b576d5d18ffb583c8e3b925a94979981809f [INFO] sha for GitHub repo andrewhu-uw/RustSystemsTest: 2081b576d5d18ffb583c8e3b925a94979981809f [INFO] validating manifest of andrewhu-uw/RustSystemsTest on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andrewhu-uw/RustSystemsTest on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andrewhu-uw/RustSystemsTest [INFO] finished frobbing andrewhu-uw/RustSystemsTest [INFO] frobbed toml for andrewhu-uw/RustSystemsTest written to work/ex/clippy-test-run/sources/stable/gh/andrewhu-uw/RustSystemsTest/Cargo.toml [INFO] started frobbing andrewhu-uw/RustSystemsTest [INFO] finished frobbing andrewhu-uw/RustSystemsTest [INFO] frobbed toml for andrewhu-uw/RustSystemsTest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewhu-uw/RustSystemsTest/Cargo.toml [INFO] crate andrewhu-uw/RustSystemsTest has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andrewhu-uw/RustSystemsTest against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrewhu-uw/RustSystemsTest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b23a2907963634b818bfef09f8d37e8ef5045a8bb105307db6938589fc3f1597 [INFO] running `"docker" "start" "-a" "b23a2907963634b818bfef09f8d37e8ef5045a8bb105307db6938589fc3f1597"` [INFO] [stderr] Checking rs333 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:45:69 [INFO] [stderr] | [INFO] [stderr] 45 | fn do_work(wordmap : &mut HashMap, filename: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | / match file.read_to_string(&mut contents) { [INFO] [stderr] 109 | | Err(why) => panic!("Couldn't open {}: {}", path.display(), [INFO] [stderr] 110 | | why.description()), [INFO] [stderr] 111 | | Ok(_) => {}, [INFO] [stderr] 112 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | if let Err(why) = file.read_to_string(&mut contents) { panic!("Couldn't open {}: {}", path.display(), [INFO] [stderr] 109 | why.description()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:45:69 [INFO] [stderr] | [INFO] [stderr] 45 | fn do_work(wordmap : &mut HashMap, filename: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | / match file.read_to_string(&mut contents) { [INFO] [stderr] 109 | | Err(why) => panic!("Couldn't open {}: {}", path.display(), [INFO] [stderr] 110 | | why.description()), [INFO] [stderr] 111 | | Ok(_) => {}, [INFO] [stderr] 112 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | if let Err(why) = file.read_to_string(&mut contents) { panic!("Couldn't open {}: {}", path.display(), [INFO] [stderr] 109 | why.description()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "b23a2907963634b818bfef09f8d37e8ef5045a8bb105307db6938589fc3f1597"` [INFO] running `"docker" "rm" "-f" "b23a2907963634b818bfef09f8d37e8ef5045a8bb105307db6938589fc3f1597"` [INFO] [stdout] b23a2907963634b818bfef09f8d37e8ef5045a8bb105307db6938589fc3f1597