[INFO] updating cached repository andrewhickman/lang [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andrewhickman/lang [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andrewhickman/lang" "work/ex/clippy-test-run/sources/stable/gh/andrewhickman/lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrewhickman/lang'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andrewhickman/lang" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewhickman/lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewhickman/lang'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1eb85f252469b27eed2eece9e66c9ff7d2197d41 [INFO] sha for GitHub repo andrewhickman/lang: 1eb85f252469b27eed2eece9e66c9ff7d2197d41 [INFO] validating manifest of andrewhickman/lang on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andrewhickman/lang on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andrewhickman/lang [INFO] finished frobbing andrewhickman/lang [INFO] frobbed toml for andrewhickman/lang written to work/ex/clippy-test-run/sources/stable/gh/andrewhickman/lang/Cargo.toml [INFO] started frobbing andrewhickman/lang [INFO] finished frobbing andrewhickman/lang [INFO] frobbed toml for andrewhickman/lang written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewhickman/lang/Cargo.toml [INFO] crate andrewhickman/lang has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andrewhickman/lang against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrewhickman/lang:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e2ca96f10a8ea77fef98e64e8a1251e48096c9cd5ff5add2c4bd8ca0372ead8a [INFO] running `"docker" "start" "-a" "e2ca96f10a8ea77fef98e64e8a1251e48096c9cd5ff5add2c4bd8ca0372ead8a"` [INFO] [stderr] Checking lang v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | '+' => if self.eat('=') { PlusEq } else [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 67 | | if self.eat('+') { PlusPlus } else { Plus }, [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:68:48 [INFO] [stderr] | [INFO] [stderr] 68 | '-' => if self.eat('=') { MinusEq } else [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 69 | | if self.eat('-') { MinusMinus } else [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:69:51 [INFO] [stderr] | [INFO] [stderr] 69 | if self.eat('-') { MinusMinus } else [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 70 | | if self.eat('>') { Arrow } else { Minus }, [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:71:46 [INFO] [stderr] | [INFO] [stderr] 71 | '&' => if self.eat('=') { AndEq } else [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 72 | | if self.eat('&') { AndAnd } else { And }, [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:73:45 [INFO] [stderr] | [INFO] [stderr] 73 | '|' => if self.eat('=') { OrEq } else [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 74 | | if self.eat('|') { OrOr } else { Or }, [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:85:43 [INFO] [stderr] | [INFO] [stderr] 85 | '<' => if self.eat('=') { Le } else [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 86 | | if self.eat('<') { [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:89:43 [INFO] [stderr] | [INFO] [stderr] 89 | '>' => if self.eat('=') { Ge } else [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 90 | | if self.eat('>') { [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | '+' => if self.eat('=') { PlusEq } else [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 67 | | if self.eat('+') { PlusPlus } else { Plus }, [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:68:48 [INFO] [stderr] | [INFO] [stderr] 68 | '-' => if self.eat('=') { MinusEq } else [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 69 | | if self.eat('-') { MinusMinus } else [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:69:51 [INFO] [stderr] | [INFO] [stderr] 69 | if self.eat('-') { MinusMinus } else [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 70 | | if self.eat('>') { Arrow } else { Minus }, [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:71:46 [INFO] [stderr] | [INFO] [stderr] 71 | '&' => if self.eat('=') { AndEq } else [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 72 | | if self.eat('&') { AndAnd } else { And }, [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:73:45 [INFO] [stderr] | [INFO] [stderr] 73 | '|' => if self.eat('=') { OrEq } else [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 74 | | if self.eat('|') { OrOr } else { Or }, [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:85:43 [INFO] [stderr] | [INFO] [stderr] 85 | '<' => if self.eat('=') { Le } else [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 86 | | if self.eat('<') { [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/syntax/lex/mod.rs:89:43 [INFO] [stderr] | [INFO] [stderr] 89 | '>' => if self.eat('=') { Ge } else [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 90 | | if self.eat('>') { [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ast/print.rs:127:35 [INFO] [stderr] | [INFO] [stderr] 127 | let mut tys = tys.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ast/print.rs:138:35 [INFO] [stderr] | [INFO] [stderr] 138 | let mut tys = tys.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/syntax/lex/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / fn next(&mut self) -> Self::Item { [INFO] [stderr] 42 | | use self::Token::*; [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | self.eat_while(char::is_whitespace); [INFO] [stderr] ... | [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/syntax/parse/error.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn err<'src, E: fmt::Display, T>(expected: E, found: Token<'src>) -> Result> { [INFO] [stderr] 21 | | Err(Error::new(expected, found)) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ast/print.rs:127:35 [INFO] [stderr] | [INFO] [stderr] 127 | let mut tys = tys.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ast/print.rs:138:35 [INFO] [stderr] | [INFO] [stderr] 138 | let mut tys = tys.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/syntax/lex/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / fn next(&mut self) -> Self::Item { [INFO] [stderr] 42 | | use self::Token::*; [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | self.eat_while(char::is_whitespace); [INFO] [stderr] ... | [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 53 [INFO] [stderr] --> src/syntax/lex/mod.rs:103:1 [INFO] [stderr] | [INFO] [stderr] 103 | / fn test_lexer() { [INFO] [stderr] 104 | | use super::Token::*; [INFO] [stderr] 105 | | [INFO] [stderr] 106 | | let mut lexer = Lexer::new("abc ᚠᛇᚻ Laȝamon γλῶσσα ಸಂಭವಿಸು 123 * / % + - >> << <= < >= > == != [INFO] [stderr] ... | [INFO] [stderr] 160 | | assert_eq!(lexer.next(), Eof); [INFO] [stderr] 161 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/syntax/parse/error.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn err<'src, E: fmt::Display, T>(expected: E, found: Token<'src>) -> Result> { [INFO] [stderr] 21 | | Err(Error::new(expected, found)) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.93s [INFO] running `"docker" "inspect" "e2ca96f10a8ea77fef98e64e8a1251e48096c9cd5ff5add2c4bd8ca0372ead8a"` [INFO] running `"docker" "rm" "-f" "e2ca96f10a8ea77fef98e64e8a1251e48096c9cd5ff5add2c4bd8ca0372ead8a"` [INFO] [stdout] e2ca96f10a8ea77fef98e64e8a1251e48096c9cd5ff5add2c4bd8ca0372ead8a