[INFO] updating cached repository andrewayoub/dmidecoder
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/andrewayoub/dmidecoder
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/andrewayoub/dmidecoder" "work/ex/clippy-test-run/sources/stable/gh/andrewayoub/dmidecoder"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrewayoub/dmidecoder'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/andrewayoub/dmidecoder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewayoub/dmidecoder"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewayoub/dmidecoder'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 850fb8a2304249000bb985419f19eb28fa1d4030
[INFO] sha for GitHub repo andrewayoub/dmidecoder: 850fb8a2304249000bb985419f19eb28fa1d4030
[INFO] validating manifest of andrewayoub/dmidecoder on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of andrewayoub/dmidecoder on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing andrewayoub/dmidecoder
[INFO] finished frobbing andrewayoub/dmidecoder
[INFO] frobbed toml for andrewayoub/dmidecoder written to work/ex/clippy-test-run/sources/stable/gh/andrewayoub/dmidecoder/Cargo.toml
[INFO] started frobbing andrewayoub/dmidecoder
[INFO] finished frobbing andrewayoub/dmidecoder
[INFO] frobbed toml for andrewayoub/dmidecoder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewayoub/dmidecoder/Cargo.toml
[INFO] crate andrewayoub/dmidecoder has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting andrewayoub/dmidecoder against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrewayoub/dmidecoder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8a96f2932103d7774b98460878eadea82840b0e4019d625f1c798fb23c7a373f
[INFO] running `"docker" "start" "-a" "8a96f2932103d7774b98460878eadea82840b0e4019d625f1c798fb23c7a373f"`
[INFO] [stderr]     Checking dmidecoder v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             return self.value.is_empty() && self.items.is_empty()
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value.is_empty() && self.items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             return self.handle_line.is_empty() && self.properties.is_empty()
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.handle_line.is_empty() && self.properties.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return String::from(line.to_string())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(line.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         return count;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `count`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         return new_state;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_state`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:169:9
[INFO] [stderr]     |
[INFO] [stderr] 169 |         return sections;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sections`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dmidecoder::Property`
[INFO] [stderr]   --> src/lib.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 | /         pub fn new() -> Property {
[INFO] [stderr] 16 | |             Property {
[INFO] [stderr] 17 | |                 value: String::new(),
[INFO] [stderr] 18 | |                 items: Vec::new(),
[INFO] [stderr] 19 | |             }
[INFO] [stderr] 20 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  |     #[derive(Default)]
[INFO] [stderr] 9  |     pub struct Property {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lib.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 i = i + 1;
[INFO] [stderr]    |                 ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:66:16
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return String::from(line.to_string())
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lib.rs:73:17
[INFO] [stderr]    |
[INFO] [stderr] 73 |                 count = count + 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             return self.value.is_empty() && self.items.is_empty()
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value.is_empty() && self.items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             return self.handle_line.is_empty() && self.properties.is_empty()
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.handle_line.is_empty() && self.properties.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return String::from(line.to_string())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(line.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         return count;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `count`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         return new_state;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_state`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:169:9
[INFO] [stderr]     |
[INFO] [stderr] 169 |         return sections;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sections`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/tests.rs:2:1
[INFO] [stderr]    |
[INFO] [stderr] 2  | / mod tests {
[INFO] [stderr] 3  | |     use dmidecoder::parse;
[INFO] [stderr] 4  | |     #[test]
[INFO] [stderr] 5  | |     fn sampl1() {
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |     }
[INFO] [stderr] 61 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dmidecoder::Property`
[INFO] [stderr]   --> src/lib.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 | /         pub fn new() -> Property {
[INFO] [stderr] 16 | |             Property {
[INFO] [stderr] 17 | |                 value: String::new(),
[INFO] [stderr] 18 | |                 items: Vec::new(),
[INFO] [stderr] 19 | |             }
[INFO] [stderr] 20 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  |     #[derive(Default)]
[INFO] [stderr] 9  |     pub struct Property {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lib.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 i = i + 1;
[INFO] [stderr]    |                 ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:66:16
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return String::from(line.to_string())
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lib.rs:73:17
[INFO] [stderr]    |
[INFO] [stderr] 73 |                 count = count + 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.83s
[INFO] running `"docker" "inspect" "8a96f2932103d7774b98460878eadea82840b0e4019d625f1c798fb23c7a373f"`
[INFO] running `"docker" "rm" "-f" "8a96f2932103d7774b98460878eadea82840b0e4019d625f1c798fb23c7a373f"`
[INFO] [stdout] 8a96f2932103d7774b98460878eadea82840b0e4019d625f1c798fb23c7a373f