[INFO] updating cached repository andrewKyres/amphi
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/andrewKyres/amphi
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/andrewKyres/amphi" "work/ex/clippy-test-run/sources/stable/gh/andrewKyres/amphi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrewKyres/amphi'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/andrewKyres/amphi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewKyres/amphi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewKyres/amphi'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d96e041cea5015c0596258ae91c5c022b6689b28
[INFO] sha for GitHub repo andrewKyres/amphi: d96e041cea5015c0596258ae91c5c022b6689b28
[INFO] validating manifest of andrewKyres/amphi on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of andrewKyres/amphi on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing andrewKyres/amphi
[INFO] finished frobbing andrewKyres/amphi
[INFO] frobbed toml for andrewKyres/amphi written to work/ex/clippy-test-run/sources/stable/gh/andrewKyres/amphi/Cargo.toml
[INFO] started frobbing andrewKyres/amphi
[INFO] finished frobbing andrewKyres/amphi
[INFO] frobbed toml for andrewKyres/amphi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrewKyres/amphi/Cargo.toml
[INFO] crate andrewKyres/amphi has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting andrewKyres/amphi against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrewKyres/amphi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ac419e24d3d6b5df6dbf6ae201406ce818207b7dcdaf7d9cba712a51f887e5ed
[INFO] running `"docker" "start" "-a" "ac419e24d3d6b5df6dbf6ae201406ce818207b7dcdaf7d9cba712a51f887e5ed"`
[INFO] [stderr]     Checking amphi v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/instruction.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             opcode: opcode
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `opcode`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/instruction.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             opcode: opcode
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `opcode`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:152:9
[INFO] [stderr]     |
[INFO] [stderr] 152 |         return opcode;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `opcode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:159:9
[INFO] [stderr]     |
[INFO] [stderr] 159 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:152:9
[INFO] [stderr]     |
[INFO] [stderr] 152 |         return opcode;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `opcode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:159:9
[INFO] [stderr]     |
[INFO] [stderr] 159 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `vm`
[INFO] [stderr]   --> src/repl/mod.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     vm: VM,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM`
[INFO] [stderr]   --> src/vm.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> VM {
[INFO] [stderr] 21 | |         VM {
[INFO] [stderr] 22 | |             registers: [0; 32],
[INFO] [stderr] 23 | |             program: vec![],
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 5  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/vm.rs:52:30
[INFO] [stderr]    |
[INFO] [stderr] 52 |                 let number = self.next_16_bits() as u32;
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next_16_bits())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:163:22
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let result = (self.program[self.pc] as u16) << 8 | self.program[self.pc + 1] as u16;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:163:60
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let result = (self.program[self.pc] as u16) << 8 | self.program[self.pc + 1] as u16;
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `repl::REPL`
[INFO] [stderr]   --> src/repl/mod.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> REPL {
[INFO] [stderr] 17 | |         REPL {
[INFO] [stderr] 18 | |             vm: VM::new(),
[INFO] [stderr] 19 | |             command_buffer: vec![],
[INFO] [stderr] 20 | |         }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 | impl Default for repl::REPL {
[INFO] [stderr] 15 |     fn default() -> Self {
[INFO] [stderr] 16 |         Self::new()
[INFO] [stderr] 17 |     }
[INFO] [stderr] 18 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `vm`
[INFO] [stderr]   --> src/repl/mod.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     vm: VM,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM`
[INFO] [stderr]   --> src/vm.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     pub fn new() -> VM {
[INFO] [stderr] 21 | |         VM {
[INFO] [stderr] 22 | |             registers: [0; 32],
[INFO] [stderr] 23 | |             program: vec![],
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 5  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/vm.rs:52:30
[INFO] [stderr]    |
[INFO] [stderr] 52 |                 let number = self.next_16_bits() as u32;
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next_16_bits())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:163:22
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let result = (self.program[self.pc] as u16) << 8 | self.program[self.pc + 1] as u16;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:163:60
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let result = (self.program[self.pc] as u16) << 8 | self.program[self.pc + 1] as u16;
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `repl::REPL`
[INFO] [stderr]   --> src/repl/mod.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> REPL {
[INFO] [stderr] 17 | |         REPL {
[INFO] [stderr] 18 | |             vm: VM::new(),
[INFO] [stderr] 19 | |             command_buffer: vec![],
[INFO] [stderr] 20 | |         }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 | impl Default for repl::REPL {
[INFO] [stderr] 15 |     fn default() -> Self {
[INFO] [stderr] 16 |         Self::new()
[INFO] [stderr] 17 |     }
[INFO] [stderr] 18 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.75s
[INFO] running `"docker" "inspect" "ac419e24d3d6b5df6dbf6ae201406ce818207b7dcdaf7d9cba712a51f887e5ed"`
[INFO] running `"docker" "rm" "-f" "ac419e24d3d6b5df6dbf6ae201406ce818207b7dcdaf7d9cba712a51f887e5ed"`
[INFO] [stdout] ac419e24d3d6b5df6dbf6ae201406ce818207b7dcdaf7d9cba712a51f887e5ed