[INFO] updating cached repository andrew-d/lenovo-throttling-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andrew-d/lenovo-throttling-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andrew-d/lenovo-throttling-rust" "work/ex/clippy-test-run/sources/stable/gh/andrew-d/lenovo-throttling-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrew-d/lenovo-throttling-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andrew-d/lenovo-throttling-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrew-d/lenovo-throttling-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrew-d/lenovo-throttling-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6106cf90af1033ca700b3d58ff7963b8ba83f1c5 [INFO] sha for GitHub repo andrew-d/lenovo-throttling-rust: 6106cf90af1033ca700b3d58ff7963b8ba83f1c5 [INFO] validating manifest of andrew-d/lenovo-throttling-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andrew-d/lenovo-throttling-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andrew-d/lenovo-throttling-rust [INFO] finished frobbing andrew-d/lenovo-throttling-rust [INFO] frobbed toml for andrew-d/lenovo-throttling-rust written to work/ex/clippy-test-run/sources/stable/gh/andrew-d/lenovo-throttling-rust/Cargo.toml [INFO] started frobbing andrew-d/lenovo-throttling-rust [INFO] finished frobbing andrew-d/lenovo-throttling-rust [INFO] frobbed toml for andrew-d/lenovo-throttling-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrew-d/lenovo-throttling-rust/Cargo.toml [INFO] crate andrew-d/lenovo-throttling-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andrew-d/lenovo-throttling-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrew-d/lenovo-throttling-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c58fb534b8c2844aa581fa91e866b039fa3c1d12b8997e273f5d19c91380edf [INFO] running `"docker" "start" "-a" "5c58fb534b8c2844aa581fa91e866b039fa3c1d12b8997e273f5d19c91380edf"` [INFO] [stderr] Compiling libdbus-sys v0.1.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Checking dbus v0.6.2 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking lenovo-throttling-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let power_state = select_loop! { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 75 | | recv(power_change, state) => { [INFO] [stderr] 76 | | println!("power state is: {:?}", state); [INFO] [stderr] 77 | | state [INFO] [stderr] ... | [INFO] [stderr] 80 | | disconnected() => break 'outer, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:146:49 [INFO] [stderr] | [INFO] [stderr] 146 | let critical_temp = (msr_value >> 16) & 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:153:50 [INFO] [stderr] | [INFO] [stderr] 153 | let mask = ((critical_temp - max_temp) & 0b111111) << 24; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:154:38 [INFO] [stderr] | [INFO] [stderr] 154 | let new_value = (msr_value & 0b11000000111111111111111111111111) | (mask as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0000_1111_1111_1111_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:306:32 [INFO] [stderr] | [INFO] [stderr] 306 | let clear: u64 = !(0b111111100111111111111111 << offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1110_0111_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let power_state = select_loop! { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 75 | | recv(power_change, state) => { [INFO] [stderr] 76 | | println!("power state is: {:?}", state); [INFO] [stderr] 77 | | state [INFO] [stderr] ... | [INFO] [stderr] 80 | | disconnected() => break 'outer, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:146:49 [INFO] [stderr] | [INFO] [stderr] 146 | let critical_temp = (msr_value >> 16) & 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:153:50 [INFO] [stderr] | [INFO] [stderr] 153 | let mask = ((critical_temp - max_temp) & 0b111111) << 24; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:154:38 [INFO] [stderr] | [INFO] [stderr] 154 | let new_value = (msr_value & 0b11000000111111111111111111111111) | (mask as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1100_0000_1111_1111_1111_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:306:32 [INFO] [stderr] | [INFO] [stderr] 306 | let clear: u64 = !(0b111111100111111111111111 << offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1110_0111_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mask` [INFO] [stderr] --> src/msr.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn mask(&mut self, mask: (u32, u32)) -> &mut ReadMsrBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read` [INFO] [stderr] --> src/msr.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn read(&self) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/msr.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | let mask: u64 = (from_bit..(to_bit+1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(from_bit..=to_bit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/power.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | send.send(new_state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/power.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / 'outer: loop { [INFO] [stderr] 76 | | for msg in conn.incoming(10000) { [INFO] [stderr] 77 | | // Look for 'PropertiesChanged' events. [INFO] [stderr] 78 | | if let Ok((_name, changed)) = msg.read2::< [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/power.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | sender.send(new_state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let power_state = select_loop! { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 75 | | recv(power_change, state) => { [INFO] [stderr] 76 | | println!("power state is: {:?}", state); [INFO] [stderr] 77 | | state [INFO] [stderr] ... | [INFO] [stderr] 80 | | disconnected() => break 'outer, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let power_state = select_loop! { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 75 | | recv(power_change, state) => { [INFO] [stderr] 76 | | println!("power state is: {:?}", state); [INFO] [stderr] 77 | | state [INFO] [stderr] ... | [INFO] [stderr] 80 | | disconnected() => break 'outer, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/main.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | disconnected() => break 'outer, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:265:23 [INFO] [stderr] | [INFO] [stderr] 265 | let mut arr = (0..(31+1)).flat_map(|y| { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `(0..=31)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | (0..(3+1)).map(|z| { [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:267:61 [INFO] [stderr] | [INFO] [stderr] 267 | let lim = u64::pow(2, y) as f64 * (1.0f64 + (z as f64) / 4.0) * time_unit; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:297:22 [INFO] [stderr] | [INFO] [stderr] 297 | let tw = (y | (z << 5)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(y | (z << 5))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | new_power_limit = new_power_limit & clear; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_power_limit &= clear` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | new_power_limit = new_power_limit | set; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_power_limit |= set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / match (conf.pl1_tdp_w, conf.pl1_duration) { [INFO] [stderr] 319 | | (Some(tdp), Some(duration)) => { [INFO] [stderr] 320 | | do_mask(tdp, duration, 0); [INFO] [stderr] 321 | | }, [INFO] [stderr] 322 | | _ => {}, [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 318 | if let (Some(tdp), Some(duration)) = (conf.pl1_tdp_w, conf.pl1_duration) { [INFO] [stderr] 319 | do_mask(tdp, duration, 0); [INFO] [stderr] 320 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / match (conf.pl2_tdp_w, conf.pl2_duration) { [INFO] [stderr] 325 | | (Some(tdp), Some(duration)) => { [INFO] [stderr] 326 | | do_mask(tdp, duration, 32); [INFO] [stderr] 327 | | }, [INFO] [stderr] 328 | | _ => {}, [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 324 | if let (Some(tdp), Some(duration)) = (conf.pl2_tdp_w, conf.pl2_duration) { [INFO] [stderr] 325 | do_mask(tdp, duration, 32); [INFO] [stderr] 326 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lenovo-throttling-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `mask` [INFO] [stderr] --> src/msr.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn mask(&mut self, mask: (u32, u32)) -> &mut ReadMsrBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read` [INFO] [stderr] --> src/msr.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn read(&self) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/msr.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | let mask: u64 = (from_bit..(to_bit+1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(from_bit..=to_bit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/power.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | send.send(new_state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/power.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / 'outer: loop { [INFO] [stderr] 76 | | for msg in conn.incoming(10000) { [INFO] [stderr] 77 | | // Look for 'PropertiesChanged' events. [INFO] [stderr] 78 | | if let Ok((_name, changed)) = msg.read2::< [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/power.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | sender.send(new_state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let power_state = select_loop! { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 75 | | recv(power_change, state) => { [INFO] [stderr] 76 | | println!("power state is: {:?}", state); [INFO] [stderr] 77 | | state [INFO] [stderr] ... | [INFO] [stderr] 80 | | disconnected() => break 'outer, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let power_state = select_loop! { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 75 | | recv(power_change, state) => { [INFO] [stderr] 76 | | println!("power state is: {:?}", state); [INFO] [stderr] 77 | | state [INFO] [stderr] ... | [INFO] [stderr] 80 | | disconnected() => break 'outer, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/main.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | disconnected() => break 'outer, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:265:23 [INFO] [stderr] | [INFO] [stderr] 265 | let mut arr = (0..(31+1)).flat_map(|y| { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `(0..=31)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | (0..(3+1)).map(|z| { [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:267:61 [INFO] [stderr] | [INFO] [stderr] 267 | let lim = u64::pow(2, y) as f64 * (1.0f64 + (z as f64) / 4.0) * time_unit; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:297:22 [INFO] [stderr] | [INFO] [stderr] 297 | let tw = (y | (z << 5)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(y | (z << 5))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | new_power_limit = new_power_limit & clear; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_power_limit &= clear` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | new_power_limit = new_power_limit | set; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_power_limit |= set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / match (conf.pl1_tdp_w, conf.pl1_duration) { [INFO] [stderr] 319 | | (Some(tdp), Some(duration)) => { [INFO] [stderr] 320 | | do_mask(tdp, duration, 0); [INFO] [stderr] 321 | | }, [INFO] [stderr] 322 | | _ => {}, [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 318 | if let (Some(tdp), Some(duration)) = (conf.pl1_tdp_w, conf.pl1_duration) { [INFO] [stderr] 319 | do_mask(tdp, duration, 0); [INFO] [stderr] 320 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / match (conf.pl2_tdp_w, conf.pl2_duration) { [INFO] [stderr] 325 | | (Some(tdp), Some(duration)) => { [INFO] [stderr] 326 | | do_mask(tdp, duration, 32); [INFO] [stderr] 327 | | }, [INFO] [stderr] 328 | | _ => {}, [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 324 | if let (Some(tdp), Some(duration)) = (conf.pl2_tdp_w, conf.pl2_duration) { [INFO] [stderr] 325 | do_mask(tdp, duration, 32); [INFO] [stderr] 326 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lenovo-throttling-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5c58fb534b8c2844aa581fa91e866b039fa3c1d12b8997e273f5d19c91380edf"` [INFO] running `"docker" "rm" "-f" "5c58fb534b8c2844aa581fa91e866b039fa3c1d12b8997e273f5d19c91380edf"` [INFO] [stdout] 5c58fb534b8c2844aa581fa91e866b039fa3c1d12b8997e273f5d19c91380edf