[INFO] updating cached repository andrevdwal/passgen-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/andrevdwal/passgen-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/andrevdwal/passgen-rs" "work/ex/clippy-test-run/sources/stable/gh/andrevdwal/passgen-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrevdwal/passgen-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/andrevdwal/passgen-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrevdwal/passgen-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrevdwal/passgen-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1620c2daf646086ec36426c57090133cd5b3e0e5
[INFO] sha for GitHub repo andrevdwal/passgen-rs: 1620c2daf646086ec36426c57090133cd5b3e0e5
[INFO] validating manifest of andrevdwal/passgen-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of andrevdwal/passgen-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing andrevdwal/passgen-rs
[INFO] finished frobbing andrevdwal/passgen-rs
[INFO] frobbed toml for andrevdwal/passgen-rs written to work/ex/clippy-test-run/sources/stable/gh/andrevdwal/passgen-rs/Cargo.toml
[INFO] started frobbing andrevdwal/passgen-rs
[INFO] finished frobbing andrevdwal/passgen-rs
[INFO] frobbed toml for andrevdwal/passgen-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrevdwal/passgen-rs/Cargo.toml
[INFO] crate andrevdwal/passgen-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting andrevdwal/passgen-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrevdwal/passgen-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a3342dd50903ddc7231bee52c857f99dc6873d8252714c46f319a1896c4a62db
[INFO] running `"docker" "start" "-a" "a3342dd50903ddc7231bee52c857f99dc6873d8252714c46f319a1896c4a62db"`
[INFO] [stderr]     Checking pgrs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     return alphabet;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `alphabet`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     return password;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `password`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     return alphabet;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `alphabet`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     return password;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `password`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:18:56
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let alph_use_default: bool = arg_alphabet.contains("d");
[INFO] [stderr]    |                                                        ^^^ help: try using a char instead: `'d'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:19:74
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let alph_use_lower: bool = alph_use_default || arg_alphabet.contains("l");
[INFO] [stderr]    |                                                                          ^^^ help: try using a char instead: `'l'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:18:56
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let alph_use_default: bool = arg_alphabet.contains("d");
[INFO] [stderr]    |                                                        ^^^ help: try using a char instead: `'d'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:20:74
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let alph_use_upper: bool = alph_use_default || arg_alphabet.contains("u");
[INFO] [stderr]    |                                                                          ^^^ help: try using a char instead: `'u'`
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:19:74
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let alph_use_lower: bool = alph_use_default || arg_alphabet.contains("l");
[INFO] [stderr]    |                                                                          ^^^ help: try using a char instead: `'l'`
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:21:76
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let alph_use_special: bool = alph_use_default || arg_alphabet.contains("s");
[INFO] [stderr]    |                                                                            ^^^ help: try using a char instead: `'s'`
[INFO] [stderr]    |
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:22:76
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let alph_use_numbers: bool = alph_use_default || arg_alphabet.contains("n");
[INFO] [stderr]    |                                                                            ^^^ help: try using a char instead: `'n'`
[INFO] [stderr]   --> src/main.rs:20:74
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let alph_use_upper: bool = alph_use_default || arg_alphabet.contains("u");
[INFO] [stderr]    |                                                                          ^^^ help: try using a char instead: `'u'`
[INFO] [stderr]    |
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:21:76
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let alph_use_special: bool = alph_use_default || arg_alphabet.contains("s");
[INFO] [stderr]    |                                                                            ^^^ help: try using a char instead: `'s'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:22:76
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let alph_use_numbers: bool = alph_use_default || arg_alphabet.contains("n");
[INFO] [stderr]    |                                                                            ^^^ help: try using a char instead: `'n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:53:32
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn generate_password(alphabet: &String, length: u8) -> String {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:53:32
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn generate_password(alphabet: &String, length: u8) -> String {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.50s
[INFO] running `"docker" "inspect" "a3342dd50903ddc7231bee52c857f99dc6873d8252714c46f319a1896c4a62db"`
[INFO] running `"docker" "rm" "-f" "a3342dd50903ddc7231bee52c857f99dc6873d8252714c46f319a1896c4a62db"`
[INFO] [stdout] a3342dd50903ddc7231bee52c857f99dc6873d8252714c46f319a1896c4a62db