[INFO] updating cached repository andrea-couto/pug_attack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andrea-couto/pug_attack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andrea-couto/pug_attack" "work/ex/clippy-test-run/sources/stable/gh/andrea-couto/pug_attack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andrea-couto/pug_attack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andrea-couto/pug_attack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrea-couto/pug_attack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrea-couto/pug_attack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 870b1e02500b28d00b2a8b7e84bfe0f73b685612 [INFO] sha for GitHub repo andrea-couto/pug_attack: 870b1e02500b28d00b2a8b7e84bfe0f73b685612 [INFO] validating manifest of andrea-couto/pug_attack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andrea-couto/pug_attack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andrea-couto/pug_attack [INFO] finished frobbing andrea-couto/pug_attack [INFO] frobbed toml for andrea-couto/pug_attack written to work/ex/clippy-test-run/sources/stable/gh/andrea-couto/pug_attack/Cargo.toml [INFO] started frobbing andrea-couto/pug_attack [INFO] finished frobbing andrea-couto/pug_attack [INFO] frobbed toml for andrea-couto/pug_attack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andrea-couto/pug_attack/Cargo.toml [INFO] crate andrea-couto/pug_attack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andrea-couto/pug_attack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/andrea-couto/pug_attack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b1f5b61a6ea3a874924c5f9ad2a099124ad85a3c952dc97b09f364829b05a3f8 [INFO] running `"docker" "start" "-a" "b1f5b61a6ea3a874924c5f9ad2a099124ad85a3c952dc97b09f364829b05a3f8"` [INFO] [stderr] Compiling phf v0.7.23 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking pistoncore-input v0.17.1 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking pistoncore-event_loop v0.31.4 [INFO] [stderr] Checking piston v0.31.4 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking piston2d-opengl_graphics v0.40.0 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking TestGame v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/vector.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | Vector { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/vector.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | Vector { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/vector.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | Vector { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/vector.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | Vector { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::graphics::rectangle::square` [INFO] [stderr] --> src/models/player.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use self::graphics::rectangle::square; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `TestGame` should have a snake case name such as `test_game` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models/player.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self.texture { [INFO] [stderr] 45 | | Ok(ref t) => image(t, bodytrans, gl), [INFO] [stderr] 46 | | _ => {} [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(ref t) = self.texture { image(t, bodytrans, gl) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/pug.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn update(&mut self, args: &UpdateArgs, desx: f64, desy: f64, dimensions: &[f64; 2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models/pug.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self.texture { [INFO] [stderr] 100 | | Ok(ref t) => image(t, transform, gl), [INFO] [stderr] 101 | | _ => {} [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(ref t) = self.texture { image(t, transform, gl) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/game.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | text(BLACK, 72, format!("SHE WOKE").as_str(), glyph_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SHE WOKE".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/game.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | text(BLACK, 72, format!("Click R to Restart").as_str(), glyph_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Click R to Restart".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | fn on_update(&mut self, args: &UpdateArgs, cursor:[f64;2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | / match k { [INFO] [stderr] 127 | | Button::Keyboard(key) => self.on_key_press(key), [INFO] [stderr] 128 | | _ => {} [INFO] [stderr] 129 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Button::Keyboard(key) = k { self.on_key_press(key) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:139:42 [INFO] [stderr] | [INFO] [stderr] 139 | fn on_resize(&mut self, new_dimensions: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[u32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:140:30 [INFO] [stderr] | [INFO] [stderr] 140 | self.dimensions[0] = new_dimensions[0] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(new_dimensions[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:141:30 [INFO] [stderr] | [INFO] [stderr] 141 | self.dimensions[1] = new_dimensions[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(new_dimensions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/game.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / let mut y:f64 = 0.0; [INFO] [stderr] 154 | | if random_num == 1 { [INFO] [stderr] 155 | | x = rand::thread_rng().gen_range(0.0, self.dimensions[0]); [INFO] [stderr] 156 | | y = 0.0; [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let y = if random_num == 1 { ..; 0.0 } else { 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match key { [INFO] [stderr] 176 | | Key::R => { [INFO] [stderr] 177 | | self.reset(); [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | _ => {} [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | if let Key::R = key { [INFO] [stderr] 176 | self.reset(); [INFO] [stderr] 177 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::graphics::rectangle::square` [INFO] [stderr] --> src/models/player.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use self::graphics::rectangle::square; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/vector.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | Vector { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/vector.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | Vector { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/vector.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | Vector { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/vector.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | Vector { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: crate `TestGame` should have a snake case name such as `test_game` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models/player.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self.texture { [INFO] [stderr] 45 | | Ok(ref t) => image(t, bodytrans, gl), [INFO] [stderr] 46 | | _ => {} [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(ref t) = self.texture { image(t, bodytrans, gl) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/pug.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn update(&mut self, args: &UpdateArgs, desx: f64, desy: f64, dimensions: &[f64; 2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models/pug.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self.texture { [INFO] [stderr] 100 | | Ok(ref t) => image(t, transform, gl), [INFO] [stderr] 101 | | _ => {} [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(ref t) = self.texture { image(t, transform, gl) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/game.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | text(BLACK, 72, format!("SHE WOKE").as_str(), glyph_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SHE WOKE".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/game.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | text(BLACK, 72, format!("Click R to Restart").as_str(), glyph_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Click R to Restart".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | fn on_update(&mut self, args: &UpdateArgs, cursor:[f64;2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | / match k { [INFO] [stderr] 127 | | Button::Keyboard(key) => self.on_key_press(key), [INFO] [stderr] 128 | | _ => {} [INFO] [stderr] 129 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Button::Keyboard(key) = k { self.on_key_press(key) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:139:42 [INFO] [stderr] | [INFO] [stderr] 139 | fn on_resize(&mut self, new_dimensions: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[u32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:140:30 [INFO] [stderr] | [INFO] [stderr] 140 | self.dimensions[0] = new_dimensions[0] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(new_dimensions[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:141:30 [INFO] [stderr] | [INFO] [stderr] 141 | self.dimensions[1] = new_dimensions[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(new_dimensions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/game.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / let mut y:f64 = 0.0; [INFO] [stderr] 154 | | if random_num == 1 { [INFO] [stderr] 155 | | x = rand::thread_rng().gen_range(0.0, self.dimensions[0]); [INFO] [stderr] 156 | | y = 0.0; [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let y = if random_num == 1 { ..; 0.0 } else { 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match key { [INFO] [stderr] 176 | | Key::R => { [INFO] [stderr] 177 | | self.reset(); [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | _ => {} [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | if let Key::R = key { [INFO] [stderr] 176 | self.reset(); [INFO] [stderr] 177 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::graphics::rectangle::square` [INFO] [stderr] --> src/models/player.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use self::graphics::rectangle::square; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::graphics::rectangle::square` [INFO] [stderr] --> src/models/player.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use self::graphics::rectangle::square; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `TestGame` should have a snake case name such as `test_game` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/game.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | text(BLACK, 72, format!("SHE WOKE").as_str(), glyph_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SHE WOKE".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/game.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | text(BLACK, 72, format!("Click R to Restart").as_str(), glyph_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Click R to Restart".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | fn on_update(&mut self, args: &UpdateArgs, cursor:[f64;2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | / match k { [INFO] [stderr] 127 | | Button::Keyboard(key) => self.on_key_press(key), [INFO] [stderr] 128 | | _ => {} [INFO] [stderr] 129 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Button::Keyboard(key) = k { self.on_key_press(key) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:139:42 [INFO] [stderr] | [INFO] [stderr] 139 | fn on_resize(&mut self, new_dimensions: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[u32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:140:30 [INFO] [stderr] | [INFO] [stderr] 140 | self.dimensions[0] = new_dimensions[0] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(new_dimensions[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:141:30 [INFO] [stderr] | [INFO] [stderr] 141 | self.dimensions[1] = new_dimensions[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(new_dimensions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/game.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / let mut y:f64 = 0.0; [INFO] [stderr] 154 | | if random_num == 1 { [INFO] [stderr] 155 | | x = rand::thread_rng().gen_range(0.0, self.dimensions[0]); [INFO] [stderr] 156 | | y = 0.0; [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let y = if random_num == 1 { ..; 0.0 } else { 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match key { [INFO] [stderr] 176 | | Key::R => { [INFO] [stderr] 177 | | self.reset(); [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | _ => {} [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | if let Key::R = key { [INFO] [stderr] 176 | self.reset(); [INFO] [stderr] 177 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models/player.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self.texture { [INFO] [stderr] 45 | | Ok(ref t) => image(t, bodytrans, gl), [INFO] [stderr] 46 | | _ => {} [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(ref t) = self.texture { image(t, bodytrans, gl) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/pug.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn update(&mut self, args: &UpdateArgs, desx: f64, desy: f64, dimensions: &[f64; 2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models/pug.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self.texture { [INFO] [stderr] 100 | | Ok(ref t) => image(t, transform, gl), [INFO] [stderr] 101 | | _ => {} [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(ref t) = self.texture { image(t, transform, gl) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: crate `TestGame` should have a snake case name such as `test_game` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/game.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | text(BLACK, 72, format!("SHE WOKE").as_str(), glyph_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SHE WOKE".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/game.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | text(BLACK, 72, format!("Click R to Restart").as_str(), glyph_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Click R to Restart".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | fn on_update(&mut self, args: &UpdateArgs, cursor:[f64;2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | / match k { [INFO] [stderr] 127 | | Button::Keyboard(key) => self.on_key_press(key), [INFO] [stderr] 128 | | _ => {} [INFO] [stderr] 129 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Button::Keyboard(key) = k { self.on_key_press(key) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:139:42 [INFO] [stderr] | [INFO] [stderr] 139 | fn on_resize(&mut self, new_dimensions: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[u32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:140:30 [INFO] [stderr] | [INFO] [stderr] 140 | self.dimensions[0] = new_dimensions[0] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(new_dimensions[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:141:30 [INFO] [stderr] | [INFO] [stderr] 141 | self.dimensions[1] = new_dimensions[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(new_dimensions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/game.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / let mut y:f64 = 0.0; [INFO] [stderr] 154 | | if random_num == 1 { [INFO] [stderr] 155 | | x = rand::thread_rng().gen_range(0.0, self.dimensions[0]); [INFO] [stderr] 156 | | y = 0.0; [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let y = if random_num == 1 { ..; 0.0 } else { 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match key { [INFO] [stderr] 176 | | Key::R => { [INFO] [stderr] 177 | | self.reset(); [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | _ => {} [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | if let Key::R = key { [INFO] [stderr] 176 | self.reset(); [INFO] [stderr] 177 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models/player.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self.texture { [INFO] [stderr] 45 | | Ok(ref t) => image(t, bodytrans, gl), [INFO] [stderr] 46 | | _ => {} [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(ref t) = self.texture { image(t, bodytrans, gl) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/pug.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn update(&mut self, args: &UpdateArgs, desx: f64, desy: f64, dimensions: &[f64; 2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/models/pug.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self.texture { [INFO] [stderr] 100 | | Ok(ref t) => image(t, transform, gl), [INFO] [stderr] 101 | | _ => {} [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(ref t) = self.texture { image(t, transform, gl) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `"docker" "inspect" "b1f5b61a6ea3a874924c5f9ad2a099124ad85a3c952dc97b09f364829b05a3f8"` [INFO] running `"docker" "rm" "-f" "b1f5b61a6ea3a874924c5f9ad2a099124ad85a3c952dc97b09f364829b05a3f8"` [INFO] [stdout] b1f5b61a6ea3a874924c5f9ad2a099124ad85a3c952dc97b09f364829b05a3f8