[INFO] updating cached repository and-hom/rust_test_lib
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/and-hom/rust_test_lib
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/and-hom/rust_test_lib" "work/ex/clippy-test-run/sources/stable/gh/and-hom/rust_test_lib"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/and-hom/rust_test_lib'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/and-hom/rust_test_lib" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/and-hom/rust_test_lib"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/and-hom/rust_test_lib'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 70b92b8e14a33a8331867f21590d625acf39388f
[INFO] sha for GitHub repo and-hom/rust_test_lib: 70b92b8e14a33a8331867f21590d625acf39388f
[INFO] validating manifest of and-hom/rust_test_lib on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of and-hom/rust_test_lib on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing and-hom/rust_test_lib
[INFO] finished frobbing and-hom/rust_test_lib
[INFO] frobbed toml for and-hom/rust_test_lib written to work/ex/clippy-test-run/sources/stable/gh/and-hom/rust_test_lib/Cargo.toml
[INFO] started frobbing and-hom/rust_test_lib
[INFO] finished frobbing and-hom/rust_test_lib
[INFO] frobbed toml for and-hom/rust_test_lib written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/and-hom/rust_test_lib/Cargo.toml
[INFO] crate and-hom/rust_test_lib has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting and-hom/rust_test_lib against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/and-hom/rust_test_lib:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] afde0878edf15464898f91dda23d6f05edc585346e15a7116dedc78af8143637
[INFO] running `"docker" "start" "-a" "afde0878edf15464898f91dda23d6f05edc585346e15a7116dedc78af8143637"`
[INFO] [stderr]     Checking bincode v1.0.0
[INFO] [stderr]     Checking rust_test_lib v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/memory/mod.rs:29:24
[INFO] [stderr]    |
[INFO] [stderr] 29 |             .map(|_| { () })
[INFO] [stderr]    |                        ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/disk/mod.rs:70:24
[INFO] [stderr]    |
[INFO] [stderr] 70 |             .map(|_| { () })
[INFO] [stderr]    |                        ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/lib.rs:10:1
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/memory/mod.rs:29:24
[INFO] [stderr]    |
[INFO] [stderr] 29 |             .map(|_| { () })
[INFO] [stderr]    |                        ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/disk/mod.rs:70:24
[INFO] [stderr]    |
[INFO] [stderr] 70 |             .map(|_| { () })
[INFO] [stderr]    |                        ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/lib.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/lib.rs:10:1
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/memory/mod.rs:22:14
[INFO] [stderr]    |
[INFO] [stderr] 22 |             .ok_or(ReadError::MISSING(id.to_string()))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ReadError::MISSING(id.to_string()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/memory/mod.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |             .ok_or(RemoveError::MISSING(id.to_string()))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RemoveError::MISSING(id.to_string()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/disk/mod.rs:89:18
[INFO] [stderr]    |
[INFO] [stderr] 89 |                 .expect(&format!("Can not mkdir {}", base_dir));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can not mkdir {}", base_dir))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/memory/mod.rs:22:14
[INFO] [stderr]    |
[INFO] [stderr] 22 |             .ok_or(ReadError::MISSING(id.to_string()))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ReadError::MISSING(id.to_string()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/memory/mod.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |             .ok_or(RemoveError::MISSING(id.to_string()))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RemoveError::MISSING(id.to_string()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/disk/mod.rs:89:18
[INFO] [stderr]    |
[INFO] [stderr] 89 |                 .expect(&format!("Can not mkdir {}", base_dir));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can not mkdir {}", base_dir))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/test/mod.rs:41:28
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn test_store(storage: &mut Box<Storage<TData>>, conf: &TestConf<TData>) {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut Storage<TData>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/test/mod.rs:48:32
[INFO] [stderr]    |
[INFO] [stderr] 48 |     fn test_overwrite(storage: &mut Box<Storage<TData>>, conf: &TestConf<TData>) {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut Storage<TData>`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/test/mod.rs:56:29
[INFO] [stderr]    |
[INFO] [stderr] 56 |     fn test_remove(storage: &mut Box<Storage<TData>>, conf: &TestConf<TData>) {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut Storage<TData>`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.52s
[INFO] running `"docker" "inspect" "afde0878edf15464898f91dda23d6f05edc585346e15a7116dedc78af8143637"`
[INFO] running `"docker" "rm" "-f" "afde0878edf15464898f91dda23d6f05edc585346e15a7116dedc78af8143637"`
[INFO] [stdout] afde0878edf15464898f91dda23d6f05edc585346e15a7116dedc78af8143637