[INFO] updating cached repository anarioch/rustyrays
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/anarioch/rustyrays
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/anarioch/rustyrays" "work/ex/clippy-test-run/sources/stable/gh/anarioch/rustyrays"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anarioch/rustyrays'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/anarioch/rustyrays" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anarioch/rustyrays"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anarioch/rustyrays'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cfd437e73318aee7fb2815e086858dc348bcc94f
[INFO] sha for GitHub repo anarioch/rustyrays: cfd437e73318aee7fb2815e086858dc348bcc94f
[INFO] validating manifest of anarioch/rustyrays on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of anarioch/rustyrays on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing anarioch/rustyrays
[INFO] finished frobbing anarioch/rustyrays
[INFO] frobbed toml for anarioch/rustyrays written to work/ex/clippy-test-run/sources/stable/gh/anarioch/rustyrays/Cargo.toml
[INFO] started frobbing anarioch/rustyrays
[INFO] finished frobbing anarioch/rustyrays
[INFO] frobbed toml for anarioch/rustyrays written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anarioch/rustyrays/Cargo.toml
[INFO] crate anarioch/rustyrays has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting anarioch/rustyrays against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anarioch/rustyrays:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e6eab10b303930557986dec3aff997c611d4e321bb5e49aee8954d6c22b2f24c
[INFO] running `"docker" "start" "-a" "e6eab10b303930557986dec3aff997c611d4e321bb5e49aee8954d6c22b2f24c"`
[INFO] [stderr]     Checking rayon-core v1.4.0
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]     Checking png v0.11.0
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking float-cmp v0.2.5
[INFO] [stderr]     Checking rayon v1.0.1
[INFO] [stderr]     Checking jpeg-decoder v0.1.14
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking noise v0.5.1
[INFO] [stderr]     Checking raytrace v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:445:25
[INFO] [stderr]     |
[INFO] [stderr] 445 |         let ray = Ray { origin: origin, direction: -y_axis };
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: replace it with: `origin`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:445:25
[INFO] [stderr]     |
[INFO] [stderr] 445 |         let ray = Ray { origin: origin, direction: -y_axis };
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: replace it with: `origin`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/materials.rs:285:55
[INFO] [stderr]     |
[INFO] [stderr] 285 |         assert_eq!(res.scattered.direction, Vec3::new(0.47140455, -0.8819171, 0.0)); // FIXME This depends on a random factor
[INFO] [stderr]     |                                                       ^^^^^^^^^^ help: consider: `0.471_404_55`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/materials.rs:285:68
[INFO] [stderr]     |
[INFO] [stderr] 285 |         assert_eq!(res.scattered.direction, Vec3::new(0.47140455, -0.8819171, 0.0)); // FIXME This depends on a random factor
[INFO] [stderr]     |                                                                    ^^^^^^^^^ help: consider: `0.881_917_1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:295:34
[INFO] [stderr]     |
[INFO] [stderr] 295 |     Leaf { bounds: AABB, object: &'a Box<dyn Hitable> },
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:299:25
[INFO] [stderr]     |
[INFO] [stderr] 299 |     fn compare_x_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:299:47
[INFO] [stderr]     |
[INFO] [stderr] 299 |     fn compare_x_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:304:26
[INFO] [stderr]     |
[INFO] [stderr] 304 |     fn _compare_y_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:304:48
[INFO] [stderr]     |
[INFO] [stderr] 304 |     fn _compare_y_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:309:25
[INFO] [stderr]     |
[INFO] [stderr] 309 |     fn compare_z_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:309:47
[INFO] [stderr]     |
[INFO] [stderr] 309 |     fn compare_z_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:341:39
[INFO] [stderr]     |
[INFO] [stderr] 341 |     pub fn glue(bvh: BVH<'a>, object: &'a Box<dyn Hitable>) -> BVH<'a> {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         let mut eye = self.eye;
[INFO] [stderr] 54 | |         if self.lens_radius > 0.0 {
[INFO] [stderr] 55 | |             // Add noise to eye location to achieve depth-if-field
[INFO] [stderr] 56 | |             // This chooses a random point on a disk sitting at the eye location, oriented to view direction
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             eye = self.eye + offset;
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> eye = if self.lens_radius > 0.0 { ..; self.eye + offset } else { self.eye };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:234:9
[INFO] [stderr]     |
[INFO] [stderr] 234 |         assert_eq!(Vec3::new(0.0, 0.0, 0.0).len_sq(), 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:234:9
[INFO] [stderr]     |
[INFO] [stderr] 234 |         assert_eq!(Vec3::new(0.0, 0.0, 0.0).len_sq(), 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:235:9
[INFO] [stderr]     |
[INFO] [stderr] 235 |         assert_eq!(Vec3::new(0.0, 1.0, 0.0).len_sq(), 1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:235:9
[INFO] [stderr]     |
[INFO] [stderr] 235 |         assert_eq!(Vec3::new(0.0, 1.0, 0.0).len_sq(), 1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:236:9
[INFO] [stderr]     |
[INFO] [stderr] 236 |         assert_eq!(Vec3::new(0.0, 5.0, 0.0).len_sq(), 25.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:236:9
[INFO] [stderr]     |
[INFO] [stderr] 236 |         assert_eq!(Vec3::new(0.0, 5.0, 0.0).len_sq(), 25.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 |         assert_eq!(Vec3::new(1.0, 1.0, 1.0).len_sq(), 3.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 |         assert_eq!(Vec3::new(1.0, 1.0, 1.0).len_sq(), 3.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 |         assert_eq!(Vec3::new(0.0, 0.0, 0.0).length(), 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 |         assert_eq!(Vec3::new(0.0, 0.0, 0.0).length(), 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:241:9
[INFO] [stderr]     |
[INFO] [stderr] 241 |         assert_eq!(Vec3::new(0.0, 1.0, 0.0).length(), 1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:241:9
[INFO] [stderr]     |
[INFO] [stderr] 241 |         assert_eq!(Vec3::new(0.0, 1.0, 0.0).length(), 1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:242:9
[INFO] [stderr]     |
[INFO] [stderr] 242 |         assert_eq!(Vec3::new(0.0, 5.0, 0.0).length(), 5.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:242:9
[INFO] [stderr]     |
[INFO] [stderr] 242 |         assert_eq!(Vec3::new(0.0, 5.0, 0.0).length(), 5.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:243:9
[INFO] [stderr]     |
[INFO] [stderr] 243 |         assert_eq!(Vec3::new(1.0, 1.0, 1.0).length(), f32::sqrt(3.0));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:243:9
[INFO] [stderr]     |
[INFO] [stderr] 243 |         assert_eq!(Vec3::new(1.0, 1.0, 1.0).length(), f32::sqrt(3.0));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:258:9
[INFO] [stderr]     |
[INFO] [stderr] 258 |         assert_eq!(normalised.x, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:258:9
[INFO] [stderr]     |
[INFO] [stderr] 258 |         assert_eq!(normalised.x, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:259:9
[INFO] [stderr]     |
[INFO] [stderr] 259 |         assert_eq!(normalised.y, 1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:259:9
[INFO] [stderr]     |
[INFO] [stderr] 259 |         assert_eq!(normalised.y, 1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:260:9
[INFO] [stderr]     |
[INFO] [stderr] 260 |         assert_eq!(normalised.z, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:260:9
[INFO] [stderr]     |
[INFO] [stderr] 260 |         assert_eq!(normalised.z, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:265:9
[INFO] [stderr]     |
[INFO] [stderr] 265 |         assert_eq!(normalised.x, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:265:9
[INFO] [stderr]     |
[INFO] [stderr] 265 |         assert_eq!(normalised.x, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:266:9
[INFO] [stderr]     |
[INFO] [stderr] 266 |         assert_eq!(normalised.y, 1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:266:9
[INFO] [stderr]     |
[INFO] [stderr] 266 |         assert_eq!(normalised.y, 1.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:267:9
[INFO] [stderr]     |
[INFO] [stderr] 267 |         assert_eq!(normalised.z, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:267:9
[INFO] [stderr]     |
[INFO] [stderr] 267 |         assert_eq!(normalised.z, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:272:9
[INFO] [stderr]     |
[INFO] [stderr] 272 |         assert_eq!(normalised.x, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:272:9
[INFO] [stderr]     |
[INFO] [stderr] 272 |         assert_eq!(normalised.x, 0.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:273:9
[INFO] [stderr]     |
[INFO] [stderr] 273 |         assert_eq!(normalised.y, 3.0 / 5.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:273:9
[INFO] [stderr]     |
[INFO] [stderr] 273 |         assert_eq!(normalised.y, 3.0 / 5.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:274:9
[INFO] [stderr]     |
[INFO] [stderr] 274 |         assert_eq!(normalised.z, 4.0 / 5.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:274:9
[INFO] [stderr]     |
[INFO] [stderr] 274 |         assert_eq!(normalised.z, 4.0 / 5.0);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:295:34
[INFO] [stderr]     |
[INFO] [stderr] 295 |     Leaf { bounds: AABB, object: &'a Box<dyn Hitable> },
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:299:25
[INFO] [stderr]     |
[INFO] [stderr] 299 |     fn compare_x_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:299:47
[INFO] [stderr]     |
[INFO] [stderr] 299 |     fn compare_x_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:304:26
[INFO] [stderr]     |
[INFO] [stderr] 304 |     fn _compare_y_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:304:48
[INFO] [stderr]     |
[INFO] [stderr] 304 |     fn _compare_y_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:309:25
[INFO] [stderr]     |
[INFO] [stderr] 309 |     fn compare_z_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:309:47
[INFO] [stderr]     |
[INFO] [stderr] 309 |     fn compare_z_min(a: &Box<dyn Hitable>, b: &Box<dyn Hitable>) -> Ordering {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^ help: try: `&dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/geometry.rs:341:39
[INFO] [stderr]     |
[INFO] [stderr] 341 |     pub fn glue(bvh: BVH<'a>, object: &'a Box<dyn Hitable>) -> BVH<'a> {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^ help: try: `&'a dyn Hitable`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/geometry.rs:427:29
[INFO] [stderr]     |
[INFO] [stderr] 427 |             Some(record) => assert_eq!(record.t, 1.0),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/geometry.rs:427:29
[INFO] [stderr]     |
[INFO] [stderr] 427 |             Some(record) => assert_eq!(record.t, 1.0),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         let mut eye = self.eye;
[INFO] [stderr] 54 | |         if self.lens_radius > 0.0 {
[INFO] [stderr] 55 | |             // Add noise to eye location to achieve depth-if-field
[INFO] [stderr] 56 | |             // This chooses a random point on a disk sitting at the eye location, oriented to view direction
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             eye = self.eye + offset;
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> eye = if self.lens_radius > 0.0 { ..; self.eye + offset } else { self.eye };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 18 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `raytrace`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/integration_test.rs:57:35
[INFO] [stderr]    |
[INFO] [stderr] 57 |     assert!(res.t.approx_eq_ulps(&0.8585787, 2));
[INFO] [stderr]    |                                   ^^^^^^^^^ help: consider: `0.858_578_7`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel
[INFO] [stderr]  --> benches/bench_geometry.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | #![feature(test)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0554`.
[INFO] [stderr] error: Could not compile `raytrace`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |     for ref outlier in &scene.outlier_objects {
[INFO] [stderr]     |         ^^^^^^^^^^^    ---------------------- help: try: `let outlier = &&scene.outlier_objects;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |     for ref outlier in &scene.outlier_objects {
[INFO] [stderr]     |         ^^^^^^^^^^^    ---------------------- help: try: `let outlier = &&scene.outlier_objects;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel
[INFO] [stderr]  --> benches/bench_materials.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | #![feature(test)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0554`.
[INFO] [stderr] error: Could not compile `raytrace`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "e6eab10b303930557986dec3aff997c611d4e321bb5e49aee8954d6c22b2f24c"`
[INFO] running `"docker" "rm" "-f" "e6eab10b303930557986dec3aff997c611d4e321bb5e49aee8954d6c22b2f24c"`
[INFO] [stdout] e6eab10b303930557986dec3aff997c611d4e321bb5e49aee8954d6c22b2f24c