[INFO] updating cached repository anagav/advent_code_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/anagav/advent_code_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/anagav/advent_code_rust" "work/ex/clippy-test-run/sources/stable/gh/anagav/advent_code_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anagav/advent_code_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/anagav/advent_code_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anagav/advent_code_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anagav/advent_code_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7afa8a4bc499402c8306f17550f0f02a644f6292 [INFO] sha for GitHub repo anagav/advent_code_rust: 7afa8a4bc499402c8306f17550f0f02a644f6292 [INFO] validating manifest of anagav/advent_code_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anagav/advent_code_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anagav/advent_code_rust [INFO] finished frobbing anagav/advent_code_rust [INFO] frobbed toml for anagav/advent_code_rust written to work/ex/clippy-test-run/sources/stable/gh/anagav/advent_code_rust/Cargo.toml [INFO] started frobbing anagav/advent_code_rust [INFO] finished frobbing anagav/advent_code_rust [INFO] frobbed toml for anagav/advent_code_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anagav/advent_code_rust/Cargo.toml [INFO] crate anagav/advent_code_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anagav/advent_code_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/anagav/advent_code_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3ae1f6127acea315404a11eec1f48bf87301000ea15a176f01798837e45cb91 [INFO] running `"docker" "start" "-a" "c3ae1f6127acea315404a11eec1f48bf87301000ea15a176f01798837e45cb91"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return surface_area + additional_area; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `surface_area + additional_area` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day6_2.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/bin/day3.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::{self,BufRead,Read}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:4:53 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:4:68 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:4:81 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:4:94 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6_2.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 5 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:13:54 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:13:69 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:13:82 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:13:95 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6_2.rs:14:14 [INFO] [stderr] | [INFO] [stderr] 14 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:24:52 [INFO] [stderr] | [INFO] [stderr] 24 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:24:67 [INFO] [stderr] | [INFO] [stderr] 24 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:24:80 [INFO] [stderr] | [INFO] [stderr] 24 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:24:93 [INFO] [stderr] | [INFO] [stderr] 24 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6_2.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 25 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | let splits:Vec<_> = line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | let start_x:usize = splits[1].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:37:45 [INFO] [stderr] | [INFO] [stderr] 37 | let start_y:usize = splits[1].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | let end_x:usize = splits[3].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let end_y:usize = splits[3].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | let start_x:usize = splits[2].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:46:41 [INFO] [stderr] | [INFO] [stderr] 46 | let start_y:usize = splits[2].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:47:39 [INFO] [stderr] | [INFO] [stderr] 47 | let end_x:usize = splits[4].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | let end_y:usize = splits[4].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day2.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day6_2.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | fn count_num_lights_on(array:&Vec>) -> i32{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day2.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day2.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day2.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | fn ribbon_feed(v: &Vec) -> i32{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map` [INFO] [stderr] --> src/bin/day2.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | let (paper_needed,paper_needed_2) = stdin.lock().lines().map( [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 20 | | |line| line.unwrap() [INFO] [stderr] 21 | | ).map( [INFO] [stderr] 22 | | |line| { [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | ).fold((0,0),|(sum,sum2),(element,element2)|{ [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day2.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | line.split("x").map(|num| num.parse::().unwrap()).collect::>() [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent_of_code`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day6_2.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:4:53 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:4:68 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:4:81 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:4:94 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6_2.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 5 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:13:54 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:13:69 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:13:82 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:13:95 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6_2.rs:14:14 [INFO] [stderr] | [INFO] [stderr] 14 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:24:52 [INFO] [stderr] | [INFO] [stderr] 24 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:24:67 [INFO] [stderr] | [INFO] [stderr] 24 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:24:80 [INFO] [stderr] | [INFO] [stderr] 24 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6_2.rs:24:93 [INFO] [stderr] | [INFO] [stderr] 24 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6_2.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 25 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | let splits:Vec<_> = line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | let start_x:usize = splits[1].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:37:45 [INFO] [stderr] | [INFO] [stderr] 37 | let start_y:usize = splits[1].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | let end_x:usize = splits[3].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let end_y:usize = splits[3].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | let start_x:usize = splits[2].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:46:41 [INFO] [stderr] | [INFO] [stderr] 46 | let start_y:usize = splits[2].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:47:39 [INFO] [stderr] | [INFO] [stderr] 47 | let end_x:usize = splits[4].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6_2.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | let end_y:usize = splits[4].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day3.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day3.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day3.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map` [INFO] [stderr] --> src/bin/day3.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | let result:Vec<_> = stdin.lock().lines().map( [INFO] [stderr] | _________________________^ [INFO] [stderr] 11 | | |line| line.unwrap() [INFO] [stderr] 12 | | ).filter_map( [INFO] [stderr] 13 | | |line| { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | ).collect(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day6_2.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | fn count_num_lights_on(array:&Vec>) -> i32{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent_of_code`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day6.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day2.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return surface_area + additional_area; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `surface_area + additional_area` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:4:53 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:4:68 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:4:81 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:4:94 [INFO] [stderr] | [INFO] [stderr] 4 | fn turn_on_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 5 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:13:54 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:13:69 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:13:82 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:13:95 [INFO] [stderr] | [INFO] [stderr] 13 | fn turn_off_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6.rs:14:14 [INFO] [stderr] | [INFO] [stderr] 14 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day2.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:21:52 [INFO] [stderr] | [INFO] [stderr] 21 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day2.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] --> src/bin/day6.rs:21:67 [INFO] [stderr] | [INFO] [stderr] 21 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day2.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] | [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:21:80 [INFO] [stderr] | [INFO] [stderr] 21 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day6.rs:21:93 [INFO] [stderr] | [INFO] [stderr] 21 | fn toggle_lights(array:&mut Vec>, start_x:&usize,start_y:&usize,end_x:&usize,end_y:&usize){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/bin/day6.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | for i in *start_x..*end_x{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 22 | for in array.iter_mut().take(*end_x).skip(*start_x){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day2.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | fn ribbon_feed(v: &Vec) -> i32{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | let splits:Vec<_> = line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | let start_x:usize = splits[1].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:39:45 [INFO] [stderr] | [INFO] [stderr] 39 | let start_y:usize = splits[1].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:40:43 [INFO] [stderr] | [INFO] [stderr] 40 | let end_x:usize = splits[3].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:41:43 [INFO] [stderr] | [INFO] [stderr] 41 | let end_y:usize = splits[3].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | let start_x:usize = splits[2].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:48:41 [INFO] [stderr] | [INFO] [stderr] 48 | let start_y:usize = splits[2].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:49:39 [INFO] [stderr] | [INFO] [stderr] 49 | let end_x:usize = splits[4].split(",").collect::>()[0].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day6.rs:50:39 [INFO] [stderr] | [INFO] [stderr] 50 | let end_y:usize = splits[4].split(",").collect::>()[1].parse().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map` [INFO] [stderr] --> src/bin/day2.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | let (paper_needed,paper_needed_2) = stdin.lock().lines().map( [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 20 | | |line| line.unwrap() [INFO] [stderr] 21 | | ).map( [INFO] [stderr] 22 | | |line| { [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | ).fold((0,0),|(sum,sum2),(element,element2)|{ [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day2.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | line.split("x").map(|num| num.parse::().unwrap()).collect::>() [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day6.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | fn count_num_lights_on(array:&Vec>) -> i32{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent_of_code`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/bin/day1.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day1.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/bin/day1.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/bin/day1.rs:23:57 [INFO] [stderr] | [INFO] [stderr] 23 | (temp_count, if temp_count == -1 { basement.or(Some(elem_pos+1)) } else {basement}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(elem_pos+1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent_of_code`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c3ae1f6127acea315404a11eec1f48bf87301000ea15a176f01798837e45cb91"` [INFO] running `"docker" "rm" "-f" "c3ae1f6127acea315404a11eec1f48bf87301000ea15a176f01798837e45cb91"` [INFO] [stdout] c3ae1f6127acea315404a11eec1f48bf87301000ea15a176f01798837e45cb91