[INFO] updating cached repository amcsi/rust-experimenting-password-cracker
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/amcsi/rust-experimenting-password-cracker
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/amcsi/rust-experimenting-password-cracker" "work/ex/clippy-test-run/sources/stable/gh/amcsi/rust-experimenting-password-cracker"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amcsi/rust-experimenting-password-cracker'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/amcsi/rust-experimenting-password-cracker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amcsi/rust-experimenting-password-cracker"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amcsi/rust-experimenting-password-cracker'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 677e18ceab200a0c382d1d9c8d7547991fbef1b2
[INFO] sha for GitHub repo amcsi/rust-experimenting-password-cracker: 677e18ceab200a0c382d1d9c8d7547991fbef1b2
[INFO] validating manifest of amcsi/rust-experimenting-password-cracker on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of amcsi/rust-experimenting-password-cracker on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing amcsi/rust-experimenting-password-cracker
[INFO] finished frobbing amcsi/rust-experimenting-password-cracker
[INFO] frobbed toml for amcsi/rust-experimenting-password-cracker written to work/ex/clippy-test-run/sources/stable/gh/amcsi/rust-experimenting-password-cracker/Cargo.toml
[INFO] started frobbing amcsi/rust-experimenting-password-cracker
[INFO] finished frobbing amcsi/rust-experimenting-password-cracker
[INFO] frobbed toml for amcsi/rust-experimenting-password-cracker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amcsi/rust-experimenting-password-cracker/Cargo.toml
[INFO] crate amcsi/rust-experimenting-password-cracker has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting amcsi/rust-experimenting-password-cracker against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/amcsi/rust-experimenting-password-cracker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 57956f834e2e315bf9bf9069b4842c0dce7ba03c207098f145580720c677f7fa
[INFO] running `"docker" "start" "-a" "57956f834e2e315bf9bf9069b4842c0dce7ba03c207098f145580720c677f7fa"`
[INFO] [stderr]     Checking password-cracker v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:17
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 return &password_bytes == &bytes;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&password_bytes == &bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:17
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 return &password_bytes == &bytes;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&password_bytes == &bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `reversed` manually
[INFO] [stderr]   --> src/main.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         let swap = reversed[digit - i - 1];
[INFO] [stderr] 40 | |         reversed[digit - i - 1] = reversed[i];
[INFO] [stderr] 41 | |         reversed[i] = swap;
[INFO] [stderr]    | |__________________________^ help: try: `reversed.swap(digit - i - 1, i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/main.rs:58:24
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 return &password_bytes == &bytes;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 return password_bytes == bytes;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `reversed` manually
[INFO] [stderr]   --> src/main.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         let swap = reversed[digit - i - 1];
[INFO] [stderr] 40 | |         reversed[digit - i - 1] = reversed[i];
[INFO] [stderr] 41 | |         reversed[i] = swap;
[INFO] [stderr]    | |__________________________^ help: try: `reversed.swap(digit - i - 1, i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/main.rs:58:24
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 return &password_bytes == &bytes;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 return password_bytes == bytes;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.80s
[INFO] running `"docker" "inspect" "57956f834e2e315bf9bf9069b4842c0dce7ba03c207098f145580720c677f7fa"`
[INFO] running `"docker" "rm" "-f" "57956f834e2e315bf9bf9069b4842c0dce7ba03c207098f145580720c677f7fa"`
[INFO] [stdout] 57956f834e2e315bf9bf9069b4842c0dce7ba03c207098f145580720c677f7fa