[INFO] updating cached repository amazingmo/references
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/amazingmo/references
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/amazingmo/references" "work/ex/clippy-test-run/sources/stable/gh/amazingmo/references"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amazingmo/references'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/amazingmo/references" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amazingmo/references"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amazingmo/references'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 86548b20b142cb5d14f112cf0e52c4033caba475
[INFO] sha for GitHub repo amazingmo/references: 86548b20b142cb5d14f112cf0e52c4033caba475
[INFO] validating manifest of amazingmo/references on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of amazingmo/references on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing amazingmo/references
[INFO] finished frobbing amazingmo/references
[INFO] frobbed toml for amazingmo/references written to work/ex/clippy-test-run/sources/stable/gh/amazingmo/references/Cargo.toml
[INFO] started frobbing amazingmo/references
[INFO] finished frobbing amazingmo/references
[INFO] frobbed toml for amazingmo/references written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amazingmo/references/Cargo.toml
[INFO] crate amazingmo/references has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting amazingmo/references against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/amazingmo/references:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 14cf5fa93a716a8e0d5ff6de08f4330328d11b7cf93a68bc04b8bfaf3ac84b8a
[INFO] running `"docker" "start" "-a" "14cf5fa93a716a8e0d5ff6de08f4330328d11b7cf93a68bc04b8bfaf3ac84b8a"`
[INFO] [stderr]     Checking references v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 |         let mut m = &mut y;
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:119:13
[INFO] [stderr]     |
[INFO] [stderr] 119 |     let mut v = vec![1973, 1968];
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |         let p = Point{x: 1000, y: 729};
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |         let s = smallest(&parabola);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 |         let mut m = &mut y;
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:119:13
[INFO] [stderr]     |
[INFO] [stderr] 119 |     let mut v = vec![1973, 1968];
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |         let p = Point{x: 1000, y: 729};
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |         let s = smallest(&parabola);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `m` is never read
[INFO] [stderr]    --> src/main.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 |         let mut m = &mut y;
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `m` is never read
[INFO] [stderr]    --> src/main.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 |         let mut m = &mut y;
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `x`
[INFO] [stderr]    --> src/main.rs:126:24
[INFO] [stderr]     |
[INFO] [stderr] 126 |         struct Point { x: i32, y: i32}
[INFO] [stderr]     |                        ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/main.rs:17:29
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for (_artist, works) in t
[INFO] [stderr]    |                             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for works in t.values_mut()
[INFO] [stderr]    |         ^^^^^    ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/main.rs:17:29
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for (_artist, works) in t
[INFO] [stderr]    |                             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for works in t.values_mut()
[INFO] [stderr]    |         ^^^^^    ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/main.rs:41:15
[INFO] [stderr]    |
[INFO] [stderr] 41 |     (1 .. n+1).fold(1, |a, b| a * b)
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     (1 .. n+1).fold(1, |a, b| a * b)
[INFO] [stderr]    |     ^^^^^^^^^^ help: use: `(1..=n)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:47:15
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn danger(p : &'static i32)
[INFO] [stderr]    |               ^^^^^^^^^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:58:1
[INFO] [stderr]    |
[INFO] [stderr] 58 | / fn smallest<'a>(v : &'a [i32]) -> &'a i32
[INFO] [stderr] 59 | | {
[INFO] [stderr] 60 | |     let mut tmp = &v[0];
[INFO] [stderr] 61 | |     for r in &v[1..]
[INFO] [stderr] ...  |
[INFO] [stderr] 68 | |     tmp
[INFO] [stderr] 69 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/main.rs:41:15
[INFO] [stderr]    |
[INFO] [stderr] 41 |     (1 .. n+1).fold(1, |a, b| a * b)
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     (1 .. n+1).fold(1, |a, b| a * b)
[INFO] [stderr]    |     ^^^^^^^^^^ help: use: `(1..=n)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:47:15
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn danger(p : &'static i32)
[INFO] [stderr]    |               ^^^^^^^^^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:58:1
[INFO] [stderr]    |
[INFO] [stderr] 58 | / fn smallest<'a>(v : &'a [i32]) -> &'a i32
[INFO] [stderr] 59 | | {
[INFO] [stderr] 60 | |     let mut tmp = &v[0];
[INFO] [stderr] 61 | |     for r in &v[1..]
[INFO] [stderr] ...  |
[INFO] [stderr] 68 | |     tmp
[INFO] [stderr] 69 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.70s
[INFO] running `"docker" "inspect" "14cf5fa93a716a8e0d5ff6de08f4330328d11b7cf93a68bc04b8bfaf3ac84b8a"`
[INFO] running `"docker" "rm" "-f" "14cf5fa93a716a8e0d5ff6de08f4330328d11b7cf93a68bc04b8bfaf3ac84b8a"`
[INFO] [stdout] 14cf5fa93a716a8e0d5ff6de08f4330328d11b7cf93a68bc04b8bfaf3ac84b8a