[INFO] updating cached repository amazingmo/Basics [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/amazingmo/Basics [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/amazingmo/Basics" "work/ex/clippy-test-run/sources/stable/gh/amazingmo/Basics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amazingmo/Basics'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/amazingmo/Basics" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amazingmo/Basics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amazingmo/Basics'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8c4f50b81a384f001af242baa3affc9e6d169ad [INFO] sha for GitHub repo amazingmo/Basics: a8c4f50b81a384f001af242baa3affc9e6d169ad [INFO] validating manifest of amazingmo/Basics on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amazingmo/Basics on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amazingmo/Basics [INFO] finished frobbing amazingmo/Basics [INFO] frobbed toml for amazingmo/Basics written to work/ex/clippy-test-run/sources/stable/gh/amazingmo/Basics/Cargo.toml [INFO] started frobbing amazingmo/Basics [INFO] finished frobbing amazingmo/Basics [INFO] frobbed toml for amazingmo/Basics written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amazingmo/Basics/Cargo.toml [INFO] crate amazingmo/Basics has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amazingmo/Basics against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/amazingmo/Basics:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d92f969ced3a06de76e9b39a0d434239ea2ccc79708f7ae3c21a784e2a359aea [INFO] running `"docker" "start" "-a" "d92f969ced3a06de76e9b39a0d434239ea2ccc79708f7ae3c21a784e2a359aea"` [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking chapter1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | #[macro_use] extern crate mime; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::prelude::*` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | use iron::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::status` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | use iron::status; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: approximate value of `f32::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let _pi : f32 = 3.14_f32; // Arbitrary underscores are allowed. [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:109:8 [INFO] [stderr] | [INFO] [stderr] 109 | if numbers.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `numbers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | writeln!(std::io::stderr(), "Usage: gcd +").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually [INFO] [stderr] --> src/main.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | / let t = m; [INFO] [stderr] 150 | | m = n; [INFO] [stderr] 151 | | n = t; [INFO] [stderr] | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | m = m % n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `m %= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chapter1`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | #[macro_use] extern crate mime; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::prelude::*` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | use iron::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::status` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | use iron::status; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: approximate value of `f32::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let _pi : f32 = 3.14_f32; // Arbitrary underscores are allowed. [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:109:8 [INFO] [stderr] | [INFO] [stderr] 109 | if numbers.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `numbers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | writeln!(std::io::stderr(), "Usage: gcd +").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually [INFO] [stderr] --> src/main.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | / let t = m; [INFO] [stderr] 150 | | m = n; [INFO] [stderr] 151 | | n = t; [INFO] [stderr] | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | m = m % n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `m %= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chapter1`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d92f969ced3a06de76e9b39a0d434239ea2ccc79708f7ae3c21a784e2a359aea"` [INFO] running `"docker" "rm" "-f" "d92f969ced3a06de76e9b39a0d434239ea2ccc79708f7ae3c21a784e2a359aea"` [INFO] [stdout] d92f969ced3a06de76e9b39a0d434239ea2ccc79708f7ae3c21a784e2a359aea