[INFO] updating cached repository amatho/indexgen-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/amatho/indexgen-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/amatho/indexgen-rs" "work/ex/clippy-test-run/sources/stable/gh/amatho/indexgen-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amatho/indexgen-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/amatho/indexgen-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amatho/indexgen-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amatho/indexgen-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3bf7784118a8bf117f3d0a5f6c658e5d7e07545f [INFO] sha for GitHub repo amatho/indexgen-rs: 3bf7784118a8bf117f3d0a5f6c658e5d7e07545f [INFO] validating manifest of amatho/indexgen-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amatho/indexgen-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amatho/indexgen-rs [INFO] finished frobbing amatho/indexgen-rs [INFO] frobbed toml for amatho/indexgen-rs written to work/ex/clippy-test-run/sources/stable/gh/amatho/indexgen-rs/Cargo.toml [INFO] started frobbing amatho/indexgen-rs [INFO] finished frobbing amatho/indexgen-rs [INFO] frobbed toml for amatho/indexgen-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amatho/indexgen-rs/Cargo.toml [INFO] crate amatho/indexgen-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amatho/indexgen-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/amatho/indexgen-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44ce330b6bc1b8cdb43d5eae50af3cbfae8eb73944eb39a06308dad9739e9dc0 [INFO] running `"docker" "start" "-a" "44ce330b6bc1b8cdb43d5eae50af3cbfae8eb73944eb39a06308dad9739e9dc0"` [INFO] [stderr] Checking indexgen v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | fn get_wd(args: &Vec) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | let file_type = match path.is_dir() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 72 | | true => String::from("dir"), [INFO] [stderr] 73 | | false => String::from("file") [INFO] [stderr] 74 | | }; [INFO] [stderr] | |___^ help: consider using an if/else expression: `if path.is_dir() { String::from("dir") } else { String::from("file") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | fn get_wd(args: &Vec) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | let file_type = match path.is_dir() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 72 | | true => String::from("dir"), [INFO] [stderr] 73 | | false => String::from("file") [INFO] [stderr] 74 | | }; [INFO] [stderr] | |___^ help: consider using an if/else expression: `if path.is_dir() { String::from("dir") } else { String::from("file") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `"docker" "inspect" "44ce330b6bc1b8cdb43d5eae50af3cbfae8eb73944eb39a06308dad9739e9dc0"` [INFO] running `"docker" "rm" "-f" "44ce330b6bc1b8cdb43d5eae50af3cbfae8eb73944eb39a06308dad9739e9dc0"` [INFO] [stdout] 44ce330b6bc1b8cdb43d5eae50af3cbfae8eb73944eb39a06308dad9739e9dc0