[INFO] updating cached repository amar-laksh/ros2soc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/amar-laksh/ros2soc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/amar-laksh/ros2soc" "work/ex/clippy-test-run/sources/stable/gh/amar-laksh/ros2soc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amar-laksh/ros2soc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/amar-laksh/ros2soc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amar-laksh/ros2soc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amar-laksh/ros2soc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 74f4e3014a6357c2454c2c7c454252f296d09e76
[INFO] sha for GitHub repo amar-laksh/ros2soc: 74f4e3014a6357c2454c2c7c454252f296d09e76
[INFO] validating manifest of amar-laksh/ros2soc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of amar-laksh/ros2soc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing amar-laksh/ros2soc
[INFO] finished frobbing amar-laksh/ros2soc
[INFO] frobbed toml for amar-laksh/ros2soc written to work/ex/clippy-test-run/sources/stable/gh/amar-laksh/ros2soc/Cargo.toml
[INFO] started frobbing amar-laksh/ros2soc
[INFO] finished frobbing amar-laksh/ros2soc
[INFO] frobbed toml for amar-laksh/ros2soc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amar-laksh/ros2soc/Cargo.toml
[INFO] crate amar-laksh/ros2soc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting amar-laksh/ros2soc against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/amar-laksh/ros2soc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e8c56787b3c2ea8b14b49fb10f26f4c82a4d409416449ebe46a5a24256ca3e1b
[INFO] running `"docker" "start" "-a" "e8c56787b3c2ea8b14b49fb10f26f4c82a4d409416449ebe46a5a24256ca3e1b"`
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking assert_cli v0.6.3
[INFO] [stderr]     Checking ros2soc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return output;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     return _input;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `_input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return output;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     return _input;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `_input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:67:34
[INFO] [stderr]    |
[INFO] [stderr] 67 |             env::var("ROS2_DIR").unwrap_or(format!("/home/{}/ros2_ws/", env::var("USER").unwrap()));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("/home/{}/ros2_ws/", env::var("USER").unwrap()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:69:14
[INFO] [stderr]    |
[INFO] [stderr] 69 |             .unwrap_or(format!("/home/{}/ros2_ws/", env::var("USER").unwrap()));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("/home/{}/ros2_ws/", env::var("USER").unwrap()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:67:34
[INFO] [stderr]    |
[INFO] [stderr] 67 |             env::var("ROS2_DIR").unwrap_or(format!("/home/{}/ros2_ws/", env::var("USER").unwrap()));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("/home/{}/ros2_ws/", env::var("USER").unwrap()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:69:14
[INFO] [stderr]    |
[INFO] [stderr] 69 |             .unwrap_or(format!("/home/{}/ros2_ws/", env::var("USER").unwrap()));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("/home/{}/ros2_ws/", env::var("USER").unwrap()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.22s
[INFO] running `"docker" "inspect" "e8c56787b3c2ea8b14b49fb10f26f4c82a4d409416449ebe46a5a24256ca3e1b"`
[INFO] running `"docker" "rm" "-f" "e8c56787b3c2ea8b14b49fb10f26f4c82a4d409416449ebe46a5a24256ca3e1b"`
[INFO] [stdout] e8c56787b3c2ea8b14b49fb10f26f4c82a4d409416449ebe46a5a24256ca3e1b