[INFO] updating cached repository alyjak/distributed-chat
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/alyjak/distributed-chat
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/alyjak/distributed-chat" "work/ex/clippy-test-run/sources/stable/gh/alyjak/distributed-chat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alyjak/distributed-chat'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/alyjak/distributed-chat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alyjak/distributed-chat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alyjak/distributed-chat'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 100050eb8b2a9e91ccdc97cb89ac857cafdad61b
[INFO] sha for GitHub repo alyjak/distributed-chat: 100050eb8b2a9e91ccdc97cb89ac857cafdad61b
[INFO] validating manifest of alyjak/distributed-chat on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of alyjak/distributed-chat on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing alyjak/distributed-chat
[INFO] finished frobbing alyjak/distributed-chat
[INFO] frobbed toml for alyjak/distributed-chat written to work/ex/clippy-test-run/sources/stable/gh/alyjak/distributed-chat/Cargo.toml
[INFO] started frobbing alyjak/distributed-chat
[INFO] finished frobbing alyjak/distributed-chat
[INFO] frobbed toml for alyjak/distributed-chat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alyjak/distributed-chat/Cargo.toml
[INFO] crate alyjak/distributed-chat has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting alyjak/distributed-chat against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alyjak/distributed-chat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3640713557d69e7dfa1df2396786d55ec83e8b4cdc27d4902fb082d4f5d13590
[INFO] running `"docker" "start" "-a" "3640713557d69e7dfa1df2396786d55ec83e8b4cdc27d4902fb082d4f5d13590"`
[INFO] [stderr]     Checking tokio-reactor v0.1.6
[INFO] [stderr]     Checking tokio-uds v0.2.3
[INFO] [stderr]     Checking tokio-tcp v0.1.2
[INFO] [stderr]     Checking tokio-udp v0.1.2
[INFO] [stderr]     Checking tokio v0.1.11
[INFO] [stderr]     Checking assignment v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/message.rs:38:23
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub const HDR_0: u8 = 0b10101010;
[INFO] [stderr]    |                       ^^^^^^^^^^ help: consider: `0b1010_1010`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/message.rs:39:23
[INFO] [stderr]    |
[INFO] [stderr] 39 | pub const HDR_1: u8 = 0b01010101;
[INFO] [stderr]    |                       ^^^^^^^^^^ help: consider: `0b0101_0101`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/message.rs:38:23
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub const HDR_0: u8 = 0b10101010;
[INFO] [stderr]    |                       ^^^^^^^^^^ help: consider: `0b1010_1010`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/message.rs:39:23
[INFO] [stderr]    |
[INFO] [stderr] 39 | pub const HDR_1: u8 = 0b01010101;
[INFO] [stderr]    |                       ^^^^^^^^^^ help: consider: `0b0101_0101`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 |         01u8 => Ok(MsgTyp::PM),
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::zero_prefixed_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 119 |         1u8 => Ok(MsgTyp::PM),
[INFO] [stderr]     |         ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 119 |         0o1u8 => Ok(MsgTyp::PM),
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |         02u8 => Ok(MsgTyp::BC),
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 120 |         2u8 => Ok(MsgTyp::BC),
[INFO] [stderr]     |         ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 120 |         0o2u8 => Ok(MsgTyp::BC),
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |         03u8 => Ok(MsgTyp::BBC),
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 121 |         3u8 => Ok(MsgTyp::BBC),
[INFO] [stderr]     |         ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 121 |         0o3u8 => Ok(MsgTyp::BBC),
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:135:23
[INFO] [stderr]     |
[INFO] [stderr] 135 |         MsgTyp::PM => 01u8,
[INFO] [stderr]     |                       ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 135 |         MsgTyp::PM => 1u8,
[INFO] [stderr]     |                       ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 135 |         MsgTyp::PM => 0o1u8,
[INFO] [stderr]     |                       ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:136:23
[INFO] [stderr]     |
[INFO] [stderr] 136 |         MsgTyp::BC => 02u8,
[INFO] [stderr]     |                       ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 136 |         MsgTyp::BC => 2u8,
[INFO] [stderr]     |                       ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 136 |         MsgTyp::BC => 0o2u8,
[INFO] [stderr]     |                       ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:137:24
[INFO] [stderr]     |
[INFO] [stderr] 137 |         MsgTyp::BBC => 03u8,
[INFO] [stderr]     |                        ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 137 |         MsgTyp::BBC => 3u8,
[INFO] [stderr]     |                        ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 137 |         MsgTyp::BBC => 0o3u8,
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/message.rs:267:9
[INFO] [stderr]     |
[INFO] [stderr] 267 |         msg
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/message.rs:266:19
[INFO] [stderr]     |
[INFO] [stderr] 266 |         let msg = Message::new(typ, self.msgnum, self.username.clone(), to, content);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 |         01u8 => Ok(MsgTyp::PM),
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::zero_prefixed_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 119 |         1u8 => Ok(MsgTyp::PM),
[INFO] [stderr]     |         ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 119 |         0o1u8 => Ok(MsgTyp::PM),
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |         02u8 => Ok(MsgTyp::BC),
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 120 |         2u8 => Ok(MsgTyp::BC),
[INFO] [stderr]     |         ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 120 |         0o2u8 => Ok(MsgTyp::BC),
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |         03u8 => Ok(MsgTyp::BBC),
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 121 |         3u8 => Ok(MsgTyp::BBC),
[INFO] [stderr]     |         ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 121 |         0o3u8 => Ok(MsgTyp::BBC),
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:135:23
[INFO] [stderr]     |
[INFO] [stderr] 135 |         MsgTyp::PM => 01u8,
[INFO] [stderr]     |                       ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 135 |         MsgTyp::PM => 1u8,
[INFO] [stderr]     |                       ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 135 |         MsgTyp::PM => 0o1u8,
[INFO] [stderr]     |                       ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:136:23
[INFO] [stderr]     |
[INFO] [stderr] 136 |         MsgTyp::BC => 02u8,
[INFO] [stderr]     |                       ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 136 |         MsgTyp::BC => 2u8,
[INFO] [stderr]     |                       ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 136 |         MsgTyp::BC => 0o2u8,
[INFO] [stderr]     |                       ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]    --> src/message.rs:137:24
[INFO] [stderr]     |
[INFO] [stderr] 137 |         MsgTyp::BBC => 03u8,
[INFO] [stderr]     |                        ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]     |
[INFO] [stderr] 137 |         MsgTyp::BBC => 3u8,
[INFO] [stderr]     |                        ^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]     |
[INFO] [stderr] 137 |         MsgTyp::BBC => 0o3u8,
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/message.rs:267:9
[INFO] [stderr]     |
[INFO] [stderr] 267 |         msg
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/message.rs:266:19
[INFO] [stderr]     |
[INFO] [stderr] 266 |         let msg = Message::new(typ, self.msgnum, self.username.clone(), to, content);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/message.rs:117:22
[INFO] [stderr]     |
[INFO] [stderr] 117 | fn byte_to_typ(byte: &u8) -> Result<MsgTyp, String> {
[INFO] [stderr]     |                      ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/message.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 | /         write!(
[INFO] [stderr] 227 | |             f,
[INFO] [stderr] 228 | |             "[{} {}]",
[INFO] [stderr] 229 | |             unsafe { from_utf8_unchecked(&self.from[..]) },
[INFO] [stderr] 230 | |             self.typ
[INFO] [stderr] 231 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/message.rs:235:17
[INFO] [stderr]     |
[INFO] [stderr] 235 |                 write!(f, ": {}", unsafe { from_utf8_unchecked(&self.content[..]) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/message.rs:336:12
[INFO] [stderr]     |
[INFO] [stderr] 336 |         if buf.len() < 1 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/message.rs:347:12
[INFO] [stderr]     |
[INFO] [stderr] 347 |         if buf.len() < 1 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/message.rs:117:22
[INFO] [stderr]     |
[INFO] [stderr] 117 | fn byte_to_typ(byte: &u8) -> Result<MsgTyp, String> {
[INFO] [stderr]     |                      ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/message.rs:426:13
[INFO] [stderr]     |
[INFO] [stderr] 426 |             self.msgnum.clone(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.msgnum`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/message.rs:536:9
[INFO] [stderr]     |
[INFO] [stderr] 536 | /         match sink.start_send(self.msg.clone()) {
[INFO] [stderr] 537 | |             Err(_) => return Err(()),
[INFO] [stderr] 538 | |             _ => {}
[INFO] [stderr] 539 | |         };
[INFO] [stderr]     | |_________^ help: try this: `if let Err(_) = sink.start_send(self.msg.clone()) { return Err(()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/message.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 | /         write!(
[INFO] [stderr] 227 | |             f,
[INFO] [stderr] 228 | |             "[{} {}]",
[INFO] [stderr] 229 | |             unsafe { from_utf8_unchecked(&self.from[..]) },
[INFO] [stderr] 230 | |             self.typ
[INFO] [stderr] 231 | |         );
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/message.rs:235:17
[INFO] [stderr]     |
[INFO] [stderr] 235 |                 write!(f, ": {}", unsafe { from_utf8_unchecked(&self.content[..]) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:100:44
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let (sink, stream) = MsgCodec::new(addr.clone()).framed(sock).split();
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:137:21
[INFO] [stderr]     |
[INFO] [stderr] 137 |                     self.addr.clone(),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:169:25
[INFO] [stderr]     |
[INFO] [stderr] 169 |         to: Bytes::from(addr.clone().to_string().into_bytes()),
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:210:48
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 u_map.insert(msg.from.clone(), addr.clone());
[INFO] [stderr]     |                                                ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:218:52
[INFO] [stderr]     |
[INFO] [stderr] 218 |                     let peer = MsgClient::new(ack, addr.clone(), sock_map.clone());
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:227:44
[INFO] [stderr]     |
[INFO] [stderr] 227 |             let peer = MsgClient::new(ack, addr.clone(), sock_map.clone());
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/terminal.rs:53:22
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn into_bytes(peers: &Vec<SocketAddr>) -> Bytes {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^ help: change this to: `&[SocketAddr]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `terminal::StdioSocket`
[INFO] [stderr]   --> src/terminal.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 | /     pub fn new() -> StdioSocket {
[INFO] [stderr] 74 | |         StdioSocket {
[INFO] [stderr] 75 | |             stdin: io::stdin(),
[INFO] [stderr] 76 | |             stdout: io::stdout(),
[INFO] [stderr] 77 | |         }
[INFO] [stderr] 78 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 72 | impl Default for terminal::StdioSocket {
[INFO] [stderr] 73 |     fn default() -> Self {
[INFO] [stderr] 74 |         Self::new()
[INFO] [stderr] 75 |     }
[INFO] [stderr] 76 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/message.rs:336:12
[INFO] [stderr]     |
[INFO] [stderr] 336 |         if buf.len() < 1 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/terminal.rs:219:25
[INFO] [stderr]     |
[INFO] [stderr] 219 | /                         if !map.contains_key(&addr) {
[INFO] [stderr] 220 | |                             map.insert(addr, Box::new(PeerConfig::new(addr)));
[INFO] [stderr] 221 | |                         }
[INFO] [stderr]     | |_________________________^ help: consider using: `map.entry(addr).or_insert(Box::new(PeerConfig::new(addr)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/message.rs:347:12
[INFO] [stderr]     |
[INFO] [stderr] 347 |         if buf.len() < 1 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/terminal.rs:256:39
[INFO] [stderr]     |
[INFO] [stderr] 256 |                 let connected_peers = s_map.keys().map(|k| k.clone()).collect();
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `s_map.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/terminal.rs:256:60
[INFO] [stderr]     |
[INFO] [stderr] 256 |                 let connected_peers = s_map.keys().map(|k| k.clone()).collect();
[INFO] [stderr]     |                                                            ^^^^^^^^^ help: try dereferencing it: `*k`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/terminal.rs:265:36
[INFO] [stderr]     |
[INFO] [stderr] 265 |                 out.write_buf(&mut format!("{}", HELP).into_buf())
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `HELP.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/terminal.rs:320:49
[INFO] [stderr]     |
[INFO] [stderr] 320 |                             if line.starts_with("/") {
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/terminal.rs:352:33
[INFO] [stderr]     |
[INFO] [stderr] 352 |                                 s_map.keys().map(|k| k.clone()).collect()
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `s_map.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/terminal.rs:352:54
[INFO] [stderr]     |
[INFO] [stderr] 352 |                                 s_map.keys().map(|k| k.clone()).collect()
[INFO] [stderr]     |                                                      ^^^^^^^^^ help: try dereferencing it: `*k`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/terminal.rs:373:44
[INFO] [stderr]     |
[INFO] [stderr] 373 |                         out.write_buf(&mut format!("+ ").into_buf())?;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^ help: consider using .to_string(): `"+ ".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/terminal.rs:392:48
[INFO] [stderr]     |
[INFO] [stderr] 392 |                             out.write_buf(&mut format!("\rok\n> ").into_buf())?;
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\rok\n> ".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/terminal.rs:487:34
[INFO] [stderr]     |
[INFO] [stderr] 487 |               PeerVolume::Quiet => match item.typ {
[INFO] [stderr]     |  __________________________________^
[INFO] [stderr] 488 | |                 MsgTyp::PM => {
[INFO] [stderr] 489 | |                     dst.put(format!("{}\n", item).as_bytes());
[INFO] [stderr] 490 | |                 }
[INFO] [stderr] 491 | |                 _ => {}
[INFO] [stderr] 492 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 487 |             PeerVolume::Quiet => if let MsgTyp::PM = item.typ {
[INFO] [stderr] 488 |     dst.put(format!("{}\n", item).as_bytes());
[INFO] [stderr] 489 | },
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/terminal.rs:530:9
[INFO] [stderr]     |
[INFO] [stderr] 530 | /         match self.sink.start_send(self.msg.clone()) {
[INFO] [stderr] 531 | |             Err(_) => return Err(()),
[INFO] [stderr] 532 | |             _ => {}
[INFO] [stderr] 533 | |         };
[INFO] [stderr]     | |_________^ help: try this: `if let Err(_) = self.sink.start_send(self.msg.clone()) { return Err(()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/message.rs:426:13
[INFO] [stderr]     |
[INFO] [stderr] 426 |             self.msgnum.clone(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.msgnum`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/message.rs:536:9
[INFO] [stderr]     |
[INFO] [stderr] 536 | /         match sink.start_send(self.msg.clone()) {
[INFO] [stderr] 537 | |             Err(_) => return Err(()),
[INFO] [stderr] 538 | |             _ => {}
[INFO] [stderr] 539 | |         };
[INFO] [stderr]     | |_________^ help: try this: `if let Err(_) = sink.start_send(self.msg.clone()) { return Err(()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:100:44
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let (sink, stream) = MsgCodec::new(addr.clone()).framed(sock).split();
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:137:21
[INFO] [stderr]     |
[INFO] [stderr] 137 |                     self.addr.clone(),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:169:25
[INFO] [stderr]     |
[INFO] [stderr] 169 |         to: Bytes::from(addr.clone().to_string().into_bytes()),
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:210:48
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 u_map.insert(msg.from.clone(), addr.clone());
[INFO] [stderr]     |                                                ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:218:52
[INFO] [stderr]     |
[INFO] [stderr] 218 |                     let peer = MsgClient::new(ack, addr.clone(), sock_map.clone());
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/peer.rs:227:44
[INFO] [stderr]     |
[INFO] [stderr] 227 |             let peer = MsgClient::new(ack, addr.clone(), sock_map.clone());
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/terminal.rs:53:22
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn into_bytes(peers: &Vec<SocketAddr>) -> Bytes {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^ help: change this to: `&[SocketAddr]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `terminal::StdioSocket`
[INFO] [stderr]   --> src/terminal.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 | /     pub fn new() -> StdioSocket {
[INFO] [stderr] 74 | |         StdioSocket {
[INFO] [stderr] 75 | |             stdin: io::stdin(),
[INFO] [stderr] 76 | |             stdout: io::stdout(),
[INFO] [stderr] 77 | |         }
[INFO] [stderr] 78 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 72 | impl Default for terminal::StdioSocket {
[INFO] [stderr] 73 |     fn default() -> Self {
[INFO] [stderr] 74 |         Self::new()
[INFO] [stderr] 75 |     }
[INFO] [stderr] 76 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/terminal.rs:219:25
[INFO] [stderr]     |
[INFO] [stderr] 219 | /                         if !map.contains_key(&addr) {
[INFO] [stderr] 220 | |                             map.insert(addr, Box::new(PeerConfig::new(addr)));
[INFO] [stderr] 221 | |                         }
[INFO] [stderr]     | |_________________________^ help: consider using: `map.entry(addr).or_insert(Box::new(PeerConfig::new(addr)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/terminal.rs:256:39
[INFO] [stderr]     |
[INFO] [stderr] 256 |                 let connected_peers = s_map.keys().map(|k| k.clone()).collect();
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `s_map.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/terminal.rs:256:60
[INFO] [stderr]     |
[INFO] [stderr] 256 |                 let connected_peers = s_map.keys().map(|k| k.clone()).collect();
[INFO] [stderr]     |                                                            ^^^^^^^^^ help: try dereferencing it: `*k`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/terminal.rs:265:36
[INFO] [stderr]     |
[INFO] [stderr] 265 |                 out.write_buf(&mut format!("{}", HELP).into_buf())
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `HELP.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/terminal.rs:320:49
[INFO] [stderr]     |
[INFO] [stderr] 320 |                             if line.starts_with("/") {
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/terminal.rs:352:33
[INFO] [stderr]     |
[INFO] [stderr] 352 |                                 s_map.keys().map(|k| k.clone()).collect()
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `s_map.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/terminal.rs:352:54
[INFO] [stderr]     |
[INFO] [stderr] 352 |                                 s_map.keys().map(|k| k.clone()).collect()
[INFO] [stderr]     |                                                      ^^^^^^^^^ help: try dereferencing it: `*k`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/terminal.rs:373:44
[INFO] [stderr]     |
[INFO] [stderr] 373 |                         out.write_buf(&mut format!("+ ").into_buf())?;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^ help: consider using .to_string(): `"+ ".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/terminal.rs:392:48
[INFO] [stderr]     |
[INFO] [stderr] 392 |                             out.write_buf(&mut format!("\rok\n> ").into_buf())?;
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\rok\n> ".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/terminal.rs:487:34
[INFO] [stderr]     |
[INFO] [stderr] 487 |               PeerVolume::Quiet => match item.typ {
[INFO] [stderr]     |  __________________________________^
[INFO] [stderr] 488 | |                 MsgTyp::PM => {
[INFO] [stderr] 489 | |                     dst.put(format!("{}\n", item).as_bytes());
[INFO] [stderr] 490 | |                 }
[INFO] [stderr] 491 | |                 _ => {}
[INFO] [stderr] 492 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 487 |             PeerVolume::Quiet => if let MsgTyp::PM = item.typ {
[INFO] [stderr] 488 |     dst.put(format!("{}\n", item).as_bytes());
[INFO] [stderr] 489 | },
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/terminal.rs:530:9
[INFO] [stderr]     |
[INFO] [stderr] 530 | /         match self.sink.start_send(self.msg.clone()) {
[INFO] [stderr] 531 | |             Err(_) => return Err(()),
[INFO] [stderr] 532 | |             _ => {}
[INFO] [stderr] 533 | |         };
[INFO] [stderr]     | |_________^ help: try this: `if let Err(_) = self.sink.start_send(self.msg.clone()) { return Err(()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 | /     print!(
[INFO] [stderr] 39 | |         "Welcome {}, binding to address: {} and listening for messages\n",
[INFO] [stderr] 40 | |         matches.value_of("NAME").unwrap(),
[INFO] [stderr] 41 | |         self_addr
[INFO] [stderr] 42 | |     );
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 | /     print!(
[INFO] [stderr] 39 | |         "Welcome {}, binding to address: {} and listening for messages\n",
[INFO] [stderr] 40 | |         matches.value_of("NAME").unwrap(),
[INFO] [stderr] 41 | |         self_addr
[INFO] [stderr] 42 | |     );
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:168:26
[INFO] [stderr]     |
[INFO] [stderr] 168 |             p_map.insert(addr.clone(), Box::new(PeerConfig::new(addr.clone())));
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:168:65
[INFO] [stderr]     |
[INFO] [stderr] 168 |             p_map.insert(addr.clone(), Box::new(PeerConfig::new(addr.clone())));
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 |         addr.clone(),
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:168:26
[INFO] [stderr]     |
[INFO] [stderr] 168 |             p_map.insert(addr.clone(), Box::new(PeerConfig::new(addr.clone())));
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:168:65
[INFO] [stderr]     |
[INFO] [stderr] 168 |             p_map.insert(addr.clone(), Box::new(PeerConfig::new(addr.clone())));
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 |         addr.clone(),
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: try removing the `clone` call: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 18.16s
[INFO] running `"docker" "inspect" "3640713557d69e7dfa1df2396786d55ec83e8b4cdc27d4902fb082d4f5d13590"`
[INFO] running `"docker" "rm" "-f" "3640713557d69e7dfa1df2396786d55ec83e8b4cdc27d4902fb082d4f5d13590"`
[INFO] [stdout] 3640713557d69e7dfa1df2396786d55ec83e8b4cdc27d4902fb082d4f5d13590