[INFO] updating cached repository alxeg/flibooks-es
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/alxeg/flibooks-es
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/alxeg/flibooks-es" "work/ex/clippy-test-run/sources/stable/gh/alxeg/flibooks-es"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alxeg/flibooks-es'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/alxeg/flibooks-es" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alxeg/flibooks-es"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alxeg/flibooks-es'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ed23d9560ff10de89e8e18848fa6d60e78d5b7a0
[INFO] sha for GitHub repo alxeg/flibooks-es: ed23d9560ff10de89e8e18848fa6d60e78d5b7a0
[INFO] validating manifest of alxeg/flibooks-es on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of alxeg/flibooks-es on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing alxeg/flibooks-es
[INFO] finished frobbing alxeg/flibooks-es
[INFO] frobbed toml for alxeg/flibooks-es written to work/ex/clippy-test-run/sources/stable/gh/alxeg/flibooks-es/Cargo.toml
[INFO] started frobbing alxeg/flibooks-es
[INFO] finished frobbing alxeg/flibooks-es
[INFO] frobbed toml for alxeg/flibooks-es written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alxeg/flibooks-es/Cargo.toml
[INFO] crate alxeg/flibooks-es has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting alxeg/flibooks-es against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alxeg/flibooks-es:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b32270e62edf0ff6f7ae6e2f947eebeda9b3912cec980b83ca5ec47aed84e43f
[INFO] running `"docker" "start" "-a" "b32270e62edf0ff6f7ae6e2f947eebeda9b3912cec980b83ca5ec47aed84e43f"`
[INFO] [stderr]     Checking pdqselect v0.1.0
[INFO] [stderr]     Checking clamp v0.1.0
[INFO] [stderr]    Compiling nom v2.2.1
[INFO] [stderr]     Checking elastic_requests v0.20.10
[INFO] [stderr]    Compiling syn v0.11.11
[INFO] [stderr]     Checking log v0.4.5
[INFO] [stderr]     Checking serde_yaml v0.7.5
[INFO] [stderr]     Checking uuid v0.7.1
[INFO] [stderr]     Checking num-complex v0.2.0
[INFO] [stderr]     Checking approx v0.2.1
[INFO] [stderr]    Compiling num-integer v0.1.39
[INFO] [stderr]    Compiling serde_json v1.0.28
[INFO] [stderr]     Checking tokio-io v0.1.8
[INFO] [stderr]     Checking mio v0.6.16
[INFO] [stderr]     Checking want v0.0.4
[INFO] [stderr]     Checking log v0.3.9
[INFO] [stderr]     Checking alga v0.6.0
[INFO] [stderr]    Compiling chrono v0.4.6
[INFO] [stderr]     Checking serde-value v0.5.2
[INFO] [stderr]     Checking error-chain v0.11.0
[INFO] [stderr]     Checking flate2 v1.0.2
[INFO] [stderr]     Checking tokio-threadpool v0.1.6
[INFO] [stderr]     Checking mime v0.2.6
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking mio-uds v0.6.7
[INFO] [stderr]     Checking geo v0.4.13
[INFO] [stderr]     Checking elastic_responses v0.20.10
[INFO] [stderr]     Checking tokio-reactor v0.1.5
[INFO] [stderr]     Checking zip v0.4.2
[INFO] [stderr]     Checking log4rs v0.8.0
[INFO] [stderr]     Checking hyper v0.10.13
[INFO] [stderr]     Checking nalgebra v0.15.3
[INFO] [stderr]    Compiling serde_derive_internals v0.15.1
[INFO] [stderr]    Compiling pest_derive v1.0.8
[INFO] [stderr]     Checking config v0.9.0
[INFO] [stderr]     Checking tokio-fs v0.1.3
[INFO] [stderr]     Checking mime_guess v1.8.6
[INFO] [stderr]     Checking geohash v0.4.0
[INFO] [stderr]     Checking tokio-udp v0.1.2
[INFO] [stderr]     Checking tokio-tcp v0.1.1
[INFO] [stderr]     Checking tokio-uds v0.2.1
[INFO] [stderr]    Compiling elastic_types_derive_internals v0.20.10
[INFO] [stderr]     Checking jsonpath v0.1.1
[INFO] [stderr]     Checking iron v0.6.0
[INFO] [stderr]     Checking tokio v0.1.8
[INFO] [stderr]    Compiling elastic_types_derive v0.20.10
[INFO] [stderr]     Checking persistent v0.4.0
[INFO] [stderr]     Checking router v0.6.0
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]     Checking bodyparser v0.8.0
[INFO] [stderr]     Checking hyper v0.11.27
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper-tls v0.1.4
[INFO] [stderr]     Checking reqwest v0.8.8
[INFO] [stderr]     Checking elastic_reqwest v0.20.10
[INFO] [stderr]     Checking spade v1.5.1
[INFO] [stderr]     Checking geo v0.6.3
[INFO] [stderr]     Checking geojson v0.9.1
[INFO] [stderr]     Checking elastic_types v0.20.10
[INFO] [stderr]     Checking elastic v0.20.10
[INFO] [stderr]     Checking flibooks-es v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `id`
[INFO] [stderr]    --> src/serve/mod.rs:336:13
[INFO] [stderr]     |
[INFO] [stderr] 336 |     let ref id = req.extensions.get::<Router>().unwrap().find("id").unwrap();
[INFO] [stderr]     |             ^^ help: consider using `_id` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/conf.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         match env::var("FLI_CONFIG") {
[INFO] [stderr] 30 | |             Ok(config_file) => {
[INFO] [stderr] 31 | |                 s.merge(File::with_name(config_file.as_str()))?;
[INFO] [stderr] 32 | |             }
[INFO] [stderr] 33 | |             _ => (),
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 29 |         if let Ok(config_file) = env::var("FLI_CONFIG") {
[INFO] [stderr] 30 |     s.merge(File::with_name(config_file.as_str()))?;
[INFO] [stderr] 31 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/parse.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 |             let inpx = format!("{}", file.name());
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `file.name().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parse.rs:43:52
[INFO] [stderr]    |
[INFO] [stderr] 43 |                 let mut rec = process_book(l.split("\x04").collect());
[INFO] [stderr]    |                                                    ^^^^^^ help: try using a char instead: `'\x04'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parse.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 | /                     match op {
[INFO] [stderr] 66 | |                         Err(op) => error!("error processing document: {:?}", op),
[INFO] [stderr] 67 | |                         _ => (),
[INFO] [stderr] 68 | |                     }
[INFO] [stderr]    | |_____________________^ help: try this: `if let Err(op) = op { error!("error processing document: {:?}", op) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parse.rs:80:43
[INFO] [stderr]    |
[INFO] [stderr] 80 |     let authors: Vec<_> = fields[0].split(":").filter(|s| !s.is_empty()).collect();
[INFO] [stderr]    |                                           ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parse.rs:81:42
[INFO] [stderr]    |
[INFO] [stderr] 81 |     let genres: Vec<_> = fields[1].split(":").filter(|s| !s.is_empty()).collect();
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/serve/mod.rs:336:9
[INFO] [stderr]     |
[INFO] [stderr] 336 |     let ref id = req.extensions.get::<Router>().unwrap().find("id").unwrap();
[INFO] [stderr]     |     ----^^^^^^--------------------------------------------------------------- help: try: `let id = &req.extensions.get::<Router>().unwrap().find("id").unwrap();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `id`
[INFO] [stderr]    --> src/serve/mod.rs:336:13
[INFO] [stderr]     |
[INFO] [stderr] 336 |     let ref id = req.extensions.get::<Router>().unwrap().find("id").unwrap();
[INFO] [stderr]     |             ^^ help: consider using `_id` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/conf.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         match env::var("FLI_CONFIG") {
[INFO] [stderr] 30 | |             Ok(config_file) => {
[INFO] [stderr] 31 | |                 s.merge(File::with_name(config_file.as_str()))?;
[INFO] [stderr] 32 | |             }
[INFO] [stderr] 33 | |             _ => (),
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 29 |         if let Ok(config_file) = env::var("FLI_CONFIG") {
[INFO] [stderr] 30 |     s.merge(File::with_name(config_file.as_str()))?;
[INFO] [stderr] 31 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/parse.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 |             let inpx = format!("{}", file.name());
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `file.name().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parse.rs:43:52
[INFO] [stderr]    |
[INFO] [stderr] 43 |                 let mut rec = process_book(l.split("\x04").collect());
[INFO] [stderr]    |                                                    ^^^^^^ help: try using a char instead: `'\x04'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parse.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 | /                     match op {
[INFO] [stderr] 66 | |                         Err(op) => error!("error processing document: {:?}", op),
[INFO] [stderr] 67 | |                         _ => (),
[INFO] [stderr] 68 | |                     }
[INFO] [stderr]    | |_____________________^ help: try this: `if let Err(op) = op { error!("error processing document: {:?}", op) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parse.rs:80:43
[INFO] [stderr]    |
[INFO] [stderr] 80 |     let authors: Vec<_> = fields[0].split(":").filter(|s| !s.is_empty()).collect();
[INFO] [stderr]    |                                           ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parse.rs:81:42
[INFO] [stderr]    |
[INFO] [stderr] 81 |     let genres: Vec<_> = fields[1].split(":").filter(|s| !s.is_empty()).collect();
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/serve/mod.rs:336:9
[INFO] [stderr]     |
[INFO] [stderr] 336 |     let ref id = req.extensions.get::<Router>().unwrap().find("id").unwrap();
[INFO] [stderr]     |     ----^^^^^^--------------------------------------------------------------- help: try: `let id = &req.extensions.get::<Router>().unwrap().find("id").unwrap();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2m 11s
[INFO] running `"docker" "inspect" "b32270e62edf0ff6f7ae6e2f947eebeda9b3912cec980b83ca5ec47aed84e43f"`
[INFO] running `"docker" "rm" "-f" "b32270e62edf0ff6f7ae6e2f947eebeda9b3912cec980b83ca5ec47aed84e43f"`
[INFO] [stdout] b32270e62edf0ff6f7ae6e2f947eebeda9b3912cec980b83ca5ec47aed84e43f