[INFO] updating cached repository alxdb/rusty_ogl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alxdb/rusty_ogl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alxdb/rusty_ogl" "work/ex/clippy-test-run/sources/stable/gh/alxdb/rusty_ogl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alxdb/rusty_ogl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alxdb/rusty_ogl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alxdb/rusty_ogl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alxdb/rusty_ogl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0411b30200331919930959f5c3d17f7181d06839 [INFO] sha for GitHub repo alxdb/rusty_ogl: 0411b30200331919930959f5c3d17f7181d06839 [INFO] validating manifest of alxdb/rusty_ogl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alxdb/rusty_ogl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alxdb/rusty_ogl [INFO] finished frobbing alxdb/rusty_ogl [INFO] frobbed toml for alxdb/rusty_ogl written to work/ex/clippy-test-run/sources/stable/gh/alxdb/rusty_ogl/Cargo.toml [INFO] started frobbing alxdb/rusty_ogl [INFO] finished frobbing alxdb/rusty_ogl [INFO] frobbed toml for alxdb/rusty_ogl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alxdb/rusty_ogl/Cargo.toml [INFO] crate alxdb/rusty_ogl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alxdb/rusty_ogl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alxdb/rusty_ogl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] caec300dca96442b13c00361f30b0be84a571cf29f190e1f69c02f8488bf8209 [INFO] running `"docker" "start" "-a" "caec300dca96442b13c00361f30b0be84a571cf29f190e1f69c02f8488bf8209"` [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking num-complex v0.2.0 [INFO] [stderr] Checking approx v0.3.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking nalgebra v0.16.4 [INFO] [stderr] Checking nalgebra-glm v0.1.1 [INFO] [stderr] Checking rusty_ogl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | let spacing = size / divisions as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(divisions)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:19:58 [INFO] [stderr] | [INFO] [stderr] 19 | points.push(origin + glm::vec3(spacing * j as f32, spacing * i as f32, 0.0)); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:19:78 [INFO] [stderr] | [INFO] [stderr] 19 | points.push(origin + glm::vec3(spacing * j as f32, spacing * i as f32, 0.0)); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | points: vec![a.clone(), b.clone(), c.clone()], [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | points: vec![a.clone(), b.clone(), c.clone()], [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | points: vec![a.clone(), b.clone(), c.clone()], [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | origin.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | origin.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | origin.clone() + glm::vec3(0.0, 0.0, size), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | let spacing = size / divisions as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(divisions)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:112:47 [INFO] [stderr] | [INFO] [stderr] 112 | points.push(glm::vec3(x as f32, y as f32, z as f32) * spacing); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:112:57 [INFO] [stderr] | [INFO] [stderr] 112 | points.push(glm::vec3(x as f32, y as f32, z as f32) * spacing); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:112:67 [INFO] [stderr] | [INFO] [stderr] 112 | points.push(glm::vec3(x as f32, y as f32, z as f32) * spacing); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:28:47 [INFO] [stderr] | [INFO] [stderr] 28 | self.events_loop.poll_events(|ev| match ev { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 29 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 30 | | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] 31 | | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => (), [INFO] [stderr] 39 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | self.events_loop.poll_events(|ev| if let glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 29 | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] 30 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode [INFO] [stderr] 31 | { [INFO] [stderr] 32 | Some(glutin::VirtualKeyCode::Escape) => closed = true, [INFO] [stderr] 33 | _ => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:31:73 [INFO] [stderr] | [INFO] [stderr] 31 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 32 | | { [INFO] [stderr] 33 | | Some(glutin::VirtualKeyCode::Escape) => closed = true, [INFO] [stderr] 34 | | _ => (), [INFO] [stderr] 35 | | }, [INFO] [stderr] | |_____________________^ help: try this: `if let Some(glutin::VirtualKeyCode::Escape) = input.virtual_keycode { closed = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | let spacing = size / divisions as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(divisions)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:19:58 [INFO] [stderr] | [INFO] [stderr] 19 | points.push(origin + glm::vec3(spacing * j as f32, spacing * i as f32, 0.0)); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:19:78 [INFO] [stderr] | [INFO] [stderr] 19 | points.push(origin + glm::vec3(spacing * j as f32, spacing * i as f32, 0.0)); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | points: vec![a.clone(), b.clone(), c.clone()], [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | points: vec![a.clone(), b.clone(), c.clone()], [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | points: vec![a.clone(), b.clone(), c.clone()], [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | origin.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | origin.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geometry/primitives.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | origin.clone() + glm::vec3(0.0, 0.0, size), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | let spacing = size / divisions as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(divisions)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:112:47 [INFO] [stderr] | [INFO] [stderr] 112 | points.push(glm::vec3(x as f32, y as f32, z as f32) * spacing); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:112:57 [INFO] [stderr] | [INFO] [stderr] 112 | points.push(glm::vec3(x as f32, y as f32, z as f32) * spacing); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/geometry/primitives.rs:112:67 [INFO] [stderr] | [INFO] [stderr] 112 | points.push(glm::vec3(x as f32, y as f32, z as f32) * spacing); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:28:47 [INFO] [stderr] | [INFO] [stderr] 28 | self.events_loop.poll_events(|ev| match ev { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 29 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 30 | | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] 31 | | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => (), [INFO] [stderr] 39 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | self.events_loop.poll_events(|ev| if let glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 29 | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] 30 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode [INFO] [stderr] 31 | { [INFO] [stderr] 32 | Some(glutin::VirtualKeyCode::Escape) => closed = true, [INFO] [stderr] 33 | _ => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:31:73 [INFO] [stderr] | [INFO] [stderr] 31 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 32 | | { [INFO] [stderr] 33 | | Some(glutin::VirtualKeyCode::Escape) => closed = true, [INFO] [stderr] 34 | | _ => (), [INFO] [stderr] 35 | | }, [INFO] [stderr] | |_____________________^ help: try this: `if let Some(glutin::VirtualKeyCode::Escape) = input.virtual_keycode { closed = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `"docker" "inspect" "caec300dca96442b13c00361f30b0be84a571cf29f190e1f69c02f8488bf8209"` [INFO] running `"docker" "rm" "-f" "caec300dca96442b13c00361f30b0be84a571cf29f190e1f69c02f8488bf8209"` [INFO] [stdout] caec300dca96442b13c00361f30b0be84a571cf29f190e1f69c02f8488bf8209