[INFO] updating cached repository alvinmatias69/reverse-k-nearest-neighbour [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alvinmatias69/reverse-k-nearest-neighbour [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alvinmatias69/reverse-k-nearest-neighbour" "work/ex/clippy-test-run/sources/stable/gh/alvinmatias69/reverse-k-nearest-neighbour"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alvinmatias69/reverse-k-nearest-neighbour'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alvinmatias69/reverse-k-nearest-neighbour" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alvinmatias69/reverse-k-nearest-neighbour"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alvinmatias69/reverse-k-nearest-neighbour'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b3fbc3c4a7ac9c02b4722ff408d74031ebadc1e2 [INFO] sha for GitHub repo alvinmatias69/reverse-k-nearest-neighbour: b3fbc3c4a7ac9c02b4722ff408d74031ebadc1e2 [INFO] validating manifest of alvinmatias69/reverse-k-nearest-neighbour on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alvinmatias69/reverse-k-nearest-neighbour on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alvinmatias69/reverse-k-nearest-neighbour [INFO] finished frobbing alvinmatias69/reverse-k-nearest-neighbour [INFO] frobbed toml for alvinmatias69/reverse-k-nearest-neighbour written to work/ex/clippy-test-run/sources/stable/gh/alvinmatias69/reverse-k-nearest-neighbour/Cargo.toml [INFO] started frobbing alvinmatias69/reverse-k-nearest-neighbour [INFO] finished frobbing alvinmatias69/reverse-k-nearest-neighbour [INFO] frobbed toml for alvinmatias69/reverse-k-nearest-neighbour written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alvinmatias69/reverse-k-nearest-neighbour/Cargo.toml [INFO] crate alvinmatias69/reverse-k-nearest-neighbour has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alvinmatias69/reverse-k-nearest-neighbour against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alvinmatias69/reverse-k-nearest-neighbour:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ff784c98263bc65061a3abe2154e5ef74eb437161b2f3327cd2c77bf4e861cd [INFO] running `"docker" "start" "-a" "0ff784c98263bc65061a3abe2154e5ef74eb437161b2f3327cd2c77bf4e861cd"` [INFO] [stderr] Checking reverse_nearest_neighbour v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `found` [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let found = rknn::compute(&query_point, &interest_points, &object, k); [INFO] [stderr] | ^^^^^ help: consider using `_found` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib/common.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(distance, expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib/common.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(distance, expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/rknn.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | interest_points: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib/rknn.rs:12:32 [INFO] [stderr] | [INFO] [stderr] 12 | for point in interest_points.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib/rknn.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if distances[index] == query_distance { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(distances[index] - query_distance).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib/rknn.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if distances[index] == query_distance { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/rknn.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `reverse_nearest_neighbour`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `found` [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let found = rknn::compute(&query_point, &interest_points, &object, k); [INFO] [stderr] | ^^^^^ help: consider using `_found` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/rknn.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | interest_points: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib/rknn.rs:12:32 [INFO] [stderr] | [INFO] [stderr] 12 | for point in interest_points.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib/rknn.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if distances[index] == query_distance { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(distances[index] - query_distance).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib/rknn.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if distances[index] == query_distance { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/rknn.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `reverse_nearest_neighbour`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0ff784c98263bc65061a3abe2154e5ef74eb437161b2f3327cd2c77bf4e861cd"` [INFO] running `"docker" "rm" "-f" "0ff784c98263bc65061a3abe2154e5ef74eb437161b2f3327cd2c77bf4e861cd"` [INFO] [stdout] 0ff784c98263bc65061a3abe2154e5ef74eb437161b2f3327cd2c77bf4e861cd