[INFO] updating cached repository alvesmarcos/pascalzim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alvesmarcos/pascalzim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alvesmarcos/pascalzim" "work/ex/clippy-test-run/sources/stable/gh/alvesmarcos/pascalzim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alvesmarcos/pascalzim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alvesmarcos/pascalzim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alvesmarcos/pascalzim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alvesmarcos/pascalzim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b6949db97425ea212247da0ee7c1b7d7a01a1ada [INFO] sha for GitHub repo alvesmarcos/pascalzim: b6949db97425ea212247da0ee7c1b7d7a01a1ada [INFO] validating manifest of alvesmarcos/pascalzim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alvesmarcos/pascalzim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alvesmarcos/pascalzim [INFO] finished frobbing alvesmarcos/pascalzim [INFO] frobbed toml for alvesmarcos/pascalzim written to work/ex/clippy-test-run/sources/stable/gh/alvesmarcos/pascalzim/Cargo.toml [INFO] started frobbing alvesmarcos/pascalzim [INFO] finished frobbing alvesmarcos/pascalzim [INFO] frobbed toml for alvesmarcos/pascalzim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alvesmarcos/pascalzim/Cargo.toml [INFO] crate alvesmarcos/pascalzim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alvesmarcos/pascalzim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alvesmarcos/pascalzim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 529d49fae3aa984df97c608770c331613e7e0bc1c787610f7fe742004ad0073d [INFO] running `"docker" "start" "-a" "529d49fae3aa984df97c608770c331613e7e0bc1c787610f7fe742004ad0073d"` [INFO] [stderr] Checking pascalzim v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | self.deque_token.push_back(Symbol{ token: token, category: category, line: count }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:46:62 [INFO] [stderr] | [INFO] [stderr] 46 | self.deque_token.push_back(Symbol{ token: token, category: category, line: count }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `category` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | self.deque_token.push_back(Symbol{ token: token, category: category, line: count }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:46:62 [INFO] [stderr] | [INFO] [stderr] 46 | self.deque_token.push_back(Symbol{ token: token, category: category, line: count }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `category` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:386:15 [INFO] [stderr] | [INFO] [stderr] 386 | let mut saved_line = self.symbol.line; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:389:15 [INFO] [stderr] | [INFO] [stderr] 389 | let mut exp_result : Category = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:473:11 [INFO] [stderr] | [INFO] [stderr] 473 | let mut saved_operator = self.symbol.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:476:11 [INFO] [stderr] | [INFO] [stderr] 476 | let mut op1 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:477:11 [INFO] [stderr] | [INFO] [stderr] 477 | let mut op2 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:522:11 [INFO] [stderr] | [INFO] [stderr] 522 | let mut saved_operator = self.symbol.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:526:11 [INFO] [stderr] | [INFO] [stderr] 526 | let mut op1 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:527:11 [INFO] [stderr] | [INFO] [stderr] 527 | let mut op2 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:556:11 [INFO] [stderr] | [INFO] [stderr] 556 | let mut saved_operator = self.symbol.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:561:11 [INFO] [stderr] | [INFO] [stderr] 561 | let mut op1 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:562:11 [INFO] [stderr] | [INFO] [stderr] 562 | let mut op2 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:593:13 [INFO] [stderr] | [INFO] [stderr] 593 | let mut cat = self.match_token_category(self.symbol.clone()); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:614:11 [INFO] [stderr] | [INFO] [stderr] 614 | let mut cat = self.match_token_category(self.symbol.clone()); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_parser_program10` [INFO] [stderr] --> src/parser.rs:838:1 [INFO] [stderr] | [INFO] [stderr] 838 | fn test_parser_program10() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_parser_program12` [INFO] [stderr] --> src/parser.rs:854:1 [INFO] [stderr] | [INFO] [stderr] 854 | fn test_parser_program12() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_parser_program13` [INFO] [stderr] --> src/parser.rs:862:1 [INFO] [stderr] | [INFO] [stderr] 862 | fn test_parser_program13() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lexer::Scanner` [INFO] [stderr] --> src/lexer.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Scanner { [INFO] [stderr] 21 | | Scanner { deque_token: VecDeque::new() } [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | / loop { [INFO] [stderr] 33 | | if let Some(c) = iter.next() { [INFO] [stderr] 34 | | if c == ' ' { [INFO] [stderr] 35 | | while iter.peek() == Some(&' ') { iter.next(); } [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_______^ help: try: `while let Some(c) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lexer.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | Some(c) => if c.is_alphanumeric() || c==&'_' { true } else { false }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `c.is_alphanumeric() || c==&'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser::Parser` [INFO] [stderr] --> src/parser.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Parser { [INFO] [stderr] 36 | | Parser { [INFO] [stderr] 37 | | scanner: Scanner::new(), [INFO] [stderr] 38 | | stack: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for parser::Parser { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:652:30 [INFO] [stderr] | [INFO] [stderr] 652 | fn search_scope(&self, id: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:673:41 [INFO] [stderr] | [INFO] [stderr] 673 | fn is_program_or_procedure(&self, id: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:687:30 [INFO] [stderr] | [INFO] [stderr] 687 | fn search_stack(&self, id: &String) -> Category { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:386:15 [INFO] [stderr] | [INFO] [stderr] 386 | let mut saved_line = self.symbol.line; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:389:15 [INFO] [stderr] | [INFO] [stderr] 389 | let mut exp_result : Category = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:473:11 [INFO] [stderr] | [INFO] [stderr] 473 | let mut saved_operator = self.symbol.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:476:11 [INFO] [stderr] | [INFO] [stderr] 476 | let mut op1 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:477:11 [INFO] [stderr] | [INFO] [stderr] 477 | let mut op2 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:522:11 [INFO] [stderr] | [INFO] [stderr] 522 | let mut saved_operator = self.symbol.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:526:11 [INFO] [stderr] | [INFO] [stderr] 526 | let mut op1 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:527:11 [INFO] [stderr] | [INFO] [stderr] 527 | let mut op2 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:556:11 [INFO] [stderr] | [INFO] [stderr] 556 | let mut saved_operator = self.symbol.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:561:11 [INFO] [stderr] | [INFO] [stderr] 561 | let mut op1 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:562:11 [INFO] [stderr] | [INFO] [stderr] 562 | let mut op2 = self.types_stack.pop().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:593:13 [INFO] [stderr] | [INFO] [stderr] 593 | let mut cat = self.match_token_category(self.symbol.clone()); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:614:11 [INFO] [stderr] | [INFO] [stderr] 614 | let mut cat = self.match_token_category(self.symbol.clone()); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_parser_program10` [INFO] [stderr] --> src/parser.rs:838:1 [INFO] [stderr] | [INFO] [stderr] 838 | fn test_parser_program10() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_parser_program12` [INFO] [stderr] --> src/parser.rs:854:1 [INFO] [stderr] | [INFO] [stderr] 854 | fn test_parser_program12() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_parser_program13` [INFO] [stderr] --> src/parser.rs:862:1 [INFO] [stderr] | [INFO] [stderr] 862 | fn test_parser_program13() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lexer::Scanner` [INFO] [stderr] --> src/lexer.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Scanner { [INFO] [stderr] 21 | | Scanner { deque_token: VecDeque::new() } [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | / loop { [INFO] [stderr] 33 | | if let Some(c) = iter.next() { [INFO] [stderr] 34 | | if c == ' ' { [INFO] [stderr] 35 | | while iter.peek() == Some(&' ') { iter.next(); } [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_______^ help: try: `while let Some(c) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lexer.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | Some(c) => if c.is_alphanumeric() || c==&'_' { true } else { false }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `c.is_alphanumeric() || c==&'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lexer.rs:315:1 [INFO] [stderr] | [INFO] [stderr] 315 | / fn test_token_power() { [INFO] [stderr] 316 | | let mut s: Scanner = Scanner::new(); [INFO] [stderr] 317 | | s.build_token("files/program8.txt"); [INFO] [stderr] 318 | | [INFO] [stderr] ... | [INFO] [stderr] 349 | | assert_eq!(s.next_symbol().token, Token::Period); [INFO] [stderr] 350 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser::Parser` [INFO] [stderr] --> src/parser.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Parser { [INFO] [stderr] 36 | | Parser { [INFO] [stderr] 37 | | scanner: Scanner::new(), [INFO] [stderr] 38 | | stack: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for parser::Parser { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:652:30 [INFO] [stderr] | [INFO] [stderr] 652 | fn search_scope(&self, id: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:673:41 [INFO] [stderr] | [INFO] [stderr] 673 | fn is_program_or_procedure(&self, id: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:687:30 [INFO] [stderr] | [INFO] [stderr] 687 | fn search_stack(&self, id: &String) -> Category { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.88s [INFO] running `"docker" "inspect" "529d49fae3aa984df97c608770c331613e7e0bc1c787610f7fe742004ad0073d"` [INFO] running `"docker" "rm" "-f" "529d49fae3aa984df97c608770c331613e7e0bc1c787610f7fe742004ad0073d"` [INFO] [stdout] 529d49fae3aa984df97c608770c331613e7e0bc1c787610f7fe742004ad0073d