[INFO] updating cached repository alsprogrammer/rust_experiments [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alsprogrammer/rust_experiments [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alsprogrammer/rust_experiments" "work/ex/clippy-test-run/sources/stable/gh/alsprogrammer/rust_experiments"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alsprogrammer/rust_experiments'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alsprogrammer/rust_experiments" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alsprogrammer/rust_experiments"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alsprogrammer/rust_experiments'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8dc4155cbab6af70d7137cd7ad05cf57308bf2d [INFO] sha for GitHub repo alsprogrammer/rust_experiments: a8dc4155cbab6af70d7137cd7ad05cf57308bf2d [INFO] validating manifest of alsprogrammer/rust_experiments on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alsprogrammer/rust_experiments on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alsprogrammer/rust_experiments [INFO] finished frobbing alsprogrammer/rust_experiments [INFO] frobbed toml for alsprogrammer/rust_experiments written to work/ex/clippy-test-run/sources/stable/gh/alsprogrammer/rust_experiments/Cargo.toml [INFO] started frobbing alsprogrammer/rust_experiments [INFO] finished frobbing alsprogrammer/rust_experiments [INFO] frobbed toml for alsprogrammer/rust_experiments written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alsprogrammer/rust_experiments/Cargo.toml [INFO] crate alsprogrammer/rust_experiments has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alsprogrammer/rust_experiments against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alsprogrammer/rust_experiments:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4999c2e274472e10edeacc8b158ec1446d46c8909853e2ac9de7fbeed1189dc6 [INFO] running `"docker" "start" "-a" "4999c2e274472e10edeacc8b158ec1446d46c8909853e2ac9de7fbeed1189dc6"` [INFO] [stderr] Checking hello-rpi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | x = x + 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x += 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | y = y - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | copied_var = copied_var + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copied_var += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:97:24 [INFO] [stderr] | [INFO] [stderr] 97 | fn ref_string_length(s:&String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | x = x + 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x += 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | y = y - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | copied_var = copied_var + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copied_var += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:97:24 [INFO] [stderr] | [INFO] [stderr] 97 | fn ref_string_length(s:&String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "4999c2e274472e10edeacc8b158ec1446d46c8909853e2ac9de7fbeed1189dc6"` [INFO] running `"docker" "rm" "-f" "4999c2e274472e10edeacc8b158ec1446d46c8909853e2ac9de7fbeed1189dc6"` [INFO] [stdout] 4999c2e274472e10edeacc8b158ec1446d46c8909853e2ac9de7fbeed1189dc6